Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp26012878rwd; Mon, 3 Jul 2023 04:24:39 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6W3iXmyvAJjxKFMJrflfWIFSns1wq6gsk6buX/eyBsY9J9bpZiO+tQ/HXMPy5h+xhI2Okr X-Received: by 2002:a05:6a20:3943:b0:126:aa77:a118 with SMTP id r3-20020a056a20394300b00126aa77a118mr13103866pzg.16.1688383479645; Mon, 03 Jul 2023 04:24:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688383479; cv=none; d=google.com; s=arc-20160816; b=wXpuRx2gVPMVH+U//hJFN8jUGM1ywc7LXSj/saZ5Ond+dJv+iS3bBFdCQCF6sfo/8Z 52w6oNpWVzMH9av40yzX+rUDXIPMxbzaPuCK/0Yin4kB2Ak3sRvG0Mcnc0+TzU+VdBI5 M+mK5ARZQWCMK2sXXzbIbgeQVzmLqBB65mCdJbGQCa8GPKtrNtTpGt5kuxX0R9N3fOsM kipODqBImH5WA67uJFAf7zuS3FaQ0qUn+mfqj7ns9XBN5hOM4YqPPcdmm6b0w1VJ1cG/ zgcBtprOx+c0gLZTtFCD9ckZ6ereMSrutIVBlzBzWFZOZdG/JiBX+EvFOhm5PLYHp8/g vX/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=dcEfFuaLU8WuZ734FC2zjBdbWqPM0/tL5GbnbkXmB5c=; fh=rSaFsQxblytBnf9QilyFR0ot9sTVdfTlDv8QfweZEEE=; b=v9am8S64LkLrHr9KmoBr3aH7zw9puusb2KNVhj4sEyKKbyvxGr4NyMjGKRsgHbMVEO VcE0/cXQYcSHxjKbbYotEbIkUdQnMXLYWad3W+aFk96hP3ZbRHjdNinkKqZVm5Lqv+4+ xRA+PunyHbEVFwVVExjrqggnJs0na0oCfyT+q4bJmUBXMu0pRwY0KsczJoP/OjbYBH5r S2wG+PmHmGoBa8SS6KWMlaCSdpDrQOXX2Q5bkTj6+lyG1sJaGKL984qV+aWFMpXaBhej qlJfVnW4zmxeJmculaLUVPH+xN45djSTi3aah0ATFZQjQKYHrakDpytkT2PEad2hJoIe 68MQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=HxqdE4B3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m21-20020a056a00081500b0067f9d269213si11657667pfk.171.2023.07.03.04.24.26; Mon, 03 Jul 2023 04:24:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=HxqdE4B3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230344AbjGCKvG (ORCPT + 99 others); Mon, 3 Jul 2023 06:51:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230183AbjGCKvF (ORCPT ); Mon, 3 Jul 2023 06:51:05 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D84D9B2 for ; Mon, 3 Jul 2023 03:51:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688381463; x=1719917463; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=BadCQA6HO8laQVNoZwiU3/nTxzC9qflmlgQcwaZtETA=; b=HxqdE4B3KjUHccP/jfqljpQZ6FvO/UAV4jEOvKQZTpBtIgwWkkwVkRIG 5TAzIOceOS8lehg+0FkDjE+g44dSa4iVAuXwdzMjeqiDokrO71nkslaYK MM9wpJJ+O3Xhvxnr4qynnJceKyps7jy59E1HnVFM0JAsYcD4+jZerwdRP SIsx0ZIzQOOal4LE/NJPSqypYG5yVDJYT2KZtRNJmGgFd7fQgGw13BbBe O/5XhTOwzCbnySM7Y4xxHVnTi+Dk/LlWWiUYN85/JX7QRwAhG7Cpvnn9L EydKLo46dVLkpBzHinUbeM8YMjmXHzu3izp3SA1+6f2s1EjvLnr5vaOlY g==; X-IronPort-AV: E=McAfee;i="6600,9927,10759"; a="366335268" X-IronPort-AV: E=Sophos;i="6.01,178,1684825200"; d="scan'208";a="366335268" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jul 2023 03:51:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10759"; a="808529347" X-IronPort-AV: E=Sophos;i="6.01,178,1684825200"; d="scan'208";a="808529347" Received: from smile.fi.intel.com ([10.237.72.54]) by FMSMGA003.fm.intel.com with ESMTP; 03 Jul 2023 03:51:00 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qGH90-001qCc-2e; Mon, 03 Jul 2023 13:50:58 +0300 Date: Mon, 3 Jul 2023 13:50:58 +0300 From: Andy Shevchenko To: Andrew Morton , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino Subject: Re: [PATCH v1 1/1] kasan: Replace strreplace() with strchrnul() Message-ID: References: <20230628153342.53406-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230628153342.53406-1-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 28, 2023 at 06:33:42PM +0300, Andy Shevchenko wrote: > We don't need to traverse over the entire string and replace > occurrences of a character with '\0'. The first match will > suffice. Hence, replace strreplace() with strchrnul(). Not that it's a hot path, the bloat-o-meter shows +6 bytes on x86_64, the change seems has no added value, self-rejected. -- With Best Regards, Andy Shevchenko