Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 3 Jul 2023 12:56:15 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Takashi Iwai <tiwai@suse.de>
Cc:     Johan Hovold <johan@kernel.org>,
        Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        johan+linaro@kernel.org, perex@perex.cz, tiwai@suse.com,
        lgirdwood@gmail.com, ckeepax@opensource.cirrus.com,
        kuninori.morimoto.gx@renesas.com, linux-kernel@vger.kernel.org,
        pierre-louis.bossart@linux.intel.com, alsa-devel@alsa-project.org,
        Stable@vger.kernel.org
Subject: Re: [PATCH] ASoC: qdsp6: q6apm: use dai link pcm id as pcm device
 number
Message-ID: <80183a58-78ba-46b0-8d2a-502b5b28ffe4@sirena.org.uk>
References: <20230628092404.13927-1-srinivas.kandagatla@linaro.org>
 <ZKJ9UrB8FRkLzLc-@hovoldconsulting.com>
 <ZKKA6K44mp_vjwtp@hovoldconsulting.com>
 <877crh76ge.wl-tiwai@suse.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="U+PSF/XHDoszaQ30"
Content-Disposition: inline
In-Reply-To: <877crh76ge.wl-tiwai@suse.de>
Precedence: bulk


--U+PSF/XHDoszaQ30
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jul 03, 2023 at 10:19:29AM +0200, Takashi Iwai wrote:

> Isn't it rather an issue about the error code passing in qcom driver?
> How about the change like below?
>=20
>=20
> Takashi
>=20
> --- a/sound/soc/qcom/qdsp6/topology.c
> +++ b/sound/soc/qcom/qdsp6/topology.c
> @@ -1276,10 +1276,8 @@ int audioreach_tplg_init(struct snd_soc_component =
*component)
>  	}
> =20
>  	ret =3D snd_soc_tplg_component_load(component, &audioreach_tplg_ops, fw=
);
> -	if (ret < 0) {
> -		dev_err(dev, "tplg component load failed%d\n", ret);
> -		ret =3D -EINVAL;
> -	}
> +	if (ret < 0)
> +		dev_err_probe(dev, ret, "tplg component load failed %d\n", ret);

That looks like a sensible change in general anyway.

--U+PSF/XHDoszaQ30
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmSit14ACgkQJNaLcl1U
h9CjtAf7B2p1IgCA8Co/ROslWsAioKfyEfS43xyuwkb1ytO0MD50aPa5lID+D70f
NRxVkywvv6oMZ26fvEFsebBNY/ZMyYdEv2j+hJ7HJjAvfv+JVDuTfFVekmaugM5N
sFM8Pxs5WL12SecXUA6/zWgNt0DTncRKRyEMS5frnfYm+uiB4yT/rCeARNvbfgk3
FKh5SAzmH/ELKlfy2Y0Sn2/J/1Yc5axqR0ZAgJZd0Yl/NHR3sa1taYpTlMGl5B3y
xkBoNudvJrMSWq8v8VVZtisHZiXe//tSssEaTkFY6/4eSu8P9bmLX/Ge87K8IV9G
3L8mkAUNnKXEPq/nH97/BUNtEe3Xrw==
=NvHF
-----END PGP SIGNATURE-----

--U+PSF/XHDoszaQ30--