Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230616121637.1033074-1-juerg.haefliger@canonical.com>
In-Reply-To: <20230616121637.1033074-1-juerg.haefliger@canonical.com>
From:   Oded Gabbay <ogabbay@kernel.org>
Date:   Mon, 3 Jul 2023 15:31:58 +0300
Message-ID: <CAFCwf11dE5cnkJJH0TumpBEHohCy8FL6fQz9dfODn=c_WOsscg@mail.gmail.com>
Subject: Re: [PATCH] habanalabs/gaudi: Add MODULE_FIRMWARE macros
To:     Juerg Haefliger <juerg.haefliger@canonical.com>
Cc:     dri-devel@lists.freedesktop.org, osharabi@habana.ai,
        dliberman@habana.ai, linux-kernel@vger.kernel.org,
        dhirschfeld@habana.ai, talcohen@habana.ai
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Jun 16, 2023 at 3:16=E2=80=AFPM Juerg Haefliger
<juerg.haefliger@canonical.com> wrote:
>
> The module loads firmware so add MODULE_FIRMWARE macros to provide that
> information via modinfo.
>
> Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
> ---
>  drivers/accel/habanalabs/gaudi/gaudi.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/accel/habanalabs/gaudi/gaudi.c b/drivers/accel/haban=
alabs/gaudi/gaudi.c
> index a29aa8f7b6f3..cd034e98128a 100644
> --- a/drivers/accel/habanalabs/gaudi/gaudi.c
> +++ b/drivers/accel/habanalabs/gaudi/gaudi.c
> @@ -63,6 +63,10 @@
>  #define GAUDI_LINUX_FW_FILE    "habanalabs/gaudi/gaudi-fit.itb"
>  #define GAUDI_TPC_FW_FILE      "habanalabs/gaudi/gaudi_tpc.bin"
>
> +MODULE_FIRMWARE(GAUDI_BOOT_FIT_FILE);
> +MODULE_FIRMWARE(GAUDI_LINUX_FW_FILE);
> +MODULE_FIRMWARE(GAUDI_TPC_FW_FILE);
> +
>  #define GAUDI_DMA_POOL_BLK_SIZE                0x100 /* 256 bytes */
>
>  #define GAUDI_RESET_TIMEOUT_MSEC       2000            /* 2000ms */
> --
> 2.37.2
>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Applied to -next.
Thanks,
Oded