Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Kubalewski, Arkadiusz" <arkadiusz.kubalewski@intel.com>
To:     Jiri Pirko <jiri@resnulli.us>
CC:     "kuba@kernel.org" <kuba@kernel.org>,
        "vadfed@meta.com" <vadfed@meta.com>,
        "jonathan.lemon@gmail.com" <jonathan.lemon@gmail.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "corbet@lwn.net" <corbet@lwn.net>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "vadfed@fb.com" <vadfed@fb.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        "M, Saeed" <saeedm@nvidia.com>,
        "leon@kernel.org" <leon@kernel.org>,
        "richardcochran@gmail.com" <richardcochran@gmail.com>,
        "sj@kernel.org" <sj@kernel.org>,
        "javierm@redhat.com" <javierm@redhat.com>,
        "ricardo.canuelo@collabora.com" <ricardo.canuelo@collabora.com>,
        "mst@redhat.com" <mst@redhat.com>,
        "tzimmermann@suse.de" <tzimmermann@suse.de>,
        "Michalik, Michal" <michal.michalik@intel.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "jacek.lawrynowicz@linux.intel.com" 
        <jacek.lawrynowicz@linux.intel.com>,
        "airlied@redhat.com" <airlied@redhat.com>,
        "ogabbay@kernel.org" <ogabbay@kernel.org>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "nipun.gupta@amd.com" <nipun.gupta@amd.com>,
        "axboe@kernel.dk" <axboe@kernel.dk>,
        "linux@zary.sk" <linux@zary.sk>,
        "masahiroy@kernel.org" <masahiroy@kernel.org>,
        "benjamin.tissoires@redhat.com" <benjamin.tissoires@redhat.com>,
        "geert+renesas@glider.be" <geert+renesas@glider.be>,
        "Olech, Milena" <milena.olech@intel.com>,
        "kuniyu@amazon.com" <kuniyu@amazon.com>,
        "liuhangbin@gmail.com" <liuhangbin@gmail.com>,
        "hkallweit1@gmail.com" <hkallweit1@gmail.com>,
        "andy.ren@getcruise.com" <andy.ren@getcruise.com>,
        "razor@blackwall.org" <razor@blackwall.org>,
        "idosch@nvidia.com" <idosch@nvidia.com>,
        "lucien.xin@gmail.com" <lucien.xin@gmail.com>,
        "nicolas.dichtel@6wind.com" <nicolas.dichtel@6wind.com>,
        "phil@nwl.cc" <phil@nwl.cc>,
        "claudiajkang@gmail.com" <claudiajkang@gmail.com>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>, poros <poros@redhat.com>,
        mschmidt <mschmidt@redhat.com>,
        "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
        "vadim.fedorenko@linux.dev" <vadim.fedorenko@linux.dev>
Subject: RE: [RFC PATCH v8 08/10] ice: implement dpll interface to control cgu
Thread-Topic: [RFC PATCH v8 08/10] ice: implement dpll interface to control
 cgu
Thread-Index: AQHZms0YKn5zDyH6hUaEbqiMD+5Ufq+EPdwAgA5hq2CAAqMOgIAMKbiAgAaogpA=
Date:   Mon, 3 Jul 2023 12:37:18 +0000
Message-ID: <DM6PR11MB465726733894C7E64AD3367E9B29A@DM6PR11MB4657.namprd11.prod.outlook.com>
References: <20230609121853.3607724-1-arkadiusz.kubalewski@intel.com>
 <20230609121853.3607724-9-arkadiusz.kubalewski@intel.com>
 <ZISmmH0jqxZRB4VX@nanopsycho>
 <DM6PR11MB4657161D2871747A7B404EDD9B5FA@DM6PR11MB4657.namprd11.prod.outlook.com>
 <ZJLtR0c+tvCbUgri@nanopsycho> <ZJ0hQRcm6S05r8VE@nanopsycho>
In-Reply-To: <ZJ0hQRcm6S05r8VE@nanopsycho>
Accept-Language: pl-PL, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?PVXDhTcKNm0wvh8f8ozk+IbG4sqwZiGSXVSbwV7mVnY7opJCwx9EYpp6SaU1?=
 =?us-ascii?Q?ZAhHoWJr5M6mCpDkroKrvzCgKnHdHyqvOihnr3SFTpehT/YveBKMq06yGk9A?=
 =?us-ascii?Q?ChHYgBC/t9PCHcEJ+Irh6Bqv+bhJY2GP8L6R8ixL8kTLUHrA5vHnkhbrP9gv?=
 =?us-ascii?Q?aWiR3A+Eq1re/ZpVryKZRUuzud3oo5721gzi1lw9JRE/x7VVJHfieGcOsfIP?=
 =?us-ascii?Q?G8GLRvRp5nw5kpb01jBv8p9cSuyV9xtT7ULDFzl/W1y9k/+57R1Qh8/s7JH0?=
 =?us-ascii?Q?CmpCLGYiWyQmCCXGdoCf0j7I+K065k9vHl2P6Ae+RWg6P/C7MzcSrzs641r6?=
 =?us-ascii?Q?v7IwcwN0GiBpJqmfqRSw9UJBmYOJoZZJZ5C6sQfrvQQ9b4AgPH938cjXd35L?=
 =?us-ascii?Q?VvZOlCSRgsc1AXwDXQappgpZ23uAwsqcqR9qyXsofj/bWqr4LKSD37tkmx5F?=
 =?us-ascii?Q?MR7KRLkX9xDY3y32f9PTqb8HapWES8ZxBrQy5K2fCKt9hu3lH7G+QTMHPA3A?=
 =?us-ascii?Q?8xAZIMSvzOJcqOjVtPjgIMeAgGU629OUNXhVclDME960p7axuaSezIB399de?=
 =?us-ascii?Q?xjCb3sMP0wePZAi/ZH3JXKv4ySuZU8yBlPPojeZl47G1g8q/4Rl6liQBTH2A?=
 =?us-ascii?Q?Lhn3NhTykLv0GTJD4r9ZnxD5I0s24lfYqOYEVrPpnSF+YKnWEGrCx83J6kgf?=
 =?us-ascii?Q?O43K5VSbTzCuRVsxp53uIzqD1bCdDPvih0qdtZWiLLrJ5zXX5ese4I427tLM?=
 =?us-ascii?Q?MQHiXFyuhe7X5ykpVmi5/bHcFy+3qOc0lMNwkvCjc/TAQWPGfBNkMZMAxcAY?=
 =?us-ascii?Q?I5hGy6cBtExrl6+OFxhum6NlrnEk7z9uj6HOINGjXeGpRQXjPWoK9EklOPWL?=
 =?us-ascii?Q?AUi6XEYFwXe8GeM13z8Als7Xsh7Pd5zI6h9ymmGpiisEcbFFov1zid/isIlL?=
 =?us-ascii?Q?XsiJ9KlfnQnwcKOaCPCb5awblqAonoGnB5z9bVvozY8THEIPM0LcDvpDflC9?=
 =?us-ascii?Q?bTlgv5Xj99w1olueAuN9syRg4ze9hyiBQsa/jF1SZjjicqYYk6xJ8Xyc6SsA?=
 =?us-ascii?Q?spsnwUbFx3SScDpGypTcB+Cnht8S5JN5UtcS8pxdzW66KKASrrnwmbGZ1a8H?=
 =?us-ascii?Q?fBn0CCOGAwhFFo/NnAe8W+5ROfp9EvWkfVfm2noTlL6bwSqSxRJ8B0i9HFyW?=
 =?us-ascii?Q?vRN2GhJtdBnCL2cq9eIr9v1T/Vm6sfyifCtx/21S+vL+pOf1hKKWWJU9l5K9?=
 =?us-ascii?Q?1vmgh0ggl2mTYwUfOyUnL2qJOdls7xH+PfOPFC9LZbfxEuIobMvuVyZDbW7w?=
 =?us-ascii?Q?+oKa+YZOC5lbYN9FVgfT11FuPqbKcZ7O8Vx6dU5j0z9L2R0isNczA+9cEGfD?=
 =?us-ascii?Q?Wz7CdCWgEH7iwPfXEofEORQ195XgNNfaN6aHBqJmn1xjY0dOMqq8UZw/I6B2?=
 =?us-ascii?Q?QvLk2u1KrvTVsaLOCAMktQe8EeBgVFnVGJ5oI9vmlAjHxsBaT9egox8/c9Ni?=
 =?us-ascii?Q?zFyK28/dLy5PFe6ifFr0v4sdSedtvsh3FST1uwehK98Q4kL2dJfV+dXynvEN?=
 =?us-ascii?Q?uDYH0Pt8Ys8+cBfEWyZUrSRpp4vhw9uZt6WileIZUVba5QxwPqeujYwEvvpW?=
 =?us-ascii?Q?Ww=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4657.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 80a3dd08-d2b0-4de1-a9f5-08db7bc23d46
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jul 2023 12:37:18.4444
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: sYxsVzJgtF3aR9uS3FXMLuCua+815Q/tjvXirD5qgtak9TeulrplJ/ztthbgR/Ekie8sec84A69Aiqw5n+5RP7mAEvIEd/JqqoAfZavjE7Y=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4873
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>From: Jiri Pirko <jiri@resnulli.us>
>Sent: Thursday, June 29, 2023 8:14 AM
>
>Wed, Jun 21, 2023 at 02:29:59PM CEST, jiri@resnulli.us wrote:
>>Mon, Jun 19, 2023 at 10:34:12PM CEST, arkadiusz.kubalewski@intel.com
>wrote:
>>>>From: Jiri Pirko <jiri@resnulli.us>
>>>>Sent: Saturday, June 10, 2023 6:37 PM
>>>>
>>>>Fri, Jun 09, 2023 at 02:18:51PM CEST, arkadiusz.kubalewski@intel.com
>>>>wrote:
>>>>
>>>>[...]
>>>>
>>>>
>>>>>+static int ice_dpll_mode_get(const struct dpll_device *dpll, void *pr=
iv,
>>>>>+			     enum dpll_mode *mode,
>>>>>+			     struct netlink_ext_ack *extack)
>>>>>+{
>>>>>+	*mode =3D DPLL_MODE_AUTOMATIC;
>>>>
>>>>I don't understand how the automatic mode could work with SyncE. The
>>>>There is one pin exposed for one netdev. The SyncE daemon should select
>>>>exacly one pin. How do you achieve that?
>>>>Is is by setting DPLL_PIN_STATE_SELECTABLE on the pin-netdev you want t=
o
>>>>select and DPLL_PIN_STATE_DISCONNECTED on the rest?
>>>>
>>>>
>>>>[...]
>>>
>>>AUTOMATIC mode autoselects highest priority valid signal.
>>>As you have pointed out, for SyncE selection, the user must be able to
>>>manually
>>>select a pin state to enable recovery of signal from particular port.
>>>
>>>In "ice" case there are 2 pins for network PHY clock signal recovery, an=
d
>>>both
>>>are parent pins (MUX-type). There are also 4 pins assigned to netdevs
>>>(one per
>>>port). Thus passing a signal from PHY to the pin is done through the MUX=
-
>>>pin,
>>>by selecting proper state on pin-parent pair (where parent pins is highe=
st
>>>prio
>>>pin on dpll).
>>
>>Could you show me some examples please?
>
>Arkadiusz, could you please reply to this?
>Thanks!
>

Sure, sorry for the delays, let's try that.

'ice' use case:
Enabling a PHY clock recovery for DPLL_MODE_AUTOMATIC dpll (ID#0) with PHY
recovered clock signals (PIN_ID#13) being muxed using MUX-type pin (PIN_ID#=
2)

1. Set MUX-type pin to state selectable and highest priority on a dpll devi=
ce
(or make sure it is already configured):
CMD_PIN_SET:
	PIN_ID			2
	PIN_PARENT_DEVICE	(nest)
		ID		0
		PIN_STATE	SELECTABLE
		PIN_PRIO	0
(assume all the other pins have prio >=3D1)

2. Set connected state on a pin-parent_pin tuple where parent is a pin from=
 #1
CMD_PIN_SET:
	PIN_ID			13
	PIN_PARENT_PIN		(nest)
		PIN_ID		2
		PIN_STATE	CONNECTED

Thank you!
Arkadiusz

>>
>>
>>>
>>>Thank you!
>>>Arkadiusz