Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230703113142.424670-1-arnd@kernel.org>
In-Reply-To: <20230703113142.424670-1-arnd@kernel.org>
From:   Amir Goldstein <amir73il@gmail.com>
Date:   Mon, 3 Jul 2023 15:53:57 +0300
Message-ID: <CAOQ4uxj5v=zTsiXvHGD70nMcKSvTVwM2G0raCDePY64gofu+AQ@mail.gmail.com>
Subject: Re: [PATCH] ovl: mark ovl_redirect_mode() as static again
To:     Arnd Bergmann <arnd@kernel.org>
Cc:     Miklos Szeredi <miklos@szeredi.hu>,
        Christian Brauner <brauner@kernel.org>,
        Arnd Bergmann <arnd@arndb.de>, linux-unionfs@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Jul 3, 2023 at 2:31=E2=80=AFPM Arnd Bergmann <arnd@kernel.org> wrot=
e:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> This function was moved to another file and is no longer marked
> static there, causing a W=3D1 warning:
>
> fs/overlayfs/params.c:92:13: error: no previous prototype for 'ovl_redire=
ct_mode' [-Werror=3Dmissing-prototypes]
>
> This was probably lost by accident during the refactoring, as there is
> still no caller in another file, so add back the annotation.
>
> Fixes: 06bcaa2dafb7e ("ovl: move all parameter handling into params.{c,h}=
")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---

This is against a patch that is not upstream.
I will squash it.

Thanks,
Amir.

>  fs/overlayfs/params.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/overlayfs/params.c b/fs/overlayfs/params.c
> index b8c2f6056a9a8..a63160dbb0f95 100644
> --- a/fs/overlayfs/params.c
> +++ b/fs/overlayfs/params.c
> @@ -89,7 +89,7 @@ const struct constant_table ovl_parameter_redirect_dir[=
] =3D {
>         {}
>  };
>
> -const char *ovl_redirect_mode(struct ovl_config *config)
> +static const char *ovl_redirect_mode(struct ovl_config *config)
>  {
>         return ovl_parameter_redirect_dir[config->redirect_mode].name;
>  }
> --
> 2.39.2
>