Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Minjie Du <duminjie@vivo.com>
To:     chris@zankel.net, jcmvbkbc@gmail.com, sfr@canb.auug.org.au,
        linux-kernel@vger.kernel.org, 11162212@vivo.com
Cc:     opensource.kernel@vivo.com, Minjie Du <duminjie@vivo.com>
Subject: [PATCH v1] arch: free dev before return
Date:   Mon,  3 Jul 2023 20:32:43 +0800
Message-Id: <20230703123243.7795-1-duminjie@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+tkUPNNI64NPmD5uTc/R76La/qlIXClKVk1M0ZmrJ0czljjJOU3p3uFm9K4x?=
 =?us-ascii?Q?GbVjfMUk/XiH6etBjUeMfgKYXH/uRnaCO6lX/9TtmE1HhrIp+thVldMPAY9F?=
 =?us-ascii?Q?T6n44RGiTyU1xpdOqr28UB9WXVVl44lKvUxnedw5kCb8Dy66lYdp7Xh+R0Yj?=
 =?us-ascii?Q?xojDeU9i7MAEXDcbhGAGTmnL1gAduoBhwVTQyt7fozqoVf1sPSwIaMwMksJD?=
 =?us-ascii?Q?vuIcbi/kkTGoD/hvlkH+PBha9hh/894fqcAjdDzHAIzlx7etcmWYzTYiSlHE?=
 =?us-ascii?Q?Pg6V9gDmJAldYu4cS5bz7/fgAdJ1DlSDkPnYcMEEbLKA9WXQ5W0R3lpve5XS?=
 =?us-ascii?Q?FEG1S5R/U6nJPFVqOdQcXCH2RB7iGqIrtVkjmYuuJiZg5PHgwa2IwTaiDf0U?=
 =?us-ascii?Q?HRB0pgiaN5Lm9jBaTLgrB/KAAJHhgyU2LZpeSQuWIzAxkReuB0d3mjoR0W/h?=
 =?us-ascii?Q?Slx/WxjWiHz+9vDat5LRt8Xp1ucYn4RlVlvJb0rvG4zV6rZrPMnRJ8MqiYHR?=
 =?us-ascii?Q?eK8umpGUyPakSVYavXCuo4jEtmd+El/1hcmMRKQqzMFZr+25FEe/vJJG6ujj?=
 =?us-ascii?Q?Fz+6+9woRaNSpSUcoL0reDU4AZJvj9sqcLOQUWOnGUBMvhTeFqbLKswJrMy6?=
 =?us-ascii?Q?1RLoQBQPsfXhlti/JaKPz/PhublIt1YuajojhW0mZwWOooN4d/GpZS99s0Wm?=
 =?us-ascii?Q?JvH0OfSud1qLzIuUxDFJN5oGzY1/8k4TcnqU/FBRWWICndV0CaxXecbzCxal?=
 =?us-ascii?Q?mEh/dWtGVabg+c05svBmRFd2HD3e2mJq74Z8Vi43ujariWOkk4hnSXolpUp+?=
 =?us-ascii?Q?F6qDvCbRU5NdvopA0GQKb3pd7JsQRrOzVh3GbWQxq7aOhegJFuXahoTOIOkQ?=
 =?us-ascii?Q?fIeyPw4FiQGDoil8s5f/ioyPhMHFidnoru1Q+w4Jz1tiJakWd9btJ/aVH7hE?=
 =?us-ascii?Q?cHezU7w8Dl0Wyr5F7x8NIN8BIg4yunt6wOszeEbirLrilmkRXfCogWm1yicR?=
 =?us-ascii?Q?2Fd6jplM4xmctCjbKRqNqzqTt5DqFMDe1K6DXIV0yZNI6Qz4aBQUs0JO8c8l?=
 =?us-ascii?Q?64X9pj/vnCGYFEWsGVifdqmiLlHlwRk4U5Vt38pvDqwLnw5NEv6MSOv/D4np?=
 =?us-ascii?Q?2ozj+laujeF37v/ieoyXgi7MDLwkyEiDD4z3t1cfvcN/jyGf63u1Ru8+fPqk?=
 =?us-ascii?Q?lFxbdEpZJwZ8HmavvLEvL9fFrS73fsZE1R3lPRp9g45PUqjER6EzZOk893+m?=
 =?us-ascii?Q?ATxuVTXPBX7o5ih95LIGELojILmLBzBnsMNmO+KYbthWvYJn8tGTgsfepIaj?=
 =?us-ascii?Q?gCSHIo4RUfiB/oIlYvewQPeBbBbv81fs64qjBkntpzECV8jy/H7pzGHBtTy3?=
 =?us-ascii?Q?2e1GP4abcDbQLTCmv0iPVxx3jrUA3B5qAw5e50tLNizwX/vTqyuy1f9W0NEd?=
 =?us-ascii?Q?dGrNBaJLXvJn+DlH+IfAi5TVAVRbi7oWIoSub4bARfYV8z6FLOrM4TS5PzAo?=
 =?us-ascii?Q?7Gev7EMcUwCsKWCIKuwyqrhpXcZMj21u+OLRd7RBBqSAw18DEf6gh7D/AdLr?=
 =?us-ascii?Q?6qIE9vrkccR0xolh6titO7U4MVcE4OZIcvE0wKOf?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 110b1c6c-c267-40b0-49ea-08db7bc1a0b3
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB5288.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2023 12:32:56.0404
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PeX4aNMnbiNEjMFGIO1Dq0FJkwg3igdqds4fk28/ArnuStD285RguG5upgez2XD1KhCnVocuT6QkDImlptftkQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR06MB6134
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

We fixed a bug where the variable dev
was not freed before return.

Signed-off-by: Minjie Du <duminjie@vivo.com>
---
 arch/xtensa/platforms/iss/network.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/xtensa/platforms/iss/network.c b/arch/xtensa/platforms/iss/network.c
index 9ac46ab3a..e33f3b37c 100644
--- a/arch/xtensa/platforms/iss/network.c
+++ b/arch/xtensa/platforms/iss/network.c
@@ -540,6 +540,7 @@ static void iss_net_configure(int index, char *init)
 		rtnl_unlock();
 		pr_err("%s: error registering net device!\n", dev->name);
 		platform_device_unregister(&lp->pdev);
+		free_netdev(dev);
 		return;
 	}
 	rtnl_unlock();
-- 
2.39.0