Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To:     Cristian Marussi <cristian.marussi@arm.com>
CC:     "sudeep.holla@arm.com" <sudeep.holla@arm.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v3 0/4] firmware: arm_scmi: Add SCMI v3.2 pincontrol
 protocol basic support
Thread-Topic: [PATCH v3 0/4] firmware: arm_scmi: Add SCMI v3.2 pincontrol
 protocol basic support
Thread-Index: AQHZmJMVbH1082dFzEWEKtwTiutfE6+jTPOAgATd9wA=
Date:   Mon, 3 Jul 2023 12:58:17 +0000
Message-ID: <20230703125816.GA373048@EPUAKYIW0A6A>
References: <cover.1686063941.git.oleksii_moisieiev@epam.com>
 <ZJ6wtw7mz/FjBcx6@e120937-lin>
In-Reply-To: <ZJ6wtw7mz/FjBcx6@e120937-lin>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jhHBV6ZracnCR0Ek9zTvw2K+iPWZn0vDCuGWb8462QolvCNyQTCsL99Mm3JZ?=
 =?us-ascii?Q?TQH0qmu1y6VfdQtsYA+Bzo1i8Qbs5u9OFYIHIqouDCoXXIohv7QgAIZtmAXB?=
 =?us-ascii?Q?W5bBXH3dmd4VDTTyJCj2io59PWdGwxfpK3oyPimRv721Ylml7qe8hbVGOj3s?=
 =?us-ascii?Q?pu/qbdRwLIbQG9ZDXPX3x6L5MWjyYD9RqbjBBOceXVuJJkcGCGXX2jtohCxP?=
 =?us-ascii?Q?U0lWN3Br2BfRk3DwjOWW9bbDBPRMMS9Z/qkcDuS/jPAxTAI/0D4suhiNHbW8?=
 =?us-ascii?Q?146gWN+FXbFhLYt9UxSG17qTb+241qbTh/xyOTktqM1GGtQhgMmb2XEffqKA?=
 =?us-ascii?Q?iQlRq71fJqAGiqG1aF1RNOopzr1KRfOZl+1b6DBzpbOiSJR3VbFe++HYKHms?=
 =?us-ascii?Q?RNUmZH1+GHZS1saxTT9zS40nFe4Ev/X4nlQ/cVyc/FyqHlFjhwcznZGY6o23?=
 =?us-ascii?Q?G334L9nGkotsY9DzXx604qucT0MMpoZFMhHrInRdaSD9dBLHKHhW+YRlAqwi?=
 =?us-ascii?Q?038Rr1lYpVqRNHXG0kmD4lgaXDRGHCstef+sET+pq+SNGQr9bUb1A5LT7Mx5?=
 =?us-ascii?Q?TbJta7CWvCAiv6aH31p3Sg+zUBWuCsOvL6y4QpSEAzg4WeTsOquyqZ1Ah7SL?=
 =?us-ascii?Q?1zP/WJJYOoqs5IlXMsTgBbsMpU7w9KXTl4C/T/pgaGzGO0LITYOhhM/BxSvX?=
 =?us-ascii?Q?BJtaJD0mnB4zvccmUJjmVnHam0yRfHWuEhWAgx96bqAWZ59Jm0py7PVqpmIo?=
 =?us-ascii?Q?odcGxxnxtdB1m4YNeUm//p4lSNR34sRlNJYbY9i9LbBwdmQss5z7zr0pfCIR?=
 =?us-ascii?Q?LPkwq9SdY5qIrY99+VBVN4biQFsgofNgrVNMl9ftGU28HNNx7hwfK4qGk1A0?=
 =?us-ascii?Q?f54zqivh+w0WaZRceD5+t2hPa3iKvDSqx+S6nbDEvQCboKV1pWerj3EP+pgI?=
 =?us-ascii?Q?vSSv+rvs3r5XyRvJA+ZV8p8hq+ACaGxMDj/PYoSj0R66qnmJHrhs1YvciqrC?=
 =?us-ascii?Q?IrCrEbmYLVpjIg2MKJRNelkfevkWMSW/cIb+k2kQA+LdL5NHdDeuuDtllRUW?=
 =?us-ascii?Q?9MCaLmTTumQ3LnR4x4S10BD6a7W7tcnBVX77aT9is3G4k2iUT/hxk6H00/T2?=
 =?us-ascii?Q?8Rb7CpTA//OO9e+VGj5KrYBuA8a6LTPeg3+RiSbb4RGe+fYgWAaCG18kkMAc?=
 =?us-ascii?Q?qXGxdq8uZceVMIWl1llzpqklru84yQnOeeBSI2fiMA7E0HPCGl3TqutwV/xP?=
 =?us-ascii?Q?rOxpKM0xVtn9TSQFHWLZ7P8YkN1l8uJPUQdyTJIpMq8GIBaPCCmtac0BPf5O?=
 =?us-ascii?Q?s2nD2aBjMmNQJvUKPP2UdZahh6qHyW3erqwzUCmADb28UX4ZSDXyPGBJRCin?=
 =?us-ascii?Q?yEV+sLQlr2c8trPlmYKLmF/Y+upu6x/eVZThTs6OQpTIfN4rYk9xTl6wCh5U?=
 =?us-ascii?Q?aXpi6sNRlm0kmkKRqJM2eJU/ypLpYD4H8P5yJF1OrJFtgrgJJa+e+bAu3yYH?=
 =?us-ascii?Q?H0Ms4Cf83Hd3zjw6qTISdYHsiFdgzeRX/Bk9sVrNZSPY5ZYyG5kVBfhsZfz6?=
 =?us-ascii?Q?q4zFWvkywvqoi6mJRwUaE24kQtRXxG6nqPlsL6BfkFT7aTo3cJCFg+ej53bK?=
 =?us-ascii?Q?jA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4FF6A4A958317441A4DFA08248CABB5D@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 38e4df0f-f86a-472a-0405-08db7bc52b83
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jul 2023 12:58:17.1832
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: qabUFApVvsweI2WtKjtr32n/owZeYFufzjuHKGg7GJrxBaKTgfcdBTk58oBcvJEfxgt2oMileDpKRfoUMp6aD47Y9DiptXWEVH/hgNbqpyg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR03MB9942
X-Proofpoint-ORIG-GUID: ylSoMGu81qsK9N9uB6PFTYjHkd1KC6J8
X-Proofpoint-GUID: ylSoMGu81qsK9N9uB6PFTYjHkd1KC6J8
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-03_10,2023-06-30_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0
 priorityscore=1501 mlxscore=0 mlxlogscore=999 malwarescore=0
 impostorscore=0 lowpriorityscore=0 clxscore=1011 suspectscore=0
 bulkscore=0 phishscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2305260000 definitions=main-2307030116
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Cristian,

Thanks for the testing and for the review.
I will address all comments and v4 will be with v3.2 BETA changes.

Best regards,
Oleksii.

On Fri, Jun 30, 2023 at 11:38:47AM +0100, Cristian Marussi wrote:
> On Tue, Jun 06, 2023 at 04:22:26PM +0000, Oleksii Moisieiev wrote:
> > This Patch series is intended to introduce the potential generic driver=
 for
> > pin controls over SCMI protocol, provided in the latest beta version of=
 DEN0056 [0].
> >=20
> > On ARM-based systems, a separate Cortex-M based System Control Processo=
r (SCP)
> > provides control on pins, as well as with power, clocks, reset controll=
ers. In this case,
> > kernel should use one of the possible transports, described in [0] to a=
ccess SCP and
> > control clocks/power-domains etc. This driver is using SMC transport to=
 communicate with SCP via
> > SCMI protocol and access to the Pin Control Subsystem.
> >=20
>=20
> Hi Oleksii,
>=20
> sorry this review has been a bit delayed, I tested V3 in my setup and fou=
nd no
> practical issue. I'll post a few comments/remarks along the series.
>=20
> Beside addressing pending comments, I suppose that the next step will be =
anyway
> to address the upcoming changes in the new v3.2 BETA regarding support fo=
r
> multiple type/value set/get operations as requested by Peng.
>=20
> Thanks,
> Cristian=