Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230703085845.2052008-1-rick.wertenbroek@gmail.com>
 <997819c6-0798-e2f9-b94b-fedfbab7fdd8@arm.com> <20230703120825.GA2375438@rocinante>
In-Reply-To: <20230703120825.GA2375438@rocinante>
From:   Rick Wertenbroek <rick.wertenbroek@gmail.com>
Date:   Mon, 3 Jul 2023 14:59:39 +0200
Message-ID: <CAAEEuhpP+9ofqDqxL7NEfw5C5KTn-z=kQktgo_3d_w=w1pc+Eg@mail.gmail.com>
Subject: Re: [PATCH v2] PCI: rockchip: Use 64-bit mask on MSI 64-bit PCI address
To:     =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= <kw@linux.com>
Cc:     Robin Murphy <robin.murphy@arm.com>, alberto.dassatti@heig-vd.ch,
        dlemoal@kernel.org, Dan Carpenter <dan.carpenter@linaro.org>,
        stable@vger.kernel.org, Shawn Lin <shawn.lin@rock-chips.com>,
        Lorenzo Pieralisi <lpieralisi@kernel.org>,
        Rob Herring <robh@kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Heiko Stuebner <heiko@sntech.de>, linux-pci@vger.kernel.org,
        linux-rockchip@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Jul 3, 2023 at 2:08=E2=80=AFPM Krzysztof Wilczy=C5=84ski <kw@linux.=
com> wrote:
>
> Hello,
>
> > > A 32-bit mask was used on the 64-bit PCI address used for mapping MSI=
s.
> > > This would result in the upper 32 bits being unintentionally zeroed a=
nd
> > > MSIs getting mapped to incorrect PCI addresses if the address had any
> > > of the upper bits set.
> > >
> > > Replace 32-bit mask by appropriate 64-bit mask.
>
> [...]
> > > +#define PCIE_ADDR_MASK                     GENMASK(63, MIN_AXI_ADDR_=
BITS_PASSED)
> >
> > Nit: this probably wants to be GENMASK_ULL(), otherwise it might throw =
a
> > warning if compile-tested for 32-bit.
>
> I can change this to GENMASK_ULL() when I apply the patch.  Unless Rick
> wants to send v3 - either way would be fine. :)
>
>         Krzysztof

Thank you, I'd appreciate that rather than sending a v3.

Regards,
Rick