Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Minjie Du <duminjie@vivo.com>
To:     richard@nod.at, anton.ivanov@cambridgegreys.com,
        johannes@sipsolutions.net, sfr@canb.auug.org.au,
        linux-um@lists.infradead.org, linux-kernel@vger.kernel.org,
        11162212@vivo.com
Cc:     opensource.kernel@vivo.com, Minjie Du <duminjie@vivo.com>
Subject: [PATCH v2] drivers: use free_netdev before return
Date:   Mon,  3 Jul 2023 21:11:29 +0800
Message-Id: <20230703131129.8588-1-duminjie@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Uo3ZFieFJcFLjvjfPyfTj73J/sI5Du/euVRWv9eTi70cp8Ai7pbSHTcZmMjN?=
 =?us-ascii?Q?NkVupAghbAMPDdPgbh8k+04i/lIgV9flsUzzHZYyDbK/rFzsTi85lNepFpYU?=
 =?us-ascii?Q?g7BLGwBCUzHh12+BK+RuxtgPWk0EQlWvheufQ+sxpDofnuYftKt2upu2jkCx?=
 =?us-ascii?Q?lovO/rU0VZ9SDTAjXvoYKWKyoej3U/93rjxjpow0MV10Nzwxf6TsXN0KGKmo?=
 =?us-ascii?Q?UZPwbNBhb2kQLNnbZ0N9gpxrr3Tg306iBPeHdrlBYVetLHAt7s3sEB//krrX?=
 =?us-ascii?Q?z1hIsRFSEPzm2hiBOdXJH7ysibWayaEwhew0RNwpbJLU9pAkwgcmp6i0JtRm?=
 =?us-ascii?Q?/wxkEGHB4j3stGybeK02ZiSDi5x9d1Sjwstc2zOO6U6LQr5AuEYuN3VLx0AU?=
 =?us-ascii?Q?PP2wl6qiBNTH0DjhuGiEVMj11TXM6gqeYdsxgkZqrV1W8KpYcJwbeESSLhBz?=
 =?us-ascii?Q?0TTbHypEzwCh1+DKXq2rYXQge2F+48XSLk+Jkt/g96XBNto6SCHsvbZKq8Xp?=
 =?us-ascii?Q?zYtPTlGc9TeOGykpSwe8aYbb9ApTKBjd9Vp27wgqREtmfdsjxvcVsVkZdShb?=
 =?us-ascii?Q?tOiUcpu4noEQf5IYS5Zx+GkL1pFY7pqxLVm3r9R9qcvwbqR/OPao+tWbWhly?=
 =?us-ascii?Q?jLJC6yl4cEWy2dhIhBMme6WyWBaeg0OnqxwfhabGkSvfgJksbtEAZ2mU7w/N?=
 =?us-ascii?Q?MmBQYSlLRATTnAvh20K7oH608Eg3pkw96t5kZZBEkeVgBV4ftFAjlzADP0At?=
 =?us-ascii?Q?bdjEzXk/4e5fB2MrworWDQcu4VV6wH52mdfwW2c75C0OYYUe8KXq5k4hAs05?=
 =?us-ascii?Q?dnK/ZN8aRJQz6umcS8i/KBzOEa/CpDt+qEe2pG17lKvbilgOBko5Y37KDf/T?=
 =?us-ascii?Q?0WUBSD6m0Q5dRcfHFvOOgG1m3nu1v2N9RJaQgssiUhDE5rmIMFCXtR/FQ6t3?=
 =?us-ascii?Q?cCXuC8XACyI2mfxD+H7tBbaqCoOWdtlgRVxRyQrX/yxa5LcbrYQV5XQB8Kxt?=
 =?us-ascii?Q?gfSB402nxrd7a3yZQGJslRToXlMvAIAM8jaQ1WS9Hf2tZmBItFcKKvxoeE9B?=
 =?us-ascii?Q?dDkZZsjzx9IBwPsHem702XxSt5YIwQVL5esNwpt1iqRGpkC25D4UFeKIPelL?=
 =?us-ascii?Q?EbnEjE6fBCu5rTDF0aaj7iWs+AWNi9NQ8iDncy+TbwrzkPuLQxyG9oOysnwn?=
 =?us-ascii?Q?QSNl3x0G8T7nRSPJJ01XGX64fip07eoZixabH9CL3jENGO1bIFLuNRaiZ1Nm?=
 =?us-ascii?Q?aTGVnytSZ9i3FQd3IBdqMSwIO2Q7E5AN7DLAHfeSNQwvMvgt44L1sQJG2S+H?=
 =?us-ascii?Q?Hhx/z7QCNgE0aGbdvgsxjWCz8FCnp8PaqJ3UsYrQ+igvmniEoLLBHQl8hHS3?=
 =?us-ascii?Q?m9V3FcsT8EjNoHixBQw/j0HfDJMCQG7K3NMmqIA8fmADQlUr+shRa8gTMmIs?=
 =?us-ascii?Q?q+M9Cs2MO/oullALJJ6w8H7KrRZ6zvSQRWQ2f1YyEesaBIGo9fdRuWAPajGH?=
 =?us-ascii?Q?txeYLyxYBfACKeHvzm82V86/MvqzsqasUWOZcnBD4oTs/V9GSRGZ4XA8K4cV?=
 =?us-ascii?Q?C+W1c4v+1OBqPvgnYhVNKKaUTtWeX9wOYqKzEt7N?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f4d36b2c-2ed9-4210-9fd1-08db7bc70d06
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB5288.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2023 13:11:45.2116
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: O38HmcdpqxxPhlC8t6L3cuJZ2cRDXOWjNOAW7+yjpshkmyk6o2n93ediGyiS6cuaqsZAMj8NoF4EGPy7Dg2zFA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY0PR06MB5845
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

We will replace the old version of 
undo_user_init and use out_free_netdev

Signed-off-by: Minjie Du <duminjie@vivo.com>
---
 arch/um/drivers/vector_kern.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/arch/um/drivers/vector_kern.c b/arch/um/drivers/vector_kern.c
index af7f6fd4c..7ae6ab8df 100644
--- a/arch/um/drivers/vector_kern.c
+++ b/arch/um/drivers/vector_kern.c
@@ -1646,7 +1646,7 @@ static void vector_eth_configure(
 	err = register_netdevice(dev);
 	rtnl_unlock();
 	if (err)
-		goto out_undo_user_init;
+		goto out_free_netdev;
 
 	spin_lock(&vector_devices_lock);
 	list_add(&device->list, &vector_devices);
@@ -1654,9 +1654,6 @@ static void vector_eth_configure(
 
 	return;
 
-out_undo_user_init:
-	free_netdev(dev);
-	return;
 out_free_netdev:
 	free_netdev(dev);
 out_free_device:
-- 
2.39.0