Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp26257491rwd; Mon, 3 Jul 2023 07:24:29 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ43v9aX4InrqKL7ZT+MhCpEPdmx0evnu76fm720x0jQhpGny9a6fH3ky2uHZQr1SrDOZlBe X-Received: by 2002:a05:6a20:9695:b0:127:4fb0:d448 with SMTP id hp21-20020a056a20969500b001274fb0d448mr8774101pzc.9.1688394268782; Mon, 03 Jul 2023 07:24:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688394268; cv=none; d=google.com; s=arc-20160816; b=GZMdBCsArr+9i4ZngLIZ4z9yyZN3xp/hljBduKILq0DARiNMfwv9m8EAPwiNPSoUNL NfdR+Z87BI6jyM1dsxz+ZXyOplFzJmYQ2KmKPTp3gLD+JGGxCQYHhZe/uhI+kcqgTsCi z+flUHPTO44K8BwGvlvrGsdxoSgs2EPJUYoVG75i/xLcXfHwxrjfu3PpWiPKplq/HFZE KQ5LztGsroMhNnE1uDMOA9lOlLEdaI8vpQN/tGdERnFo+IuxmRdBfZzIsDB6P2aU9Avc csEpuigtneoOIgkbaaOz6hLniq7fr7LXdqsprG2SQG61B14KwMM3dC99Gzd/z7OuP+45 zWEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=/xDUI5Q906ciUbfcDiykpf9BVkc6g7s8NDLUda0HoY8=; fh=RXyKyeyQzAcusT2OQA6dG83yFiRRvmf5xAXRiao8ycY=; b=SwLZWRlS7VfRnsvANLIRDAu5GrozrdQ+JJnvubeGZyMJrzTcWHaawOrSKVLdff7y5N RngHInIcFS4WF+RZWo1qGybmxfOsY9+hfZYWWNsJbmyj2vV5ZEEiQTU4FgQyixuC4rff bJP42SrrKGVNMbf+ftcEadqyO+K2/Jvy18eVtss70QskjKYG/NxXKsyhX4E8Cgd78ggV mUN5fzALj9G6hQgKObdbPF/ZIa9wfy718Szwg7GDsEGToBXlhL+foaER4Ka576gxk6xa cJ7LmBd54tgRZOf5z4mVU4VFhMv5/tk8CCDrexLzsvEiYfa+mKp8HRnqb8G8II5pZFcr PLhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=E5QstPWr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m14-20020a170902f64e00b001b5656e7d76si19113429plg.293.2023.07.03.07.24.14; Mon, 03 Jul 2023 07:24:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=E5QstPWr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229974AbjGCOKZ (ORCPT + 99 others); Mon, 3 Jul 2023 10:10:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231140AbjGCOKG (ORCPT ); Mon, 3 Jul 2023 10:10:06 -0400 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9971C10C6 for ; Mon, 3 Jul 2023 07:09:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688393390; x=1719929390; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=pkVtFXlRR5kYwBtMS5BvxTwSslZj/ncacXtF+PbTuz0=; b=E5QstPWrPosXM80XRoSpT+3ebkXnXOD1iWLzAVfyohX//iifKt8/TjgW rCGDP1r88SxBRB0ZIN7HOFlUS1iUdlPgdfEo/6eiZ/PQrmZxi4MfFsT9X 5Jg0ZymGDp0B940S8UqG2OyWQtd8RO7ZwnBRunkEfwcvZYx4jnbCQQYrW qe9zstKA5F7giM/Pqh5J7VVWYGlF8GSY+gywU6M3P80qCiaPC+z4hnixH V5SCmXVoGtPz5vSjjiTvHrI4qzSk74Zeow0ASmc8x8L2UGTriAadpIGYH FFI67VOjKr50ojhhg0ZM8pCev/ETt3+Axwzf36jDO5vaV5aG+h15zzsqA Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10760"; a="347678393" X-IronPort-AV: E=Sophos;i="6.01,178,1684825200"; d="scan'208";a="347678393" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jul 2023 07:09:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10760"; a="863097210" X-IronPort-AV: E=Sophos;i="6.01,178,1684825200"; d="scan'208";a="863097210" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 03 Jul 2023 07:09:21 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id C388013C; Mon, 3 Jul 2023 17:09:24 +0300 (EEST) From: Andy Shevchenko To: linux-kernel@vger.kernel.org Cc: Lee Jones , Andy Shevchenko Subject: [PATCH v2 2/2] mfd: ipaq-micro: Add missing break for the default case Date: Mon, 3 Jul 2023 17:09:23 +0300 Message-Id: <20230703140923.2840-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20230703140923.2840-1-andriy.shevchenko@linux.intel.com> References: <20230703140923.2840-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Even default case should have a break statement to make code robust against changes (e.g., adding a case after the default one). Add missing break for the default case. --- v2: new patch drivers/mfd/ipaq-micro.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/ipaq-micro.c b/drivers/mfd/ipaq-micro.c index cddfd2e808f2..57fb7874fc91 100644 --- a/drivers/mfd/ipaq-micro.c +++ b/drivers/mfd/ipaq-micro.c @@ -132,6 +132,7 @@ static void micro_rx_msg(struct ipaq_micro *micro, u8 id, int len, u8 *data) default: dev_err(micro->dev, "unknown msg %d [%d] %*ph\n", id, len, len, data); + break; } spin_unlock(µ->lock); } -- 2.40.0.1.gaa8946217a0b