Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Jonathan Corbet <corbet@lwn.net>
To:     Olaf Hering <olaf@aepfle.de>,
        "Paul E. McKenney" <paulmck@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Randy Dunlap <rdunlap@infradead.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        "Steven Rostedt (Google)" <rostedt@goodmis.org>,
        Kim Phillips <kim.phillips@amd.com>,
        Wyes Karny <wyes.karny@amd.com>,
        Tiezhu Yang <yangtiezhu@loongson.cn>,
        Prarit Bhargava <prarit@redhat.com>,
        Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        rcu@vger.kernel.org, linux-kselftest@vger.kernel.org
Cc:     Josh Triplett <josh@joshtriplett.org>,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        Lai Jiangshan <jiangshanlai@gmail.com>,
        Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH v1] Fix documentation of panic_on_warn
In-Reply-To: <20230630145307.25865-1-olaf@aepfle.de>
References: <20230630145307.25865-1-olaf@aepfle.de>
Date:   Mon, 03 Jul 2023 08:36:27 -0600
Message-ID: <87ilb1jc44.fsf@meer.lwn.net>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Olaf Hering <olaf@aepfle.de> writes:

> The kernel cmdline option panic_on_warn expects an integer, it is not a
> plain option as documented. A number of uses in the tree figured this
> already, and use panic_on_warn=1 for their purpose.
>
> Adjust a comment which otherwise may mislead people in the future.
>
> Fixes: 9e3961a097 ("kernel: add panic_on_warn")
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> ---
>  Documentation/admin-guide/kernel-parameters.txt | 2 +-
>  tools/testing/selftests/rcutorture/bin/kvm.sh   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 9e5bab29685f..15196f84df49 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -4049,7 +4049,7 @@
>  			extra details on the taint flags that users can pick
>  			to compose the bitmask to assign to panic_on_taint.
>  
> -	panic_on_warn	panic() instead of WARN().  Useful to cause kdump
> +	panic_on_warn=1	panic() instead of WARN().  Useful to cause kdump
>  			on a WARN().

Applied, thanks.

jon