Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230703123243.7795-1-duminjie@vivo.com>
In-Reply-To: <20230703123243.7795-1-duminjie@vivo.com>
From:   Max Filippov <jcmvbkbc@gmail.com>
Date:   Mon, 3 Jul 2023 07:19:33 -0700
Message-ID: <CAMo8Bf+rgAnzMF732rzNgWbnmijFbr1yd5aCiY1Hcf4qdpj6FQ@mail.gmail.com>
Subject: Re: [PATCH v1] arch: free dev before return
To:     Minjie Du <duminjie@vivo.com>
Cc:     chris@zankel.net, sfr@canb.auug.org.au,
        linux-kernel@vger.kernel.org, 11162212@vivo.com,
        opensource.kernel@vivo.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Minjie,

On Mon, Jul 3, 2023 at 5:33=E2=80=AFAM Minjie Du <duminjie@vivo.com> wrote:
>
> We fixed a bug where the variable dev
> was not freed before return.
>
> Signed-off-by: Minjie Du <duminjie@vivo.com>
> ---
>  arch/xtensa/platforms/iss/network.c | 1 +
>  1 file changed, 1 insertion(+)

Applied to my xtensa tree with the following commit message:

   xtensa: ISS: fix etherdev leak in error return path

   iss_net_configure frees etherdev in all error return paths except one
   where register_netdevice fails. Add missing free_netdev to that path.

--=20
Thanks.
-- Max