Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 3 Jul 2023 16:42:05 +0200
From:   Ahelenia =?utf-8?Q?Ziemia=C5=84ska?= 
        <nabijaczleweli@nabijaczleweli.xyz>
To:     Christian Brauner <brauner@kernel.org>
Cc:     Alexander Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
        Amir Goldstein <amir73il@gmail.com>,
        Chung-Chiang Cheng <cccheng@synology.com>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v5 0/3] fanotify accounting for fs/splice.c
Message-ID: <cover.1688393619.git.nabijaczleweli@nabijaczleweli.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="h7vuydtxhwlulk7a"
Content-Disposition: inline
User-Agent: NeoMutt/20230517
Precedence: bulk


--h7vuydtxhwlulk7a
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Previously: https://lore.kernel.org/linux-fsdevel/jbyihkyk5dtaohdwjyivambb2=
gffyjs3dodpofafnkkunxq7bu@jngkdxx65pux/t/#u

In short:
  * most read/write APIs generate ACCESS/MODIFY for the read/written file(s)
  * except the [vm]splice/tee family
    (actually, since 6.4, splice itself /does/ generate events but only
     for the non-pipes being spliced from/to; this commit is Fixes:ed)
  * userspace that registers (i|fa)notify on pipes usually relies on it
    actually working (coreutils tail -f is the primo example)
  * it's sub-optimal when someone with a magic syscall can fill up a
    pipe simultaneously ensuring it will never get serviced

Thus: actually generate ACCESS/MODIFY for all the
[vm]spliced/teed-from/to files.

LTP tests are staged in
  https://git.sr.ht/~nabijaczleweli/ltp/commit/v4
("inotify13: new test for fs/splice.c functions vs pipes vs inotify"),
validating that one A and/or one M event per [vm]splice(), tee(),
and sendfile() is generated =E2=80=92
without this patchset, this only holds for sendfile().

Amir has identified a potential performance impact caused by
correctly generating events, and has prepared patches at
  https://github.com/amir73il/linux/commits/fsnotify_pipe
that optimise the most common cases more aggressively.

Please review, and please consider taking these through the vfs
tree for 6.6.

Thanks,
Ahelenia Ziemia=C5=84ska (3):
  splice: always fsnotify_access(in), fsnotify_modify(out) on success
  splice: fsnotify_access(fd)/fsnotify_modify(fd) in vmsplice
  splice: fsnotify_access(in), fsnotify_modify(out) on success in tee

 fs/splice.c | 43 +++++++++++++++++++++++++------------------
 1 file changed, 25 insertions(+), 18 deletions(-)

--=20
2.39.2

--h7vuydtxhwlulk7a
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEfWlHToQCjFzAxEFjvP0LAY0mWPEFAmSi3j0ACgkQvP0LAY0m
WPEtEQ/9F6xggxB4EolNBUV1fvUunoQyDjqsg//EpbRE/TxQUdUnVrYtCuNxM0gE
jphR/F8R2h2iJmf3p8d/Omjshnggp45+fnKFH3xoY3dNctPNUujmWEDFPtMPPrc6
ZI63MAg/nDUORSlMBu4mCmBWhwkjXR+NViseN49vZQEkkxZiJP8RVBCQUNevze/Q
ZSXE3wjXzMFRU1Q+qa64Zwz5cQnhQxkUHMt/8ILLbrlDCC8WO1wj8ZfwIIT5HGza
kC8AgMIhm/LpjBg/RP8xgqySAawRbJuPXd/jRdCI4gAgERZSCPoHtWMpAj/kP4vN
YzbsWJjH5qsvnEmDl6f6UWTMc+MygDbNF3RawoA2qM0WADISzKyq6fr2f+M+Q47I
JdP1DhzXg4BtUNHadJvKEkWhw0+S2WEF0pPnN7JAoX3IE5K7Wg9cC4U4Og4IiA0i
xp5XaECxIKxAOSVUf/HOXnKbJjO+gGIL9CuXAAx0cYp4xEi/H+HMxZU1KdJ9a0Mh
FJxox+P1Ghsfu8/fj9kQjGvNSikfufzxBGHxVo/1pF6cW0DMtXLrQDeCnfXhXKGX
twKYgURcYzDkbJ0gjRJbwbenGhZL56IwRG0rEbIzyMg49qlhT8CARwabGDj4RiWW
OLMcKJJgLxx78aRQ+STrY7Yu584PZgJpPPKAy4dvRhB3DgBg8lI=
=g2al
-----END PGP SIGNATURE-----

--h7vuydtxhwlulk7a--