Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9bb176c9-f1e6-349e-5486-74e0ea6b5012@ti.com>
Date:   Mon, 3 Jul 2023 20:13:55 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [EXTERNAL] Re: [PATCH] PCI: j721e: Fix delay before PERST#
 deassert
Content-Language: en-US
To:     Li Chen <me@linux.beauty>
CC:     Vignesh Raghavendra <vigneshr@ti.com>,
        Tom Joseph <tjoseph@cadence.com>,
        Lorenzo Pieralisi <lpieralisi@kernel.org>,
        Krzysztof Wilczy_ski <kw@linux.com>,
        Rob Herring <robh@kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        linux-omap <linux-omap@vger.kernel.org>,
        linux-pci <linux-pci@vger.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
References: <20230703112914.68806-1-a-verma1@ti.com>
 <1891c041807.fea67a55448140.3454059194195387266@linux.beauty>
From:   "Verma, Achal" <a-verma1@ti.com>
In-Reply-To: <1891c041807.fea67a55448140.3454059194195387266@linux.beauty>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 7/3/2023 7:19 PM, Li Chen wrote:
> Hi Achal,
>   ---- On Mon, 03 Jul 2023 19:29:14 +0800  Achal Verma  wrote ---
>   > As per the PCIe Card Electromechanical specification REV. 3.0, PERST#
>   > signal should be de-asserted after minimum 100ms from the time power-rails
>   > become stable. Current delay of 100us is observed to be not enough on some
>   > custom platform implemented using TI's K3 SOCs.
>   >
>   > So, to ensure 100ms delay to give sufficient time for power-rails and
>   > refclk to become stable, change delay from 100us to 100ms.
> 
> What problems could arise if the delay is too small? Would some endpoints not be able to detect it?
If delay is small, cpu stall is reported during probe() while accessing 
PCIe registers in some cases.
> 
> Regards,
> Li