Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751661AbXJVVFv (ORCPT ); Mon, 22 Oct 2007 17:05:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751029AbXJVVFm (ORCPT ); Mon, 22 Oct 2007 17:05:42 -0400 Received: from filer.fsl.cs.sunysb.edu ([130.245.126.2]:35682 "EHLO filer.fsl.cs.sunysb.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750980AbXJVVFl (ORCPT ); Mon, 22 Oct 2007 17:05:41 -0400 Date: Mon, 22 Oct 2007 17:04:21 -0400 Message-Id: <200710222104.l9ML4L1D002031@agora.fsl.cs.sunysb.edu> From: Erez Zadok To: Hugh Dickins Cc: Pekka Enberg , Erez Zadok , Ryan Finnie , Andrew Morton , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, cjwatson@ubuntu.com, linux-mm@kvack.org Subject: Re: msync(2) bug(?), returns AOP_WRITEPAGE_ACTIVATE to userland In-reply-to: Your message of "Mon, 22 Oct 2007 21:16:17 BST." X-MailKey: Erez_Zadok Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1551 Lines: 34 In message , Hugh Dickins writes: > On Mon, 15 Oct 2007, Pekka Enberg wrote: > > > > I wonder whether _not setting_ BDI_CAP_NO_WRITEBACK implies that > > ->writepage() will never return AOP_WRITEPAGE_ACTIVATE for > > !wbc->for_reclaim case which would explain why we haven't hit this bug > > before. Hugh, Andrew? > > Only ramdisk and shmem have been returning AOP_WRITEPAGE_ACTIVATE. > Both of those set BDI_CAP_NO_WRITEBACK. ramdisk never returned it > if !wbc->for_reclaim. I contend that shmem shouldn't either: it's > a special code to get the LRU rotation right, not useful elsewhere. > Though Documentation/filesystems/vfs.txt does imply wider use. Yes, based on vfs.txt I figured unionfs should return AOP_WRITEPAGE_ACTIVATE. But, now that unionfs has ->writepages which won't even call the lower writepage if BDI_CAP_NO_WRITEBACK is on, then perhaps I no longer need unionfs_writepage to bother checking for AOP_WRITEPAGE_ACTIVATE, or even return it up? But, a future file system _could_ return AOP_WRITEPAGE_ACTIVATE w/o setting BDI_CAP_NO_WRITEBACK, right? In that case, unionfs will still need to handle AOP_WRITEPAGE_ACTIVATE in ->writepage, right? > I think this is where people use the phrase "go figure" ;) > > Hugh Erez. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/