Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Christian Brauner <brauner@kernel.org>
To:     =?utf-8?q?Ahelenia_Ziemia=C5=84ska_=3Cnabijaczleweli=40nabijaczleweli=2E?=@vger.kernel.org,
        =?utf-8?q?xyz=3E?=@vger.kernel.org
Cc:     Christian Brauner <brauner@kernel.org>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Jan Kara <jack@suse.cz>, Amir Goldstein <amir73il@gmail.com>,
        Chung-Chiang Cheng <cccheng@synology.com>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 0/3] fanotify accounting for fs/splice.c
Date:   Mon,  3 Jul 2023 17:44:15 +0200
Message-Id: <20230703-heilkraft-wohlbefinden-1f293bd90cf3@brauner>
In-Reply-To: <cover.1688393619.git.nabijaczleweli@nabijaczleweli.xyz>
References: <cover.1688393619.git.nabijaczleweli@nabijaczleweli.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Mon, 03 Jul 2023 16:42:05 +0200, Ahelenia Ziemiańska wrote:
> Previously: https://lore.kernel.org/linux-fsdevel/jbyihkyk5dtaohdwjyivambb2gffyjs3dodpofafnkkunxq7bu@jngkdxx65pux/t/#u
> 
> In short:
>   * most read/write APIs generate ACCESS/MODIFY for the read/written file(s)
>   * except the [vm]splice/tee family
>     (actually, since 6.4, splice itself /does/ generate events but only
>      for the non-pipes being spliced from/to; this commit is Fixes:ed)
>   * userspace that registers (i|fa)notify on pipes usually relies on it
>     actually working (coreutils tail -f is the primo example)
>   * it's sub-optimal when someone with a magic syscall can fill up a
>     pipe simultaneously ensuring it will never get serviced
> 
> [...]

Fixed the missing single-line-{} after multi-line-{} style problem that
Amir mentioned.

---

Applied to the vfs.misc branch of the vfs/vfs.git tree.
Patches in the vfs.misc branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.misc

[1/3] splice: always fsnotify_access(in), fsnotify_modify(out) on success
      https://git.kernel.org/vfs/vfs/c/cade9d70ce70
[2/3] splice: fsnotify_access(fd)/fsnotify_modify(fd) in vmsplice
      https://git.kernel.org/vfs/vfs/c/6aa55b7b85b5
[3/3] splice: fsnotify_access(in), fsnotify_modify(out) on success in tee
      https://git.kernel.org/vfs/vfs/c/6e7556086b19