Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 3 Jul 2023 19:08:26 +0300
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Ido Schimmel <idosch@nvidia.com>
Cc:     netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Roopa Prabhu <roopa@nvidia.com>,
        Nikolay Aleksandrov <razor@blackwall.org>,
        "Michael S. Tsirkin" <mst@redhat.com>,
        Vlad Yasevich <vyasevic@redhat.com>,
        bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: bridge: keep ports without IFF_UNICAST_FLT in
 BR_PROMISC mode
Message-ID: <20230703160826.5wx5mmszr67hvjmw@skbuf>
References: <20230630164118.1526679-1-vladimir.oltean@nxp.com>
 <ZKKADtxlXyPmBvbr@shredder>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZKKADtxlXyPmBvbr@shredder>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tQCIspRyyP1BPh1tNZ6uATXzgPsd1QNiRPmBjeSDhBqyB61/NqwM/xJOiEtZ?=
 =?us-ascii?Q?li01loeIfJYcvlorWUIBFy84cRZci9iP0tD6Bv8P2A3mWExyIcM9ZTzmfs7a?=
 =?us-ascii?Q?iVeY5T92kJFcDkOfOcGGrZZcmFVWP6tQJdSF3r/JL5qG/BGI9mMU0vkhNruE?=
 =?us-ascii?Q?SjlCwrrIoKVo5Jmob8U8NLVNIfDvjv8jM+p5b4DxsoZQwPx/UrIZSSVZVELg?=
 =?us-ascii?Q?Z8tf5WC8Zg4BDCDAyXOf9V+IDMpmrQuoPuqFW4qhOHRwGm4UxgujGRW7i2E4?=
 =?us-ascii?Q?WmTDmUG9mVjtAtvqULhUdS4Leq/UHX3P8DXE4zVp/JpSiCXFxeQAOANZt0Yt?=
 =?us-ascii?Q?H6/1Duv7yx2aY0PeDeuZrZhTCZfRdPJ8s5sEvnvg/uqudqnsC+MfjI8qBNaL?=
 =?us-ascii?Q?T2Q8DN1N8YHExRZULTcy1/x9qRHdMSmqqQfNtpkMfxGtkGVDaYo0My9NK/3Z?=
 =?us-ascii?Q?oxP3T8Y4fGBzYUroAcFL/rpkj1wwQk3Btjkh2CJ52PXrQ2vCH93avuqW2AL6?=
 =?us-ascii?Q?8DT7CYmN51ivSf/gE7nnu3YsVGBWqUaxoe1G+9Z8RVXG3tWz+BsdZ+ye93PU?=
 =?us-ascii?Q?eaFbylhsAN/1ro4PSvYyCXvCOOn6f7tmCKO8m4H1IqXJqSWDSbSC9KsVItZp?=
 =?us-ascii?Q?29TckytFyZ1R8uGITC9PT+ME6J9n6RVta6VMDPn6bUOe/RC/hg8cgLZfxXi/?=
 =?us-ascii?Q?TQxmVVTi+5ufgo9rFfjWBulYMQ7J649LImBLFKqBnw+v7s6JQEG1UOulP743?=
 =?us-ascii?Q?zl52/JUxrqGwzUIH8jRT9clDrXfz7HzNbwCJFJHyY92nwkFYCzUviZmpRJIz?=
 =?us-ascii?Q?vOvg/BzBaT3NiR+doZau6NMYJNhdoceMcAuD5JyY6ab8tq+fvj4nAOUEO8Ps?=
 =?us-ascii?Q?blyQX8oS0aj2kfUHUjNQfgDnjIZ/dvHey9I/fz0f9uNIxvVdmllQ7fqnbWUU?=
 =?us-ascii?Q?ZT5WZ/3t1FzcBmrQHlIGthkui7Ey395Y7guQ2KwP0JLrAgCcirDxzyERq3m5?=
 =?us-ascii?Q?Bkn/90MhR0ysuuEaUAjNY0gMVIIN01qOfak8p1R4K4hcqd3dkDXZMoB5Mp+m?=
 =?us-ascii?Q?oeQvgC1cpcZlbFImyubjlRhtWC6NL4FmSPXWxpS1P+rxvghH1CfpQIEHBEj9?=
 =?us-ascii?Q?vp1vxMVPNW8jYzu192pDNffIyxqa+PF3GvTbfEIU5b9uImIXJqMLhx8wsYpN?=
 =?us-ascii?Q?4GxlcSCr1TD6uI4Pvs+P4Yurcday5lnDrMQfUj/9R/uoJEGhIVi5smSTNuuQ?=
 =?us-ascii?Q?HCClqnMNl+laf/jt7omqsbqYQL9oov9atSakSP/+T0/ztBVpv9ZppV3r3r2/?=
 =?us-ascii?Q?NYKG0WYDNYpN21HXM/ewryXu3QdG16ASRBJqzXbBkuc3DJJAQiLuEfVA9hTv?=
 =?us-ascii?Q?P14NfedhE99IjJQp+rGeR5+0ecSorKFEdEY4CQhLU8cEhXMwfw388CeS7aeY?=
 =?us-ascii?Q?4BPBkbnzcSuASgTvXRo6ex5ANxJ6jAx4Cw2qrFOpFAvMlgvz6D6KCaA33Vtz?=
 =?us-ascii?Q?x+aVFNhk3jScQ5PWL6E9/Z5DSpwdDVSRiPsujuFK0esmUY2CbJlgiCXVg45X?=
 =?us-ascii?Q?RmVQ2KtxT1p5jsEt6mht1Twfs1FaAA3ceittW2qTRAt1ZoDjnukhOfJuEvZm?=
 =?us-ascii?Q?qg=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e54b0bc9-92ac-452d-b804-08db7bdfbde6
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2023 16:08:30.0003
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4O4YqjCnci9dPd21VA0IOg8QupqpFmX75r68325T7tVzAsIwGFavF2eX3vKhqO8goCz7E8is5qXIS1AlOF/wmA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS5PR04MB9999
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jul 03, 2023 at 11:00:14AM +0300, Ido Schimmel wrote:
> On Fri, Jun 30, 2023 at 07:41:18PM +0300, Vladimir Oltean wrote:
> > diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c
> > index 3f04b40f6056..2450690f98cf 100644
> > --- a/net/bridge/br_if.c
> > +++ b/net/bridge/br_if.c
> > @@ -166,8 +166,9 @@ void br_manage_promisc(struct net_bridge *br)
> >  			 * This lets us disable promiscuous mode and write
> >  			 * this config to hw.
> >  			 */
> > -			if (br->auto_cnt == 0 ||
> > -			    (br->auto_cnt == 1 && br_auto_port(p)))
> > +			if ((p->dev->priv_flags & IFF_UNICAST_FLT) &&
> > +			    (br->auto_cnt == 0 ||
> > +			     (br->auto_cnt == 1 && br_auto_port(p))))
> >  				br_port_clear_promisc(p);
> >  			else
> >  				br_port_set_promisc(p);
> 
> IIUC, you are basically saying "If the port does not support unicast
> filtering, then set it to promiscuous mode right away instead of waiting
> for the addition of the first FDB entry to trigger it."

Correct.

> If so, LGTM.
> 
> Reviewed-by: Ido Schimmel <idosch@nvidia.com>
> 
> Tested using [1].
> 
> Before:
> 
> # ~/tmp/promisc_repo.sh 
> 0
> 
> After:
> 
> # ~/tmp/promisc_repo.sh 
> 1
> 
> [1]
> #!/bin/bash
> 
> ip link add name swp1 type dummy
> ip link add name br1 type bridge vlan_filtering 1
> ip link set dev swp1 master br1
> ip -d -j -p link show dev swp1 | jq '.[]["promiscuity"]'

Thanks for testing.