Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6ab3242b-32b1-11a6-2399-f3b566393a58@intel.com>
Date:   Mon, 3 Jul 2023 17:53:47 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [net PATCH] octeontx2-af: Install TC filter rules in hardware
 based on priority
Content-Language: en-US
To:     Suman Ghosh <sumang@marvell.com>
References: <20230703120536.2148918-1-sumang@marvell.com>
CC:     <sgoutham@marvell.com>, <gakula@marvell.com>,
        <sbhatta@marvell.com>, <hkelam@marvell.com>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <20230703120536.2148918-1-sumang@marvell.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bVZiUGdvS3JDM0VDU0E3SEoyVWhxMzluT2pneERXMzhvUUY5MDRDcGpVRTRa?=
 =?utf-8?B?MHBBcG56ZHI4WkZPYkpUQzNxa215YlQvVVBXaHVyT291QVFESndFQlAyOEIy?=
 =?utf-8?B?UmZHdmdUVFhGQk1CL2ZRU25jLzFrcnBGbmNsQm8rYWFJVklCZmpYU3lMRmhK?=
 =?utf-8?B?d3o0NncyZkV4dm9qUFdjWitWSEVibkNrZCs1eTFCc1poT29nUVBsUFE0bldM?=
 =?utf-8?B?Tk9hcXFUVkRDZnhHVHNKZ1Blc21KS1FNRDdZeDZvRDd5VjJlZmt1bTJGdzhx?=
 =?utf-8?B?RXA5dmozOFowZ3FENDh4cm5FVFNjQU54c3Y4ZWk4K0ptbUhNa0hSaTFodUVV?=
 =?utf-8?B?bDlzUURya0ZzZnJWSkROekZFRVg3ZGN1OWJqRDBiU1ZXZkN6Q3JQRjhrbjNl?=
 =?utf-8?B?M3huNldoRnJlWS9jaGxwSWJ1SEcrTVZJSkx3Kys3VjN6T1VSc1l1emF1S3NO?=
 =?utf-8?B?R2g3TlF2LzdlQ0ZJOU9EbDF3RXREV0FudFdBRGJKbmpBeGFFcC9KTVZIU09a?=
 =?utf-8?B?ZHNBbWlTamg4L0lxWGhuTXFZVHV0NGZxQ28rWDdPN0hJaGE1cjA1ZUw3RWU2?=
 =?utf-8?B?M0F0aUx1MzRHcFJLb0dPTyt6aXJGcmtvYXdsUjc2cmZiK282TlJaNVp6UnFk?=
 =?utf-8?B?UGlrRURCSS9pczI3VXdzQXZvaGgvakpWS1pnS29TZE9GRTdtNmVYbUJWa3hM?=
 =?utf-8?B?a2plMERZeXI0L21aeDdtaUhvT0plaStkWmFFanlwQ1h1cHhhbDVPUHdjRS9G?=
 =?utf-8?B?dm1mSkg1QW40Mm1KQ2RBRkI2UGNNVEM1TnFreHJpUmpOYzAzQ3FYMFMrTDVt?=
 =?utf-8?B?REJTdDAzdU9vQTlBZ3pmTGI4SnNtelNkRGhjWWh4NURFTWhHSVFIanhCeXQ3?=
 =?utf-8?B?Z2lsT3FNWUc5UlB0cDIrMytKT3A4b3BqTlI5cCttUGI0dnJJU2dadzBjRlUw?=
 =?utf-8?B?RUhLT1h5c2pNWldqTURSRE5qamtmVXBWa2FLRzVmcldFUWJZWEQ3cUtrdno3?=
 =?utf-8?B?V2g4S3ZFcFFSNUVkckhyQlNNWHZEd3VDWTRiSTFrWG9ucWJreWhVMGRGZVRJ?=
 =?utf-8?B?blcxMHpHbXBTZ3ZRRm51ciszVDMrYkFFNHU1SUdBS2hVcnE1RlcxY0Z6MC9R?=
 =?utf-8?B?MFIrQjJiNVZOLzVONXEvT1l0cnh4TGNxalpINHBUVkdiOENGZ2JxWUlHczVy?=
 =?utf-8?B?NTRQSG5vdjNsY1NzaVZoaGh0Ri8ySTZIRVlOVkhWcEhpa0NOZEdrTGdNSllk?=
 =?utf-8?B?cENZV0V4b0J5elFhVkxWWW1uZnhtSTNLZngwYUNaVUV2Y25IQ3NZM1E3d3kw?=
 =?utf-8?B?ejNVQmtWYzMzSVdWWG0wTVpmRzVyYW43azlTMnJEQkd4My9XYUJENmFzWUda?=
 =?utf-8?B?bVJwUXA0UFpHQ1dtdElYOWNjQjR2UFhBRmR2L0NlOEYza3lZYlJzYnJTczVV?=
 =?utf-8?B?dGZlTCt6ZjBFMFMzS205RVAwNGpoNlRwZ3B6QWJmU1NRanpsMDcrd1h4K0RN?=
 =?utf-8?B?SWJaeTZVb1ZyemhQYnVIeFczblZRVWdNalg2N2dHWGxnNTkyMHI5SFZHQVU1?=
 =?utf-8?B?WUlOTTNzdmxDV3dSOWMxSjg5L1lrVGRiWmljTWJjWlBkT0dycmQyVjcyQzAz?=
 =?utf-8?B?RFFhcEtqOXNMMkFpY1RNMm5PdDVDRTJNYS9Hdm1PRXhFRHlZOUh1Q0F2V2Zo?=
 =?utf-8?B?dllDRUFBVlF6d1d4V0lYTWdOV3paOVdjcFJiME9uQ0JxdFJ3eG5mTlZ0UW44?=
 =?utf-8?B?TUZGOENkbG50MHpJaUwxblQzQ3BFVEZqRDh6MG1tSWR4R0EzeTlOZ0QwQ3Ux?=
 =?utf-8?B?MTBkemd0VlJ4ZnRYZzN4N3FpaWVySzFXSklqeU12bTlRQkRxaWpqREdyK2Za?=
 =?utf-8?B?WkFzNG9FaEsrVGM4VHJUQkoxOXhYUEpOYzBOVUdoNStXMStnQjJ4clF0TVZk?=
 =?utf-8?B?dGp2QVhmNloyUGhjdEIyUFE4cnEvcnMvRXl3VHIvRGpHdkgyYnlwU1lheWtp?=
 =?utf-8?B?VUIzb2ZvMEo0ZE1TM0gweFlNQkFIMUhsdHc0U0NoNGtJSGdHd2NlTW1sMFI3?=
 =?utf-8?B?c1haQXZpb09lQ3FBR254bTZnMHFCQUE3UVkrTzFkejFPcFR0UmlHMDltVGhK?=
 =?utf-8?B?M1pEVzhzUHhvYVR4SXdwT2dBZnl4NDdaaXZxUWZwcjBrWE55bHFkWFpLUlZF?=
 =?utf-8?B?eUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2fc5391d-0006-4a23-b79d-08db7bddd590
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2023 15:54:50.6388
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KdR0+yn/OZlKJqrqcS1IuoPfjaKcqOmMCdfWxVH+Hnstd68FjXX3BUVQLQz6DvKGgAkLQXJ0mVdLEtSqYyb8xJXBT2dNqBOVDod5oAO027Q=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7108
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Suman Ghosh <sumang@marvell.com>
Date: Mon, 3 Jul 2023 17:35:36 +0530

> As of today, hardware does not support installing tc filter
> rules based on priority. This patch fixes the issue and install
> the hardware rules based on priority. The final hardware rules
> will not be dependent on rule installation order, it will be strictly
> priority based, same as software.
> 
> Signed-off-by: Suman Ghosh <sumang@marvell.com>
1. Targeted net (fixes), but no "Fixes:" tag.
2. 350 locs of changes in a single commit. Is it so atomic, so that
   even can't be split logically?
   Esp. given that it's claimed as a fix, not a feature. Single 350-locs
   fixes do happen, but *very* rarely.

Thanks,
Olek