Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <23a2d0a8-3a68-f649-51a2-3ebf401b59c4@intel.com>
Date:   Mon, 3 Jul 2023 17:48:23 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [net PATCH V2] octeontx2-af: Fix issues with NPC field hash
 extract
Content-Language: en-US
To:     Suman Ghosh <sumang@marvell.com>
References: <20230703122040.2151210-1-sumang@marvell.com>
CC:     <sgoutham@marvell.com>, <gakula@marvell.com>,
        <sbhatta@marvell.com>, <hkelam@marvell.com>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <20230703122040.2151210-1-sumang@marvell.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cU5lN2VJazM3WHNYREhtZThSaEhNeVpuaExNNzJGSVlHRFRjSTRzSnVSVzVP?=
 =?utf-8?B?Q2NmaUNOWFVFNUtQcGM1Tzkra1lGelVHdkFlOHJsZXNsZWRVcmVOTnAxOEg0?=
 =?utf-8?B?NjRPa2ZjdkJ3bHR2K0FVbk5ncU1KTUoxdSs2RWgzTU52emxlZS8rZ0lZUlBo?=
 =?utf-8?B?QjB2Sko2UTFFSXBRdEs0UzdQNlJJNjUvUG9KcnRvWlphSW9hWGRheUpldWNK?=
 =?utf-8?B?UjVjMjZzU3ZPazl5aTNUMmdTVVptSDBSZWpWb2xrOUVRYk8vUnA2MzZlVTZ2?=
 =?utf-8?B?bG40N3BOQUljNFZIVnpyZVpXdVFsT1ZCR3hZd3lLM0JzYVJkbEtIZjVSaHVs?=
 =?utf-8?B?b3ZGLzZYbnVyNHovNEU0ZFJnKzQ2SDVXakI1c284VEZNTjZ4MVN1UWVZRVZ2?=
 =?utf-8?B?VFpIVy9qMmpnanEvVm9tQkhLc1F4Q1Bjcm9Lb00zTkMzSGk5amF1RUJ1cDJq?=
 =?utf-8?B?QUdVS0IwZ2xDSFlyQTFnTWVXVVFWZ2NRUituUVRLV0lZdEhvdkRxenVidUZQ?=
 =?utf-8?B?VlcvZVN3QmpJV2t5VEFrU1Zyd1drM3d1Y204aHh4U3gyUFR3SjhqVnd4cHRC?=
 =?utf-8?B?VmtUcmptWFVpMWV6QmU2SmcvWlQ4VnhUT0F1T3ErTHBkT1BkamFNbXlPT1Zm?=
 =?utf-8?B?ZWo2NE9mRnNWL1B0bGVjcVNtWkxabmdXbDMvSFZXZmk1TklVQTYyVVlzTlgy?=
 =?utf-8?B?bWRMQWNPWDdFeWpDdXZUZVpzb2pTcTRKSFJyQm9PTHZOT0FIM3F2a3V4R3JV?=
 =?utf-8?B?QWdOMWFOUFJnK3RVVDdHelZMSEtmaVR3bFIreVVEdzlFVEtkdmZNUUVVN2Vw?=
 =?utf-8?B?UXVNc0dncUhkdXBBSjVpRmxaYTlhOVhzdE1qNytTdWxFdFhyMnNHMzNYWCs4?=
 =?utf-8?B?OVBVSDV4bXA5T1Z1QWVUcmt4Rm5VdlNZVGFrY29mNGIzMUh0TXc1Sm4zOWtY?=
 =?utf-8?B?Y3FnU1UzL1JkM0JrcmcyelViSXJnc1hUZy9XYW5WaUJLSW5aOWNQYjlSdzh4?=
 =?utf-8?B?d2xJcFRLZTJud3RHWHV6ZUxqa1krMmo3VTdOZ2REejVpcytZT2dOb1A3NkIw?=
 =?utf-8?B?dGFyOHFYdGRWS3ZLM1d1OHVST0VwSmtHZFg4cTNWUVZnVy9NQ2FwNkYrb1po?=
 =?utf-8?B?aUh2UDV5MTcxZ1p3MGhpSXFBUndUVkh3aFNMUTgxV21FZWVkcyt0QzN2aEhD?=
 =?utf-8?B?TnBhMGVaNE1yM1hvRmRkZ3JncThuZnpUSmpQbjhXOWpCS0hsQmt5NURpL3FN?=
 =?utf-8?B?ZllUa002eERBalNBU1F2dVRmT3VtQXEzR1hLSllpdzRCaVpsZXUxWEYxV3dC?=
 =?utf-8?B?d0ozTjNNTnZpSW1seDYrQ01zcWFvaWQyODE3T3ptc3k5ZGw3ci9Bb05hTlFE?=
 =?utf-8?B?OU5rSTV6TEFWeEM5UnNZRGsyRCt4UmpNYWllVUJQb1J5ZzRlcjVoaDVneFJU?=
 =?utf-8?B?cHhTWU9UZDFlRDJKbE5WRnA1aXkxMnBOZGgwVjdaaW1xZy8vbjNTUVo2OWxG?=
 =?utf-8?B?ZHhoSU0vL0IzUExLUzVNMUZLdGZXRmFXbGJqZDlNdGFTOWJ0elJLekNGVlp0?=
 =?utf-8?B?VW9kNkRCUkY5Mk9ya0ZpbmFqQUF5OXl4MjJCaW5URUIxZ2VkTXlqOFhrendK?=
 =?utf-8?B?aVhNRWRBaDFDdWdqT0h3aVhRRjFaa1R5RFRCUE10MmJpaUJDdk9XcGpZdHJi?=
 =?utf-8?B?VWtuWXRISGhDL08yM3l6dXc5cDQ3b3EzNWdSNnB5Q2VGejZETDRDS1ZxRENw?=
 =?utf-8?B?MUMydVQ3NmgxQmtaM3ZBdi9helMwTGJFN1BiM1h5TnJwVEkvQzNialdwNXM1?=
 =?utf-8?B?QmJYTDZmN1Fpd2xnZGVOS2NCakVaSm1YZTNNWStMa0RJZXZYTVdGbXI4MW8w?=
 =?utf-8?B?STY1bUY3eWRjQzVCRlJxMk5YY0N1Qm5kSWtjR05xYnUvdG1GM3dXKytucFFp?=
 =?utf-8?B?WG41VHhEd2VhbXBsSlhPallwMWYyZjNKTG1xRXBzcVMxTkFURXNZYVEzdmR0?=
 =?utf-8?B?dm9KcHZmQ2JiM2NmbktnNDYrNGNOeDhtRFg5Qi8xTWNRSEZXdmlISVVqYU1R?=
 =?utf-8?B?THlrVDBDOWw2MjFqUWlSQ0FsTnlWblVzbHgyaE5vMHpMbXRWTUdmTjVqcXdW?=
 =?utf-8?B?MUZnNVZxYURXRkg4UTU4SUdOWnZDeHEwZkJKbFNPdjJoRWoxOTdoN2ZsMXRR?=
 =?utf-8?B?V3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6ba8594e-708a-4b29-1758-08db7bdd13e9
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2023 15:49:25.9528
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pwzlGzAQq6lHvA6Vv+G5KUNy2PkWcjrEaxGpfUP/seiOnzxiUEQvZInmy1sF4IIquAIrkSGp1Jg+NEXxNS1vNO3n/iGARB47dUwa6w7ilFI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6244
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Suman Ghosh <sumang@marvell.com>
Date: Mon, 3 Jul 2023 17:50:40 +0530

> 1. Allow field hash configuration for both source and destination IPv6.
> 2. Configure hardware parser based on hash extract feature enable flag
>    for IPv6.
> 3. Fix IPv6 endianness issue while updating the source/destination IP
>    address via ntuple rule.
> 4. Update hash extraction mbox message.
> 5. Enable hash extraction based on the MKEX profile

That's a lot. Can't this patch be split? For example, one commit per
list item? I don't think it's atomic.

> 
> Fixes: 56d9f5fd2246 ("octeontx2-af: Use hashed field in MCAM key")
> Signed-off-by: Suman Ghosh <sumang@marvell.com>
[...]

Thanks,
Olek