Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <31c1393d-4285-0032-7675-737737d21f71@oracle.com>
Date:   Mon, 3 Jul 2023 11:53:35 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v25 01/10] drivers/base: refactor cpu.c to use
 .is_visible()
Content-Language: en-US
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, david@redhat.com, osalvador@suse.de,
        corbet@lwn.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, x86@kernel.org, bhe@redhat.com,
        ebiederm@xmission.com, kexec@lists.infradead.org, hpa@zytor.com,
        rafael@kernel.org, vgoyal@redhat.com, dyoung@redhat.com,
        lf32.dev@gmail.com, akpm@linux-foundation.org,
        naveen.n.rao@linux.vnet.ibm.com, zohar@linux.ibm.com,
        bhelgaas@google.com, vbabka@suse.cz, tiwai@suse.de,
        seanjc@google.com, linux@weissschuh.net, vschneid@redhat.com,
        linux-mm@kvack.org, linux-doc@vger.kernel.org,
        sourabhjain@linux.ibm.com, konrad.wilk@oracle.com,
        boris.ostrovsky@oracle.com
References: <20230629192119.6613-1-eric.devolder@oracle.com>
 <20230629192119.6613-2-eric.devolder@oracle.com>
 <2023070342-human-spill-a62c@gregkh>
From:   Eric DeVolder <eric.devolder@oracle.com>
In-Reply-To: <2023070342-human-spill-a62c@gregkh>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MjFDRVRXeDZEUnZzNFM4NDJMSlFkU3pwRWJSMlJQU0htTVQrcmFQcVpOWmhq?=
 =?utf-8?B?cHJLbVlWdjNkd3JGbHJEelNSUklSZWFDRkNFMjZYWVExOEZlcmVhYXowS2pu?=
 =?utf-8?B?a3pBK0N3QVFKZFBLK1NoTFoyNWtPSmppdW9xQlB5bFhmajg1T0hWdXo4V2xj?=
 =?utf-8?B?VS8wVk1JS0xHWW9FdTE3eXhDbGdPQVBUdlhuYk9TOHZCUStjRmVzajlDV0ha?=
 =?utf-8?B?Wnh4Y1gwNElpam02ejBDOHQzVnovVmt2b0lRM213Qy8rZFU5MUpKSUxjUmp1?=
 =?utf-8?B?VHhnMkMwYlZrWXhqVlEyZ2hJSTBra3pvY1hyRTNtYXpjMmFuN1dnTGtjMDY3?=
 =?utf-8?B?N1NtM2pzSTRCa2t4eVkxV252VUZCRnhPaVkyUEp2TGxjelJuKzY5eTBpTGdH?=
 =?utf-8?B?cmVmdlorTkljSWUrM2R5SmVOenVza0ZGZ21pdkZ3NFFBV0w1SVN5RVhDS1Bv?=
 =?utf-8?B?c0Z1d3RVWVRiZTNPUGMwREx5VXFzR3gwbVFXeUhpZTk1dDkvejYzczhCakV4?=
 =?utf-8?B?ejRlWU91MSt6M25sUGxWc2IxNEpNWUVRWGVVTnRDc3JiQmNuYk0rNkdiRm9l?=
 =?utf-8?B?cHJpQTlqN2x2dkQ2TDZLNVB6bzVxSjRoeXNHUWo0WUNVN0VkdlpNNVh3RzlP?=
 =?utf-8?B?OHozMlpEZEdDbzJJY1R4YnhEQ0JZWEM0NjJnK1JlN0J1N0J3bHdyRjdhdHJ6?=
 =?utf-8?B?OVZmZ1duanQrdDNFd3VwRzFORGNpQm1LY2dKbWhBQ3doZnhVK3RmK3dQVTh5?=
 =?utf-8?B?QUx4cW5VaFN1Vlhla0RxbmRTaUo5ejVTbkc3eXIzd1FKd3N4bmQ3TVRDZVZC?=
 =?utf-8?B?dGplQkUvK1hkVDM4bkthYXFYaTJaMU9QMlArOWxlNnBRTUpaanpVVytJNzN4?=
 =?utf-8?B?QlJBY0tYUDgzc3BFakJMa01YOUg0OGFGRHRMbCtESGxmcDlLb3VZNmpyeEU5?=
 =?utf-8?B?MnhleTlDYXpzZkdLS0p4NjE2NEp5THlocGw5ZEtjV1dhOVk2U3dCZ0hMYjRR?=
 =?utf-8?B?ekx0STI3Q1VCNzVUcUJUNFIzaVQ3VG1taDJIQXExdXNjVVJ0NEptMHRJNFlp?=
 =?utf-8?B?ZkNzZ0xHSXNxT2NZYjI2ankrbjFCakg2S09xa3VRT0VzTHdCNTZBVWVHYmkr?=
 =?utf-8?B?WENkMjRrU1c4ZGpieWtXbmI1TUozT0hNMVoyY3pyVDJQUWZtZUFHU1J0Unp3?=
 =?utf-8?B?TElWQkVtaUp6czNRSWZhMUNKbURub3NNa0tveVU5RDY1WVVmQlhDY1h2c0pG?=
 =?utf-8?B?RVhpMVRzYVQwNm9sMEFDU2YrRnZVTXNYUVhscVM5S1d1L1FJMitiU3RKbk1Y?=
 =?utf-8?B?U0VTcm5aRndiZDgxdFlSMDhESkl3WjNNVlFNRngrSmdxVXRqdUtCVzNsb3V0?=
 =?utf-8?B?MldUS3ZPcmxaTTlOOEJydWNzZHowSjZLSUFTaDFmci9ONXplcmhsK2FxM3Jy?=
 =?utf-8?B?MDE2ZWloQWpFWk16b3FoRDhzQ3c1bUV3TndIdmtHZVgvQkVsS2lVTTI4SHBa?=
 =?utf-8?B?aTVLRHROcm5NYm9pcnhVREFWQ2p6Q1dVTXg4TUt6QmlVcGpYZ09wRXlDOFh2?=
 =?utf-8?B?M2NHNG9pZ3NEVFZkSWR2em1YaXZFbGZZMllHTDBFVGJDd0QxMThCSVF5NTVz?=
 =?utf-8?B?Q1Rpa2RwUkxUT2pUdTVPUlh1anJBZm55bFJKbGlMVkNGWitUSXpCOWQyb0ZV?=
 =?utf-8?B?elVhcHRhQUIxa2ZBUkZEY1JJcTBhNjRwOHZpV0hHLytGdk9Jc2FzeHZBUWFr?=
 =?utf-8?B?L2hPNE9INFR3ZFpCYWJ1ck9Bbmc0VVNPTm55NEhHalFvdWVXalZXdWkveS82?=
 =?utf-8?B?ZGJYK2xJdmwzVHlwU2hyRDBLaHBjUDRTWGRIYlF4dFN1TkhIVnFDQjBnVEU0?=
 =?utf-8?B?cWNZWE1UeEpFYUQ5NytnY2tQVWNLSVdtcCtjMGlLSG13cm5qVEh5blVBZVQ5?=
 =?utf-8?B?dGRPTjBDa3FEMW4yTlZLSHdCN281QllrdnY2QmJJMTduRXc5SU5WaWNORTBP?=
 =?utf-8?B?Y0dIR000dXBFTERrcVBzcE5YUEsrNTJBY1ZxV1F5T3Bqd2R2RkpWQVBCRElD?=
 =?utf-8?B?VTJhMzZ0Y21nYkNNT1V4TWNhYjlpWkFEYTdUVGpFRFcxa1E2b2FRQklGWWdX?=
 =?utf-8?B?RWR4UG1XM2xndkVxbThCT0trdjZLNkxZbFBJd3ZjTEhtSnZMajkvaU9nT0lU?=
 =?utf-8?B?SHc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?bUtZYk1ORU02WmU5RGk5ZkpuQllIc2w3Y2x6S200MFoxRnZ0T3NXZlFJYW1Z?=
 =?utf-8?B?M21mUkV2K2pYQ3RHZkFROFhmQi9SbVdmbTVnSVhtdmc1ejBUNTFFNGhmdUJl?=
 =?utf-8?B?QVhNZVlSa2UySkJyNXltZ0NhSTNCNFd5UXRBSTdySGZISTkyeUdNUUI4YUhL?=
 =?utf-8?B?eWF1d2ZzNFBKUnJBN1didHM1enpIQVFLY2YyQitxZ3pxb2xsdEVMTnNxVWNO?=
 =?utf-8?B?eGEvNHhtNE5tYytTN0FFeXZCZ1BsMHhvN3JvdkdhR00yczdscHRyYkp2QUQr?=
 =?utf-8?B?ajllekxrV2FCczcza3FCaDFOamprMFR1RnQyd0x2elM5QnZaS3JwaHdRQ1p0?=
 =?utf-8?B?bWN5b0Qvd29hQmVzeHFZQzNEMzlmZEF3cmN0ejFqSWgxalNQcncwU2tLdGJv?=
 =?utf-8?B?Z0RtRk5RVXdWdWVvZHRaKzhnUExWbk1VQTkrWEN4TE9hZmVCM1dHNUptUmNv?=
 =?utf-8?B?MTUzNlV1SU03dWJTUnhyeis3ZVRieVMySTdJSnRscTVhVzVpSGdIMFRrS215?=
 =?utf-8?B?Q2tVNlY5d3dQVlptTUdTUlhMUWswb1MxVTFycUFLSUpBNWMwVGdTMkRrS0M0?=
 =?utf-8?B?TUxhdU5lTXpVMGhkTjZDQW1DbDJRbVlhYk1GVmlDeTQzZitXaXI4czRUaGsx?=
 =?utf-8?B?WFE1RGtsMjZ2eVd5Sk5pdlFsMytMdjJsSEd2N2pyL29Wc0FhTzNZSEdBU2lx?=
 =?utf-8?B?blY5clNwZ0J6em9WNEt3c0hiWTA2OUpZeWtUVURMT3JIaGhKTGIrT3kxZjlU?=
 =?utf-8?B?RFM4VVZXQis1RzNSZ1FRWW5zYW0xT2o3TC9hYzc5T0xsTzdRVEttZVhZdHhQ?=
 =?utf-8?B?REVNTHh3TE9vSmxIYW8rck45cHpITzZHclM0N2ExakxoNXFHNUIwZmxhd29j?=
 =?utf-8?B?aStwRERuZzRPSUxGVXlNb0JtS01mNHVjV21EWENRZWJaUUM1Vm8xa2RhcVJq?=
 =?utf-8?B?M3Z2eE5qdzlzcDExdnh0VmEzZ3JVREw0UDBGWjdIZVViSHpqMmhjdWZVSGNS?=
 =?utf-8?B?SEhNNmsrREt2aGNRLzRzWjBNR0hnNnJ0OEFLUkZyV3pEd3Fqc1Bib0w4UXFX?=
 =?utf-8?B?RnZJYXNBazNOZ3VkNVVtSEdzSHVvd3BieU5KM3NjNHBUMlNYSWxvY3NUTC81?=
 =?utf-8?B?SXhXK1UrSUJqL3RsK2JrZmxHblNIZ3NOQmdJUEVlK0FvWWxhVTJMcDhqY0po?=
 =?utf-8?B?VmtWRER5N3hSNG9UL3A2QjFnQnpIRGoyL0xBSGNqeG1vUnFacERPRmg5UFow?=
 =?utf-8?B?YTN2NWdEeGxaU3dUQkdvYkUxbFJwMWFlU21wYXdqRDJEZ2QrbEhjclhsendH?=
 =?utf-8?B?TjVINnAxeHNudnhUeDcrWlk2RjRMQ0lka21xcmlrRklsS21PT040MmdXUisv?=
 =?utf-8?B?eWRKdWNaMVBwc3FsT2lKdVR4VlpKRlE0aWlTeFh5VU0yQTU4VGtZWkVxOFRq?=
 =?utf-8?B?bzkxQ3N2UUlZa2VXR0ZIbFcwWng1SSsrNDV1WDJrb3hFV1NBYVFBTUp2Z2dN?=
 =?utf-8?B?ZEFHbnFmakhwQWJsYWYwdVhQbkJDOC9SVnFxNzJrY1ltK3Z5R1dDaG5ZYmtR?=
 =?utf-8?B?Y29FM1NRUzFXMmVGSVdiT2Vub0piMHFDQzI2MGtsZjFGRW96OWU5Z1hWK0Ex?=
 =?utf-8?B?aDNuU2N1d3A4OWFRR2pJdEI3bVNSSU04cGRvNmJqWkJYV2pkaWhyc3U0SUJH?=
 =?utf-8?B?RVZtMk5GOGFOa2lkcHpXMFlDRmFwcnJyUnRsdmlIMGgxckdtVWJ3TzRXVkNT?=
 =?utf-8?B?RTNFOGNTckdQVW1BMnFmMG91R0djdDFQNHRBaUFVS01ablV3Z2ZjT1FJbEVP?=
 =?utf-8?B?WWYzTVVtRll0amowczNjV0hYaStkV3JkaFBTKy90cjhEa0ZOdFNRVU5LQkhr?=
 =?utf-8?B?N0RSSm8wYjRKcVBhLzRuS2oraHg2bnorbTlvbTk0b0l4c1E1UncyY01xS3dj?=
 =?utf-8?Q?5I4SAo/SQ3E=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e9105495-9841-4f6e-fef4-08db7be60db0
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4531.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2023 16:53:40.6990
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: G6oz1jzTMpc1OZYZnyUixviVJ0fFXHJ9AMDutckcKF5RIhXub7ktkHyeBtraGjlImH6T2FqUHci12q/uDZVlwoR3usbeTgsloodlA7heCFk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR10MB5665
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-03_13,2023-06-30_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 bulkscore=0
 malwarescore=0 mlxlogscore=999 adultscore=0 spamscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000
 definitions=main-2307030154
X-Proofpoint-GUID: _axVlsKL046aGBHOjgumfepV5WeBWCbP
X-Proofpoint-ORIG-GUID: _axVlsKL046aGBHOjgumfepV5WeBWCbP
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/3/23 08:05, Greg KH wrote:
> On Thu, Jun 29, 2023 at 03:21:10PM -0400, Eric DeVolder wrote:
>>   - the function body of the callback functions are now wrapped with
>>     IS_ENABLED(); as the callback function must exist now that the
>>     attribute is always compiled-in (though not necessarily visible).
> 
> Why do you need to do this last thing?  Is it a code savings goal?  Or
> something else?  The file will not be present in the system if the
> option is not enabled, so it should be safe to not do this unless you
> feel it's necessary for some reason?

To accommodate the request, all DEVICE_ATTR() must be unconditionally present in this file. The 
DEVICE_ATTR() requires the .show() callback. As the callback is referenced from a data structure, 
the callback has to be present for link. All the callbacks for these attributes are in this file.

I have two basic choices for gutting the function body if the config feature is not enabled. I can 
either use #ifdef or IS_ENABLED(). Thomas has made it clear I need to use IS_ENABLED(). I can 
certainly use #ifdef (which is what I did in v24).

> 
> Not doing this would make the diff easier to read :)

I agree this is messy. I'm not really sure what this request/effort achieves as these attributes are 
not strongly related (unlike cacheinfo) and the way the file was before results in less code.

At any rate, please indicate if you'd rather I use #ifdef.
Thanks for your time!
eric

> 
> thanks,
> 
> greg k-h