Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230703123243.7795-1-duminjie@vivo.com> <CAMo8Bf+rgAnzMF732rzNgWbnmijFbr1yd5aCiY1Hcf4qdpj6FQ@mail.gmail.com>
In-Reply-To: <CAMo8Bf+rgAnzMF732rzNgWbnmijFbr1yd5aCiY1Hcf4qdpj6FQ@mail.gmail.com>
From:   Max Filippov <jcmvbkbc@gmail.com>
Date:   Mon, 3 Jul 2023 10:05:39 -0700
Message-ID: <CAMo8BfKe1nR+UP1WiUWFX0E7GSEfHsF8bZapsUYu3NFTnA8_AQ@mail.gmail.com>
Subject: Re: [PATCH v1] arch: free dev before return
To:     Minjie Du <duminjie@vivo.com>
Cc:     chris@zankel.net, sfr@canb.auug.org.au,
        linux-kernel@vger.kernel.org, 11162212@vivo.com,
        opensource.kernel@vivo.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Jul 3, 2023 at 7:19=E2=80=AFAM Max Filippov <jcmvbkbc@gmail.com> wr=
ote:
> On Mon, Jul 3, 2023 at 5:33=E2=80=AFAM Minjie Du <duminjie@vivo.com> wrot=
e:
> >
> > We fixed a bug where the variable dev
> > was not freed before return.
> >
> > Signed-off-by: Minjie Du <duminjie@vivo.com>
> > ---
> >  arch/xtensa/platforms/iss/network.c | 1 +
> >  1 file changed, 1 insertion(+)
>
> Applied to my xtensa tree with the following commit message:
>
>    xtensa: ISS: fix etherdev leak in error return path
>
>    iss_net_configure frees etherdev in all error return paths except one
>    where register_netdevice fails. Add missing free_netdev to that path.
>

After testing it I realized that in that error return path the etherdev is
freed by the iss_net_pdev_release callback and that this patch
introduces freeing an active timer on that path. I've dropped this patch
and committed another one that adds a comment about what's going
on at that place.

--=20
Thanks.
-- Max