Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <CAMo8Bf+rgAnzMF732rzNgWbnmijFbr1yd5aCiY1Hcf4qdpj6FQ@mail.gmail.com>
 <8ea68c1e-fffc-6443-d2a7-d540f9b5bb16@web.de>
In-Reply-To: <8ea68c1e-fffc-6443-d2a7-d540f9b5bb16@web.de>
From:   Max Filippov <jcmvbkbc@gmail.com>
Date:   Mon, 3 Jul 2023 10:11:28 -0700
Message-ID: <CAMo8Bf+ABwfqfi2hnyCdwooiogN7JMvq_tS0ZDYkytkYZ5gE9w@mail.gmail.com>
Subject: Re: [PATCH] xtensa: ISS: fix etherdev leak in error return path
To:     Markus Elfring <Markus.Elfring@web.de>
Cc:     Minjie Du <duminjie@vivo.com>, kernel-janitors@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>, opensource.kernel@vivo.com,
        11162212@vivo.com, Chris Zankel <chris@zankel.net>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        Yang Yingliang <yangyingliang@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Jul 3, 2023 at 9:02=E2=80=AFAM Markus Elfring <Markus.Elfring@web.d=
e> wrote:
>
> > > We fixed a bug where the variable dev
> > > was not freed before return.
> =E2=80=A6
> > >  arch/xtensa/platforms/iss/network.c | 1 +
> =E2=80=A6
> > Applied to my xtensa tree with the following commit message:
> >
> >    xtensa: ISS: fix etherdev leak in error return path
> >
> >    iss_net_configure frees etherdev in all error return paths except on=
e
> >    where register_netdevice fails. Add missing free_netdev to that path=
.
>
> * Did you add the tag =E2=80=9CFixes=E2=80=9D because of the completed re=
source cleanup
>   for the implementation of the function =E2=80=9Ciss_net_configure=E2=80=
=9D?
>
> * How do you think about to replace any statements by the source code
>   =E2=80=9Cgoto err_free_netdev;=E2=80=9D here?

I've scrapped that patch and committed the other one instead. See

https://lore.kernel.org/lkml/CAMo8BfKe1nR+UP1WiUWFX0E7GSEfHsF8bZapsUYu3NFTn=
A8_AQ@mail.gmail.com/
https://lore.kernel.org/lkml/20230703170335.1340104-1-jcmvbkbc@gmail.com/

--=20
Thanks.
-- Max