Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <19b2d721-06a3-bc17-eb81-18ee2d8856a3@kernel.org>
Date:   Mon, 3 Jul 2023 20:23:30 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH 1/1] i2c: at91: constify at91_twi_pdata
To:     Andi Shyti <andi.shyti@kernel.org>,
        =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>
Cc:     Codrin Ciubotariu <codrin.ciubotariu@microchip.com>,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
References: <6ac87dcbb660ae892bf8740c78d3eca7625d6db6.1687814664.git.mirq-linux@rere.qmqm.pl>
 <20230629223825.27q75s2a3eyiapgy@intel.intel>
Content-Language: en-US
From:   Krzysztof Kozlowski <krzk@kernel.org>
In-Reply-To: <20230629223825.27q75s2a3eyiapgy@intel.intel>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 30/06/2023 00:38, Andi Shyti wrote:
> Hi Michal,
> 
> [...]
> 
>> -static struct at91_twi_pdata *at91_twi_get_driver_data(
>> +static const struct at91_twi_pdata *at91_twi_get_driver_data(
>>  					struct platform_device *pdev)
>>  {
>>  	if (pdev->dev.of_node) {
>> @@ -189,9 +189,9 @@ static struct at91_twi_pdata *at91_twi_get_driver_data(
>>  		match = of_match_node(atmel_twi_dt_ids, pdev->dev.of_node);
>>  		if (!match)
>>  			return NULL;
>> -		return (struct at91_twi_pdata *)match->data;
>> +		return match->data;
>>  	}
>> -	return (struct at91_twi_pdata *) platform_get_device_id(pdev)->driver_data;
>> +	return (const void *) platform_get_device_id(pdev)->driver_data;
> 
> the const's always confuse me... do you get an error here? Is
> this cast really needed?

I think this change is not necessary and actually should not matter. See
for example drivers/tty/serial/samsung_tty.c after my refactorings in
commit 3aec40096550 ("tty: serial: samsung: reduce number of casts").

Best regards,
Krzysztof