Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 3 Jul 2023 11:32:39 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Sidhartha Kumar <sidhartha.kumar@oracle.com>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        akpm@linux-foundation.org, tsahu@linux.ibm.com,
        muchun.song@linux.dev
Subject: Re: [PATCH v2] mm/hugetlb: remove hugetlb_set_page_subpool()
Message-ID: <20230703183239.GA4378@monkey>
References: <20230623054948.280627-1-sidhartha.kumar@oracle.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230623054948.280627-1-sidhartha.kumar@oracle.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TVxhr9SKvQBrZQA+3VHct8POhTIul6fyoBypIPGyB5c+HEPlTvKeu+TTNufk?=
 =?us-ascii?Q?5WQsTpQSOZuia+WqbpLjJ2CjLopSqfh7AE0v2Jq1YER0dihBWUq0AMvU3bS6?=
 =?us-ascii?Q?gvcELWu9eEcWpI38XZH5QF8hjaCTFi1XQ84GGf8LucMqGMmdAikFjkGxJ8db?=
 =?us-ascii?Q?fHpW6PTJDrFvmFQZwqBobjlcFL6xRZAtJC8QCOLHciecwg1r65apKpZHUVDq?=
 =?us-ascii?Q?joz43C3GwQb4kKLquLe+X/EAX7VQc+2ynOep7P8ypfApZYLj2BCv3bqGjy0G?=
 =?us-ascii?Q?HFjUTzV3L3vsbV5CjZiiSXdUGgcdS3BpXPYV6ZlV/haEHw5aPxzIo6mPssVf?=
 =?us-ascii?Q?SEMebcvtSjJUhdfLkazls8iPF3TMNDRAonN1Cry3nv17kA6Dwqc/06SLHcR4?=
 =?us-ascii?Q?RXzRXu0KXLqdZo+sklmfqen8vWwW8C7ei4mD30p7rHhgvQCdDPg4D/yS4oOl?=
 =?us-ascii?Q?Z+QRSm6sYqc2Yon8kIobnhzzoVwTPOQpVQkVUwG5THxFX9FshdLmOukprnBe?=
 =?us-ascii?Q?X5Bmt+JVD5xICekEa5tFnV92W9EArfmUs3fBNLeufq2ePdJQNR8KeLk8mjW5?=
 =?us-ascii?Q?YKwggc3sKJ9lmEuwKeyqWBkKEjITa6jq7v6QEOIIQeSlMxoOFofpnLrCAHcc?=
 =?us-ascii?Q?EZOwHTE3J/fGolMfz2cBLpn8zCS7ZY6iJhG6lymZjOjUGKgAN20I1MpYxF+m?=
 =?us-ascii?Q?eikFQ/tN3dnVKraoDnST379BmTGRszgnVjhXMP7cQdltR6Rbo831XkGHAaN5?=
 =?us-ascii?Q?G8PWAsW5s6VS9cj1N+N1zC//9cuUM6cImY4h/oVw5eyt5m51szvehdg5B5W+?=
 =?us-ascii?Q?7CDTYqQffFOqzM/D5SLVQUMktdE4buHaAJqttC28ts2uXGOBGqiu8nDbVuFY?=
 =?us-ascii?Q?zpx+HgBjH7Qo+sjiFN1Vo2Em/82hvycfMfz8hI5q89bgUeo3tNRT11z/uTsF?=
 =?us-ascii?Q?OA7CAagCwDyRw2rj/0coReNA5F5DOj7D9hHTpsPy9svyYDuygWaB6iitDL7Q?=
 =?us-ascii?Q?ZxH3t8edJx26kDsjxIJqXOK1x8KxCBoL3Ni4BIyoFsagSfO1yxALQkDh80HG?=
 =?us-ascii?Q?qduWupIOmitoiLW7sLstXFGR/ggRdjsWH0YPcrYRtuIeiwzxCOn0EYPP3dw4?=
 =?us-ascii?Q?cZfW+FJHExnYHY0P6kmpo/wDRkIIxLyZL77aOOMBiqoqru470Lho4YEFhtaN?=
 =?us-ascii?Q?Qs6xbFGQrJsTiAY7ax2b96RsEGls97oRFER3J0ZW+jX041ldXDiR04ifDfbR?=
 =?us-ascii?Q?TSXmws1tPSjODsQvil1Knz4Xq5GbLCJ7bQ9PX7AiZteNSxiVg1dEraZBYfnH?=
 =?us-ascii?Q?PGdeJ3b31x1Z6mKFjE/goHUXdmVl2YnbnxABvRvfD6PdgSrFvLZDfI9OAcI/?=
 =?us-ascii?Q?IwHE0oRbEL9eWdOfqn2Nzuh3ZbhstZcAz0CybDRP0E9tLtO09oY4T2IkAOhF?=
 =?us-ascii?Q?t6Cb/iH3C2U0adCkxpmjPYXdittCIa1g/d10MIRdMlKAPReOExXzXoMI+UE0?=
 =?us-ascii?Q?XohMDU/5qRMXqn/xDkl+c/NgTME8ToHXjT2vlOEzTPzb4LN4pydDUFK54Jms?=
 =?us-ascii?Q?vbar4U/TSGxCcCqi9RhYPs0g7xYkjETi6n0PK0I2?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: qMiz1pgDzLH93dcegMll4aEwxWCg/DBHhtyhZyqQNGWYyjwAUj4eN9d7VUptNbTAF0Gw5/VnTJlhtTrEtzvQx5dgeqa8Qq6bLkhuPevYLb9VaLwk+uNDnfsinTsd4CXc0eaYVbrSp7ASjMmtoJoLfn2m2OMH4+arUBuCEOdmiq4APCnmJ8fifHAC+alagY87k9kDTRaSQiN7Yuv11SDEpWtDYTAF5bdkga5BTub8X/b2kWTVP/SPgrxjZ4KPiIkZdQvt2a9oM6mpgl5Yu6K/7/EDPYydifwNt965dXZ/zuL0L3Aok7sp3wBWOQlq6nAsvSOA7tY6ds5FJONXMGA5s4GxR9I/3UzJ/f4/+p/Fi3qpTsqS3CxDIR5wbnniQ4bOCvzmxBA36A5f5+wl3HHpt/Wko3J8ruapNUCdIHzscGUoIAwU3hPpJzJaNLIKl7FKDo9W8PDg3PyvjpJFOzqjv4oIWka4c5YdEdwfV+HFgh7WRsBqNV9HBSJCJJUtCwCMqE+oZEyMKYs4pyXYxY/WrAzBpEp7FOv5ZWy09n+XZIfL7wiJkUelKXEyUVew6dHI1rAmFfChf2wMEueHT+qbXgLHsjLVWqjNUgCaeudyJ0oIdYYU0p3j8253RsDkEPt2+q63Kzo0cl5A9DQGP5FhTR3M3LViGHssmE9Z0AAN71M0QuV5leusbfdn4DyKMUr93RHmSos67r5poocdghPfFlvkP0HXepbEkKYYQ6IjcY6FjM1iRa4k3+SYG8wkdtKeCNXKkegpqkC5ckB5Pl73YRAop7fkwqzuTJeg5khhE3Pd/SesAE8md3nrlkoWDBqn556pWFHqfGwTFWXlWfFWHRCTrkuWaPjbMiVuUyOdvAPmdnSbbBRda1zA+YV/agTr6x+HVbEsbynCHAs0uizCQw==
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eccb2cb6-d0a4-4ff0-8af0-08db7bf3e2cd
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2023 18:32:41.8973
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CZ2T7+DJkbZ6XDE/pEKtR3mQ31rpM+edR7mBdLDFlvv1PkjuzZRn3AQP3iDbeAUdbc5mVoowv4XJldUyNgW7TA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6459
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-03_13,2023-06-30_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0
 mlxlogscore=999 adultscore=0 bulkscore=0 suspectscore=0 spamscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2305260000 definitions=main-2307030168
X-Proofpoint-ORIG-GUID: 1QhlQ27RYtaRfsG-yGF2YAKS7gmBqVmN
X-Proofpoint-GUID: 1QhlQ27RYtaRfsG-yGF2YAKS7gmBqVmN
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/22/23 22:49, Sidhartha Kumar wrote:
> All users have been converted to hugetlb_set_folio_subpool() so we can
> safely remove this function.
> 
> Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
> ---
> v1 -> v2:
> 	get rid of extra newline
> 	
>  include/linux/hugetlb.h | 6 ------
>  1 file changed, 6 deletions(-)

Thanks,

Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>

-- 
Mike Kravetz

> 
> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
> index beb7c63d28716..ca3c8e10f24a0 100644
> --- a/include/linux/hugetlb.h
> +++ b/include/linux/hugetlb.h
> @@ -761,12 +761,6 @@ static inline void hugetlb_set_folio_subpool(struct folio *folio,
>  	folio->_hugetlb_subpool = subpool;
>  }
>  
> -static inline void hugetlb_set_page_subpool(struct page *hpage,
> -					struct hugepage_subpool *subpool)
> -{
> -	hugetlb_set_folio_subpool(page_folio(hpage), subpool);
> -}
> -
>  static inline struct hstate *hstate_file(struct file *f)
>  {
>  	return hstate_inode(file_inode(f));
> -- 
> 2.41.0
>