Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 03 Jul 2023 19:33:21 +0100
Message-ID: <86zg4cx2tq.wl-maz@kernel.org>
From:   Marc Zyngier <maz@kernel.org>
To:     Palmer Dabbelt <palmer@rivosinc.com>
Cc:     Linus Torvalds <torvalds@linux-foundation.org>,
        Conor Dooley <conor@kernel.org>, apatel@ventanamicro.com,
        oliver.sang@intel.com, Liam.Howlett@oracle.com,
        linux-kernel@vger.kernel.org, lkp@lists.01.org, lkp@intel.com
Subject: Re: [mm] 408579cd62: WARNING:suspicious_RCU_usage
In-Reply-To: <mhng-ce7af44f-732e-4a48-adb4-62deb17b3eb9@palmer-ri-x1c9>
References: <CAHk-=wijh9Gi14SRe0riD8Y9EdPpo3MNU_XDu8vpjY6xWdNhpQ@mail.gmail.com>
        <mhng-ce7af44f-732e-4a48-adb4-62deb17b3eb9@palmer-ri-x1c9>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2
 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Mon, 03 Jul 2023 19:11:27 +0100,
Palmer Dabbelt <palmer@rivosinc.com> wrote:
> 
> On Mon, 03 Jul 2023 10:46:55 PDT (-0700), Linus Torvalds wrote:
> > On Mon, 3 Jul 2023 at 10:34, Marc Zyngier <maz@kernel.org> wrote:
> >> 
> >> Comparing with what we do on arm64, a less radical change would be to
> >> move the IPI init after notify_cpu_starting(), which explicitly
> >> enables RCU usage.
> > 
> > Ack, that looks right to me.
> 
> I don't see anything wrong with it and it's passing my tests, but
> we've got a handful of ways to boot so it's all a bit messy and I
> might be messing something.
> 
> I'm still catching up a bit as I took both days off this weekend.
> Hopefully just an oversight in a bigger rafactoring, but I'll give it
> another look.
> 
> Marc: are you going to send that as a patch?

Just did [1].

Thanks,

	M.

[1] https://lore.kernel.org/r/20230703183126.1567625-1-maz@kernel.org

-- 
Without deviation from the norm, progress is not possible.