Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp26598264rwd; Mon, 3 Jul 2023 11:57:58 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4MV+4Q+/RxhKRTckHR0wfIdmhMRqqtSOsnTxoXmMQqDbXBrz+4bgjirZkqlli5QZoM+dGh X-Received: by 2002:a05:6a20:394d:b0:127:8833:cce3 with SMTP id r13-20020a056a20394d00b001278833cce3mr8675603pzg.8.1688410677762; Mon, 03 Jul 2023 11:57:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688410677; cv=none; d=google.com; s=arc-20160816; b=KazKqizptOJadC1SiRdv9KUP7JCr4SI11SjKHyseBPdo1H+GceyT7jTRU4wBYtfw3R xMUiHkN2o/Xuf8BQxtIWY9bzlIIBF36jvy2ScAjKYHzQvyp6cQhRF9inTVYB+AIveGm9 c0yaqv5magqfrHrq3+IBxtDDMQ+bwZ/kAaQ/bAooHGJIBQ6O1T1YrufQ3wnTjUNMacTT Q1dHyIrpa5HG1TtmMKsp6+74xYoPSh5Sgyr+U53J1OQR82MC2/UlDE6coHDtH8KlZnot KMTaS4HhNPtmjFr0I2nxE23sJYO4i2AExHijoVOTke0axOAM6Jq+HOWQwDFbPhvZVCnV vkPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=4aTpiPAac6Ju+6tfnFcceg2YTVW+chOTuBRG9Ynbnvo=; fh=5yeSY1SX/5BYKJ3zhDzboq66lb94ksAw0qpQI5n3Am0=; b=G5icCNQIHsF6qFH3HDOM64zTKv8xCDwY/DeumISaBewQ2+iZHrO6TNR4qIs9JTExhN 1Tjlq3ApbT6rUsqKf9ZohKUJZsZlXqrwd9JYEgpeMFE3RAgOakssmjaqSiRCVNSu5LDV fcBvr/kU88+jBYxH0/QtxGLB8iYZATt4MCRFo8UdaItujWwwfQ+PFKy3tFwA3tCbB0aD Ziay+igbKyRPk/3xfvRvbbgF95FdLhFyM9UruVq1F8V1QgPxC858pZlw50t68LgAktVm Vebrw0MskM6z6He1lYfarUyhb2+Tvet/0LqQYYMeb3bY1yMnWTRFqZSvPNsOff7fQ7cs 8zFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="BkLmlfC/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t30-20020a63535e000000b0053f0d8ac4aasi19823095pgl.18.2023.07.03.11.57.43; Mon, 03 Jul 2023 11:57:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="BkLmlfC/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231222AbjGCSw3 (ORCPT + 99 others); Mon, 3 Jul 2023 14:52:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230395AbjGCSw2 (ORCPT ); Mon, 3 Jul 2023 14:52:28 -0400 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00B41E6B; Mon, 3 Jul 2023 11:52:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688410347; x=1719946347; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=25ZLJW7OGmWWE2qbCthjIIhoB9XkL05rh/6oTpbhx6s=; b=BkLmlfC/Q0ssauCV4m26xLTNsJ7Jdij63hq19sPtFTnqu7JKC8f7gUno noozTR5LDCzNag7v57wnOgUxsnarRif4MNE6MbNP+ilUWSO21ay+GvqCe 7MREKf5FJgL2JPSqvwp4hfku0050AgxlU5howDxdp5MEGBHf4OUHv+NmC VC0Fl0uOV9p4PZ4pRW7PLJd5P5X4HarqOHYopqxY94Mf1h4YSra83GfKo Pkp1w+moIpv/W+sy+Fsp6Z8dolj7W+JFXxs3j0uKufhqKMfn54bqUn4/g ZHRW/qv0iY1m7R8Gmdi3nqraSAEtvrWh2BiVCxkz2sj8EHJyFNCGs3zlg Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10760"; a="347736197" X-IronPort-AV: E=Sophos;i="6.01,178,1684825200"; d="scan'208";a="347736197" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jul 2023 11:52:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10760"; a="842743322" X-IronPort-AV: E=Sophos;i="6.01,178,1684825200"; d="scan'208";a="842743322" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga004.jf.intel.com with ESMTP; 03 Jul 2023 11:52:24 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 1B021170; Mon, 3 Jul 2023 21:52:26 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jiri Kosina , Benjamin Tissoires , Andy Shevchenko Subject: [PATCH v1 00/12] HID: cp2112: Cleanups and refactorings Date: Mon, 3 Jul 2023 21:52:10 +0300 Message-Id: <20230703185222.50554-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org After I updated GPIO library for the case Benjamin has with CP2112, I have a brief look into the CP2112 driver itself. From GPIO perspective it has two main (maitenance) issues: - usage of ->to_irq() with IRQ chip present; - having IRQ chip not immutable. Besides that there are plenty small cleanups here and there. Hence this series. Compile tested only. Andy Shevchenko (12): lib/string_choices: Add str_write_read() helper HID: cp2112: Use str_write_read() and str_read_write() HID: cp2112: Make irq_chip immutable HID: cp2112: Switch to for_each_set_bit() to simplify the code HID: cp2112: Don't call ->to_irq() explicitly HID: cp2112: Remove dead code HID: cp2112: Define maximum GPIO constant and use it HID: cp2112: Define all GPIO mask and use it HID: cp2112: Use BIT() in GPIO setter and getter HID: cp2112: Use sysfs_emit() to instead of scnprintf() HID: cp2112: Convert to DEVICE_ATTR_RW() HID: cp2112: Use octal permissions drivers/hid/hid-cp2112.c | 169 +++++++++++---------------------- include/linux/string_choices.h | 1 + 2 files changed, 58 insertions(+), 112 deletions(-) -- 2.40.0.1.gaa8946217a0b