Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 03 Jul 2023 19:58:03 +0100
Message-ID: <86v8f0x1ok.wl-maz@kernel.org>
From:   Marc Zyngier <maz@kernel.org>
To:     Palmer Dabbelt <palmer@rivosinc.com>
Cc:     linux-kernel@vger.kernel.org, Conor Dooley <conor@kernel.org>,
        apatel@ventanamicro.com,
        Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] risc-v: Fix order of IPI enablement vs RCU startup
In-Reply-To: <mhng-bb5689ac-5b69-423f-8ea5-42938d5bab85@palmer-ri-x1c9>
References: <20230703183126.1567625-1-maz@kernel.org>
        <mhng-bb5689ac-5b69-423f-8ea5-42938d5bab85@palmer-ri-x1c9>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2
 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Mon, 03 Jul 2023 19:45:43 +0100,
Palmer Dabbelt <palmer@rivosinc.com> wrote:
> 
> On Mon, 03 Jul 2023 11:31:26 PDT (-0700), Marc Zyngier wrote:
> > Conor reports that risc-v tries to enable IPIs before telling the
> > core code to enable RCU. With the introduction of the mapple tree
> > as a backing store for the irq descriptors, this results in
> > a very shouty boot sequence, as RCU is legitimately upset.
> > 
> > Restore some sanity by moving the risc_ipi_enable() call after
> > notify_cpu_starting(), which explicitly enables RCU on the calling
> > CPU.
> > 
> > Fixes: 832f15f42646 ("RISC-V: Treat IPIs as normal Linux IRQs")
> > Reported-by: Conor Dooley <conor@kernel.org>
> > Signed-off-by: Marc Zyngier <maz@kernel.org>
> > Link: https://lore.kernel.org/r/20230703-dupe-frying-79ae2ccf94eb@spud
> > Cc: Anup Patel <apatel@ventanamicro.com>
> > Cc: Palmer Dabbelt <palmer@rivosinc.com>
> > Cc: Linus Torvalds <torvalds@linux-foundation.org>
> > ---
> >  arch/riscv/kernel/smpboot.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/riscv/kernel/smpboot.c b/arch/riscv/kernel/smpboot.c
> > index bb0b76e1a6d4..f4d6acb38dd0 100644
> > --- a/arch/riscv/kernel/smpboot.c
> > +++ b/arch/riscv/kernel/smpboot.c
> > @@ -238,10 +238,11 @@ asmlinkage __visible void smp_callin(void)
> >  	mmgrab(mm);
> >  	current->active_mm = mm;
> > 
> > -	riscv_ipi_enable();
> > -
> >  	store_cpu_topology(curr_cpuid);
> >  	notify_cpu_starting(curr_cpuid);
> > +
> > +	riscv_ipi_enable();
> > +
> >  	numa_add_cpu(curr_cpuid);
> >  	set_cpu_online(curr_cpuid, 1);
> >  	probe_vendor_features(curr_cpuid);
> 
> Thanks.  I was going to send another PR this week anyway, I can just
> pick this up if you want?

Yes please!

	M.

-- 
Without deviation from the norm, progress is not possible.