Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp26681100rwd; Mon, 3 Jul 2023 13:16:40 -0700 (PDT) X-Google-Smtp-Source: APBJJlFQUkFiE66dnCLNTfpqwdf3Sa+H+fDXoQx/c/vH7engWhnd0tPhGV4SLayKulKYERGRuAzG X-Received: by 2002:a92:7304:0:b0:345:d277:18eb with SMTP id o4-20020a927304000000b00345d27718ebmr9218934ilc.30.1688415400244; Mon, 03 Jul 2023 13:16:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688415400; cv=none; d=google.com; s=arc-20160816; b=zySmJZkbKeXOa8JaRutb6a5TgliZFAcTUZ99HhXrWIoQMRzD8tgEfT28x0Cyzf8850 tUlqeJecGZJzcoMiTYFRfDnQR1PR7ULUPQAC/9nGAqEUo12BTGHswzsA1Ai1YZ3NZ06r kRVHJ3xO/7nAji+DNAhH7RoeKv/6iAqcv0BkZuzCDKOuXMjX090cOa/ZbtwdOu+aEWK3 NaIzXXFXrsATKl/tqQ4C+R3n/mAAba8I+94ab/Ng3z7NujK0QgGZlmmhPzAGo05dZCwH MTTHIfq8tEgqCcEgLd1Xq+QH08zDAGnL7guxeE9U/Mj52yVR/gFB0ud98OHxV1xhNeiD DtYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=PTo9mehzOx+2//XRCIPgZXzZYgqSolrNGHz2F2pK0/0=; fh=jrQ9fiPTWNRNKH0mgCFvH9s+O+y7O3fypX/goJ4ZF1w=; b=ldoHD3hIuZaWAU6RigOIbcg+Ivf+62ukqgyc07qLX1e+uhTay4vXm3qgsOk0kKABr/ CiXroCbjWNZtsmYoFjbwc4tiyHa5YdWfKOzzru1LZpINvL8f4oB0WrlBxOORGzn/dhBG oJuVywFgN9BcRbyGB5/Gn72Ci/f1aiFWGHVM4lrh16ybJUROaQSjqkLAtowkI9rVeR44 Z2+isrrKmJcEtK1PuYOLF/X+tDEKsN8r91HugU8dpsNu+L6JGpiNcdrPnNIEhu0lUlDk aApHNG0/3q5jDVSfTkz7h/7C++eCNaWBTnmGXshIluOahv1gm8qGZmW5UBY6L5kMZ6Gy bjtA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o11-20020a635d4b000000b0055745f8d6b1si18302484pgm.383.2023.07.03.13.16.27; Mon, 03 Jul 2023 13:16:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230477AbjGCTwd (ORCPT + 99 others); Mon, 3 Jul 2023 15:52:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229793AbjGCTwc (ORCPT ); Mon, 3 Jul 2023 15:52:32 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2479E5F; Mon, 3 Jul 2023 12:52:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 408D361027; Mon, 3 Jul 2023 19:52:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 495FDC433C7; Mon, 3 Jul 2023 19:52:28 +0000 (UTC) Date: Mon, 3 Jul 2023 15:52:26 -0400 From: Steven Rostedt To: Ajay Kaher Cc: "mhiramat@kernel.org" , "shuah@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-trace-kernel@vger.kernel.org" , "linux-kselftest@vger.kernel.org" , Ching-lin Yu , Nadav Amit , "srivatsa@csail.mit.edu" , Alexey Makhalov , Vasavi Sirnapalli , Tapas Kundu , "er.ajay.kaher@gmail.com" Subject: Re: [PATCH v3 03/10] eventfs: adding eventfs dir add functions Message-ID: <20230703155226.1ab27bc1@gandalf.local.home> In-Reply-To: <84CA259A-8A99-471C-B44C-08D289972F43@vmware.com> References: <1685610013-33478-1-git-send-email-akaher@vmware.com> <1685610013-33478-4-git-send-email-akaher@vmware.com> <20230701095417.3de5baab@rorschach.local.home> <20230703110857.2d051af5@rorschach.local.home> <84CA259A-8A99-471C-B44C-08D289972F43@vmware.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 3 Jul 2023 18:51:22 +0000 Ajay Kaher wrote: > > > > We can also look to see if we can implement this with RCU. What exactly > > is this rwsem protecting? > > > > - struct eventfs_file holds the meta-data for file or dir. > https://github.com/intel-lab-lkp/linux/blob/dfe0dc15a73261ed83cdc728e43f4b3d4e315aae/include/linux/tracefs.h#L28 > - eventfs_rwsem is supposed to protect the 'link-list which is made of struct eventfs_file > ' and elements of struct eventfs_file. RCU is usually the perfect solution for protecting link lists though. I'll take a look at this when I get back to work. -- Steve