Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230620033859.997-1-lidong@vivo.com>
In-Reply-To: <20230620033859.997-1-lidong@vivo.com>
From:   Andreas Gruenbacher <agruenba@redhat.com>
Date:   Mon, 3 Jul 2023 22:31:34 +0200
Message-ID: <CAHc6FU71+Y2CT=04cbgtxp5p8jPYU5RK0tcz8wR4jyLdQw6h4A@mail.gmail.com>
Subject: Re: [PATCH] fs: Fix bug in gfs2_freeze_func that can cause deadlock
To:     Li Dong <lidong@vivo.com>
Cc:     Bob Peterson <rpeterso@redhat.com>,
        "open list:GFS2 FILE SYSTEM" <cluster-devel@redhat.com>,
        open list <linux-kernel@vger.kernel.org>,
        opensource.kernel@vivo.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Li Dong,

On Tue, Jun 20, 2023 at 5:47=E2=80=AFAM Li Dong <lidong@vivo.com> wrote:
> Function gfs2_freeze_func causes a deadlock=EF=BC=8Cbecause sd_freeze_mut=
ex was
> not released when return
>
> Signed-off-by: Li Dong <lidong@vivo.com>
> ---
>  fs/gfs2/super.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c
> --- a/fs/gfs2/super.c
> +++ b/fs/gfs2/super.c
> @@ -741,8 +741,10 @@ void gfs2_freeze_func(struct work_struct *work)
>         set_bit(SDF_FROZEN, &sdp->sd_flags);
>
>         error =3D gfs2_do_thaw(sdp);
> -       if (error)
> +       if (error) {
> +               mutex_unlock(&sdp->sd_freeze_mutex);
>                 goto out;
> +       }

thank you for this bug report. I have chosen to fold this fix into
commit "gfs2: Rework freeze / thaw logic" and clean up
gfs2_freeze_func() a little along the way; see the current for-next
branch.

Thanks,
Andreas

>         clear_bit(SDF_FROZEN, &sdp->sd_flags);
>
> --
> 2.31.1.windows.1