Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 4 Jul 2023 00:30:46 +0200
From:   Frederic Weisbecker <frederic@kernel.org>
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Anna-Maria Behnsen <anna-maria@linutronix.de>,
        John Stultz <jstultz@google.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>,
        Stephen Boyd <sboyd@kernel.org>,
        Eric Biederman <ebiederm@xmission.com>,
        Oleg Nesterov <oleg@redhat.com>
Subject: Re: [patch 17/45] posix-cpu-timers: Make k_itimer::it_active
 consistent
Message-ID: <ZKNMFv7VTIaTTJwe@lothringen>
References: <20230606132949.068951363@linutronix.de>
 <20230606142031.983662966@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230606142031.983662966@linutronix.de>
Precedence: bulk

On Tue, Jun 06, 2023 at 04:37:45PM +0200, Thomas Gleixner wrote:
> @@ -787,6 +790,7 @@ static u64 collect_timerqueue(struct tim
>  
>  	while ((next = timerqueue_getnext(head))) {
>  		struct cpu_timer *ctmr;
> +		struct k_itimer *ktmr;
>  		u64 expires;
>  
>  		ctmr = container_of(next, struct cpu_timer, node);
> @@ -799,6 +803,8 @@ static u64 collect_timerqueue(struct tim
>  		/* See posix_cpu_timer_wait_running() */
>  		rcu_assign_pointer(ctmr->handling, current);
>  		cpu_timer_dequeue(ctmr);
> +		ktmr = container_of(ctmr, struct k_itimer, it.cpu);
> +		ktmr->it_active = 0;

Maybe move this to cpu_timer_fire() because:

1) Other posix-timer implementation set it_active = 0
   from their actual handler.

2) This place doesn't have the timer locked. Better Make
   sure we have this protection to avoid mistakes against
   potential future use of it_active.

Thanks.

>  		list_add_tail(&ctmr->elist, firing);
>  	}
>  
>