Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     netdev@vger.kernel.org
Cc:     Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, linux-kernel@vger.kernel.org
Subject: [PATCH v2 net 0/2] Fix mangled link-local MAC DAs with SJA1105 DSA
Date:   Tue,  4 Jul 2023 01:05:43 +0300
Message-Id: <20230703220545.3172891-1-vladimir.oltean@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?o4r5x5ftiLf36DIYJGMb2bHSFFzV9WrdF1n4tvtBXIGQAQMD/5R+Tyth7ig9?=
 =?us-ascii?Q?/zJXoS+QsHqswat5VEre4LBHgWdxNWX9s8p3zLBfcuBjP7lsbbTJ2hkS2aDv?=
 =?us-ascii?Q?sciajrUmWHBxdhnTCfBsxpEO2tPaFk0fBTA0Pn1cE0ZKxMRIT1IxZnVgMY8n?=
 =?us-ascii?Q?H8QsUK4+XlA0bT1ueGgiLP6rEMGBnaKTR6L64AdZqknCsp4TcFTlOFrRKSrL?=
 =?us-ascii?Q?zV03uzNuZWSsaWmldmCD5qqwvYZTX2PDibU7m+CVs3YIV+1dPNNqxZKJ5vxS?=
 =?us-ascii?Q?56SdWbgxcTNiHb/do61fJcxPhzR/IHTqGG2yGXvLSx63WSKgPZYejkB5ALWf?=
 =?us-ascii?Q?KNg5WS1s+LYrua02LEsmC48urFw62Sp4Foozw8cSF2fv4lPwEFX9fLbou6oZ?=
 =?us-ascii?Q?SewW8rFcb41XDm2xKfnLJf6cuJTReYQ8eL/+AIXmjyUZSTCztWx807jS1J2/?=
 =?us-ascii?Q?652xmlsD0RS/ct9kxQe3vMBNLGNQ/B4l7CZIz4Hm1MLbuajY/cPNl3XaN7Mh?=
 =?us-ascii?Q?7h2tKKzADM6SnnGZ3mEgK7TmlUG6zgKdgBseW5JBlEUgRoPcLmJxXT6K8s7z?=
 =?us-ascii?Q?R5pcxBkAFivCHZ7q8IwruDTL0iLYDUMDMx3tn4+7ltmqKzs3JDZ5ouD7irXE?=
 =?us-ascii?Q?XrO+3Oc/SVTEE79Eb0PVwmC5xASVtbqL0WHA3dzttzwT03GLlyOPwlNJbykB?=
 =?us-ascii?Q?/O623ayhkDqkSSkwMpfQLznRH2DIZUfYa3hlk+rf7h+XtTr8MJyQHGGmtX3g?=
 =?us-ascii?Q?2IP4gpIbVrVcBFk8RnoRaQHMk1YEhTu8H+WsklqAdUr6ly7Y8CadRuob9XxA?=
 =?us-ascii?Q?WyWHxp80oWXSZ/ea4bj3sxo1JthtcoB/qQw8UccZkEEaDRU8B4muIDkV95ki?=
 =?us-ascii?Q?9RPeYbqYcKcIpjBQ7+/WodCBsRo3AH1pVigBG3N/iV6DPj2H4wVpP5Y8YH4+?=
 =?us-ascii?Q?r2bxeCRfDMTPSbJ1bg05xWrJNL4wOlXMjyouCjj4oj+zmsWq0+HLgd5nMR4q?=
 =?us-ascii?Q?8amJXHbdM8AhopC4gNUPRMSMOQxTu3caupSD7Nv2DrPYgXaCtktudJffkMJQ?=
 =?us-ascii?Q?XO3jMguhc8PVvlT6EmkCoQDiwlMUZcQImkZxWbpdo7xlR0tKSWnx5rBhbAVx?=
 =?us-ascii?Q?nntN0f7mIdh3+V2Fu3+6Qdbl12PgAQEACJ9yEtk+6jY1GayhgmTNWd95Emaz?=
 =?us-ascii?Q?g6WdolLtC4mH1w1QH1qdoJOsNbLPlQa2VQdV7K/lHJ683nFPYcO6fo4Tm/6L?=
 =?us-ascii?Q?1PeOTfaKB/6rvghbZyXb2ElS54seyGwplhafBMY4yN3bYRMykhwcx4xOAW7B?=
 =?us-ascii?Q?MYVHB9JELBKavlli3/HsLFFj1z05eQtwLMS+6ojHRo546bnxcXDHWzyjvqPw?=
 =?us-ascii?Q?8L4y6q4hs3INGdJQ2DH8UNVcVktx9gZHZfYXFqTsnlhllhCZKQeyCjxUXssl?=
 =?us-ascii?Q?Gf7VZD9tAvh5NpcOCGt3gnSVTenTEsljdOWcVI8H8HTFOMk3I1vU5U+JKKCc?=
 =?us-ascii?Q?u+QSqn2uDmhWNxMNBhyfRT89dQyFTpMZftw7396zOhINlGP/MA2RMA4RcHpe?=
 =?us-ascii?Q?33Hul8w1urR8MJXcqi6nbyeucS1pVI/pHGrSU4bdKfvgz0HTpiw3xACiLtTp?=
 =?us-ascii?Q?yg=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a81d1803-9d87-48fb-2f87-08db7c11b5d1
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2023 22:06:11.2049
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VZeAhm0wQ8hMpfNvpH5VRZKQ7MrOh3/dE4JaszuAp+WmkQ2OJ2GQYWPSN6colQ/fcmJASrUlL5OXrdeNZa/9zA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9118
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The SJA1105 hardware tagging protocol is weird and will put DSA
information (source port, switch ID) in the MAC DA of the packets sent
to the CPU, and then send some additional (meta) packets which contain
the original bytes from the previous packet's MAC DA.

The tagging protocol driver contains logic to handle this, but the meta
frames are optional functionality, and there are configurations when
they aren't received (no PTP RX timestamping). Thus, the MAC DA from
packets sent to the stack is not correct in all cases.

Also, during testing it was found that the MAC DA patching procedure was
incorrect.

The investigation comes as a result of this discussion with Paolo:
https://lore.kernel.org/netdev/f494387c8d55d9b1d5a3e88beedeeb448f2e6cc3.camel@redhat.com/

Vladimir Oltean (2):
  net: dsa: tag_sja1105: fix MAC DA patching from meta frames
  net: dsa: sja1105: always enable the send_meta options

 drivers/net/dsa/sja1105/sja1105.h      |  2 +-
 drivers/net/dsa/sja1105/sja1105_main.c |  5 ++-
 drivers/net/dsa/sja1105/sja1105_ptp.c  | 48 +++----------------------
 include/linux/dsa/sja1105.h            |  4 ---
 net/dsa/tag_sja1105.c                  | 49 ++------------------------
 5 files changed, 9 insertions(+), 99 deletions(-)

-- 
2.34.1