Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp26901993rwd; Mon, 3 Jul 2023 17:16:24 -0700 (PDT) X-Google-Smtp-Source: APBJJlHO37Us3RFlNcYhrPxHrwVlaeMILDBsMWcYLBT4wqwwgQnhkbwZVxO2hdj7dycq/ZnoUsaH X-Received: by 2002:a17:902:c20c:b0:1b0:6c3e:363 with SMTP id 12-20020a170902c20c00b001b06c3e0363mr9701742pll.0.1688429784468; Mon, 03 Jul 2023 17:16:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688429784; cv=none; d=google.com; s=arc-20160816; b=oZMSbQXYvqaHf9zYAdicjiHYhnK7nWsYPzJ4jsXGLnYwbT9e2vNMe2nXFjngXU+WQ/ S6o2jgcEDlktvXdgKgXxr9rHBNNI5LvGmwNjOylH9nYkh7jTKfSQCRfxczE7w/3kC3fW kq8SGDPjAsMhlUQqxtF4aEeSJFOpl7pPNDojo/5y3T/EGZZBlDGuEVkV/L80Rn6eAZeM F3bHPpv64Bg2YvMdNDR0bTe9rFJQIWZQgpSl0qqlGNC0FzwChA7cASpkPyPMlB+IsRvc XNYAcMO/sXtESjdwULPsBpwtMGV7Yozmdqf2yz09myzpoAFN7c+ItYRtRrg0jnM3Cs8w i/Gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=wt4a8RXJ2JiYk/Pl31BqCi5HFHSZASXBHI2soh1Xmv0=; fh=XLJLg8WXdhwGrMSzs3MfkZczrcBsqkmvHzzfT+Z54/s=; b=eG1DkP6yiJRBTd9RJSSrKg7AxeOScph9vQ48uOeK8SkOP6pL6EURE2MROw2XoG1SOh chpHCz1bG6tWQw8vhWfZDhaBESrT3Hg/+Aky58T3TV+ML6uOANjoW+klqyiaDbs1pMTK +bSG4omqyfx8U/pGPFMZZ4KzglNrw4YOh0a0hey42Q4GJGC5Hf0bvw/sXqMsMEGDjDBP GPS2i9UsJrbWRL2sAEJKPk1an804tuGY4R0L3et7x0LNLaMi6Im4lASVlrITtVq7Jzi7 a8daS20wDjvKbBDL7mi0/VISnchEnoFgRNnyJ+Fazd/MCYiqjkUPdAf5ON0MbFQvsyFP eOkQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=XAhAkYYN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y17-20020a170902b49100b001b3f9cedbb7si18025755plr.398.2023.07.03.17.16.12; Mon, 03 Jul 2023 17:16:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=XAhAkYYN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229698AbjGCX3f (ORCPT + 99 others); Mon, 3 Jul 2023 19:29:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229534AbjGCX3e (ORCPT ); Mon, 3 Jul 2023 19:29:34 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D767CEA for ; Mon, 3 Jul 2023 16:29:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=wt4a8RXJ2JiYk/Pl31BqCi5HFHSZASXBHI2soh1Xmv0=; b=XAhAkYYNNjRvruE1yDRVPXBErg 9BfU/bc6Ntz02LFkbsWOLfgjNfbHcn9/v+A/9LWu++OCVgLTgSF8GM13v/uzY8Ibuf920n8vuWxhm TgngC213z5oB/3QepAl4a4xmzKTbSHvaoJSOnjW2j7+1wWCQauo/TZ9KB4A7YUd4TpQbQo4qgq1Na 6l7cnzBAO0TCYt6Lywaa+noX1sGZLeirees01YEM9S6CFhBmkR6ZA1LxG/cBRMSZCF63Q2MYHfAfW gEutZAM/qjUNNP0D8wwxUhavZ7gALUekQGwL4FrNOojTLrKk6MigFerLpYYBoOskd6C+3o/CMUR0j a4piZS3Q==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qGSz4-008crP-Ki; Mon, 03 Jul 2023 23:29:30 +0000 Date: Tue, 4 Jul 2023 00:29:30 +0100 From: Matthew Wilcox To: Sidhartha Kumar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org Subject: Re: [PATCH 2/4] mm/memory: convert wp_page_shared() to use folios Message-ID: References: <20230703055850.227169-1-sidhartha.kumar@oracle.com> <20230703055850.227169-2-sidhartha.kumar@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230703055850.227169-2-sidhartha.kumar@oracle.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 02, 2023 at 10:58:48PM -0700, Sidhartha Kumar wrote: > @@ -3296,21 +3297,21 @@ static vm_fault_t wp_page_shared(struct vm_fault *vmf) > tmp = do_page_mkwrite(vmf); A nice improvement to make after the series might be to pass (vmf, folio) to save even more calls to compound_head().