Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ba5099b8-f72c-f267-41a7-d0ee18680796@oracle.com>
Date:   Mon, 3 Jul 2023 17:26:02 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH] mlx5_vdpa: offer VHOST_BACKEND_F_ENABLE_AFTER_DRIVER_OK
Content-Language: en-US
To:     "Michael S. Tsirkin" <mst@redhat.com>,
        =?UTF-8?Q?Eugenio_P=c3=a9rez?= <eperezma@redhat.com>
Cc:     linux-kernel@vger.kernel.org, Dragos Tatulea <dtatulea@nvidia.com>,
        virtualization@lists.linux-foundation.org, leiyang@redhat.com,
        Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
        Jason Wang <jasowang@redhat.com>
References: <20230703142514.363256-1-eperezma@redhat.com>
 <20230703110241-mutt-send-email-mst@kernel.org>
From:   Si-Wei Liu <si-wei.liu@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20230703110241-mutt-send-email-mst@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SGw1Zk5XMXRIMDhSeFVPSkI5V1RXVnltVzJVQmQ2Qjh6OHJQZGFualBCT1Bu?=
 =?utf-8?B?STl5akx6UU54WEViWE9Ub3J3K2VUVS9EalB4UXU0b3Q2REc2a3FlL0g3Mi9T?=
 =?utf-8?B?NCtZalFKR1puUU9XWjEyQlFkVkZQenpSNUsvZjJPN1dLOURCWmpuMU5YTWdF?=
 =?utf-8?B?RG9MMEdybTdkTXVxWXp1dEVBOVdQUVpaRE4zTTNzTExuUUplOFRWcmxxMWYv?=
 =?utf-8?B?WEtRSGsvSFlHdWdRM00zUnEyazFyckg3b2M2V01ldk1xWDJxZjl5K2FkZGgy?=
 =?utf-8?B?Y1drcU1WUGJwWXE2YjNJaFU5c2dXZCtOZDNycDNoelZubG95UUJ3SGdTVVI3?=
 =?utf-8?B?SlF2Zm4vaXdLSTRWWS9XZGQxdUhzRENSY2lvanplSFYxeXQ0bVdIV3dFQ1c5?=
 =?utf-8?B?OFJ6R0VUSUlreFF3NjRvSDl5REYvZk9hc05IWmxpcWI2aGVaenRNSUF4bzU3?=
 =?utf-8?B?ZE9EbDlMZlUwTnNkTnBDMTVWRXVjRXMxVXNXa0hjaEJiOEZRbmU3NnlDT0pz?=
 =?utf-8?B?bWFqYllPVVVTdXBJWkM2VzgzTDBqWEtTN2hPTmdJajc1SGVuM2RWMUFqU2JD?=
 =?utf-8?B?MHF0N1Z4Y0JMOWpjYk0rOTNXK0V3QWNEdDVIdU8xZ2RpRkQ1aVN1M29wRWJ1?=
 =?utf-8?B?VS9SNDMxQ1l1dlVEbFN6OVBnUlFZMnRMUlI0VDJ0R0xyU2kwS3lNU25hdHZ0?=
 =?utf-8?B?cnl1UlFDbUtVL0lkNWhOQjRCdW9rUFUvWkRFMng3R1hPclJqdG9FdDk4OUMv?=
 =?utf-8?B?eFN2K2dTSzEyVDdpSTJaZ1hqSUVxenlQVWdzR1ZDRm0xYVFKMFBZMWQyYkZC?=
 =?utf-8?B?bEIyZTR1UHJnVEpTVVhXbkNibU5vb3cyUlQrK1ZMaWdwL2lBcnlrcDFYbW10?=
 =?utf-8?B?bjZOS09VNjRLWUl0WENqMjk2bVJBbW5SWmFUaS9FdE12WFkvdXBleHhQaHkv?=
 =?utf-8?B?eHlLNG15ZlE3Wk1VQjNpanRJUk1CRDZzUy9jV1NnVVRseVNtaFFjUERIcnZT?=
 =?utf-8?B?RTBQaDNpMUF3T05GQTVqVklkK1VnbW4xZVVRNEdVeGtDV29BZjE3TWRmalJB?=
 =?utf-8?B?SFhMSnNmdGVPNEg1UU0xVkpObmpHUURFVUxGTmZRNS9FSWViOGZMOE1ZMXhQ?=
 =?utf-8?B?WWNvNXBGak4rSnhKZHdjSVd4NGtHaVcvWVdsOGFSLzVJdmhTVjZwazdPYlZi?=
 =?utf-8?B?aTIxd3UzSGphdTNURlhxdktxYzlpaGZxeUp2Y2VXK2VmRjlUaXV5dDZRNHJj?=
 =?utf-8?B?R0phWnpsTjR4TjdNa0lMekdLd0MxaFB1T1lSMFRkQ0hoN2l0cnorelFBcjkx?=
 =?utf-8?B?aU51RE9kanRtNnhvcVBqMXVuTExxbXhQNGNDQ25BMEd0aldWbTdNMERudFM4?=
 =?utf-8?B?blRlZktLYnk1WGllUk5LVWxSd2FCSUdyZDE5VEVCT205UFlFTU9HRjFjemc0?=
 =?utf-8?B?Mi9FWFUwYUdCYUZOalNsYkQzY09ydlEvZlRRbk5JNWU2ZWprNU55TWMxK1Fp?=
 =?utf-8?B?akwvMHY3b0JRQVJXZk11bWh6RmphWWczK0VQYkJ1cXJqNWNad0tBMUdTRFIy?=
 =?utf-8?B?ZXFSVmRoWUhKc2tZTWdzWlRMSzhiMysvTnNkM3FnVjE4WlVPQXVqMXJmVGRi?=
 =?utf-8?B?OE1lbWZNb1pETG1CcDlDaDBHV3UvUnFqOHM5aWxDczhMNVNEeFMvZWYwRHVU?=
 =?utf-8?B?bFFDOG44dTBHQ2dSMWJTbytCajJYUkVnYTU1cFlXeS9LUmYvcWFIR21TWm54?=
 =?utf-8?B?bFZlVFZNd2hKL3V5ZnBIK0hGSnJIRkE0dk9EU2FPMEJ2RFo2V3JyeU5jazJT?=
 =?utf-8?B?VE1ydGU3MVFZUFlFRm9aRFk0MndiNTRBVmQ5dWVNU0hTTzI4UHhMOGxvZlZz?=
 =?utf-8?B?Vk5jdVh6RU51bUhPYjFWY2RmMEZrUFhxZ0xJalVWanE5WkU2TUx5ZmIwdDdT?=
 =?utf-8?B?UUZpUUJGUUVaNk1HdVpBb21NenN1clltdzEzdkVKYW1BT2VrTWFTOXcxcTRa?=
 =?utf-8?B?L0FjVDNIbTdLcDArQUxNK2hhMEMyODdudStHR3E1M0M4ZlhiNXVCSlNCeTV2?=
 =?utf-8?B?VW5vT1BIVTB4QUY1aU1Pa2hodmVZMGxBZmZOWitEMXJkQmpWdFBXN2lrc1ZX?=
 =?utf-8?Q?A1BgooOLxbuXZKfMm3Tw0HYny?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?ckZUR3ZwcHd3aXRTMmphY2dzRVNkVnNqQmFVZitjM1lQWkRlQXluUFhJckZy?=
 =?utf-8?B?RmZPNyszdWd5UHRobHVLaGFzZXVINzVEc1c4aXlnNHVuNEZpdW55RjNLY2Ra?=
 =?utf-8?B?QTVNQ1YwYUtBYWdlVU1nVU1EZlh2NjAyL0Vlem5jS1EzZ0duQzRtNU5Ia2FK?=
 =?utf-8?B?VVRHYU91UGloQ0Nucjk3a1lsYWsrTFdoK2xtbVNiQXlXRWlpNVdRcXJMZ0Jh?=
 =?utf-8?B?SjhjdXZHM0JGZFdpbjJ4a1g1ZnFNU0ZnWGx6VUZhdS9IMzhoK2xnYThOek5S?=
 =?utf-8?B?eHM5Nmd0MnZZYzBOa1lBdTVBNitTN3hjcnY0T3JwWUFGbnVsampBQlNQTU5j?=
 =?utf-8?B?RFAxYWE4K0FFcWxZZXlzY0l1ZWlWRm5KSXBvZmNTMzJOc1F0M2xBK2h1U3Qv?=
 =?utf-8?B?NTBlSGU5c1B5eDR3NTYvSThxaHdTeGh3a3NyMnBKVVVGUFZMNVNWUENDRXJE?=
 =?utf-8?B?NzJycGpadFl1NXJuS3I5TTJyWVh3Ri9neUFrdXpXUTB4ME5NSERnZVpDV0xL?=
 =?utf-8?B?R3kwSkFBT2EwTXFPUGpOUGU2cG8vb09iT2dobHl0QTBoNkg3bUtlN1l0Yk11?=
 =?utf-8?B?aWx1WXpmNzd6ekliRzlTMUtML3BkeWFUbzZFdG1DeUczVGlmTEhwbDVna2RN?=
 =?utf-8?B?OHE0aGhVSStUOUJkWEIwNWR6TVpOMHpMendGaDVrTzI1blliTE5VcGdYeTFR?=
 =?utf-8?B?TU05NjkyNEJqSWFnNDFTN0pTOTN2WTdwYzU1MGxZVkpRS3hiNWN3aGRPOHMz?=
 =?utf-8?B?THErWmdyY1ZHU2VHOHh6Zk4wbHppQVc4dTE4TUxQYU9jaEprcmRZNkZWbTA0?=
 =?utf-8?B?T2FId1RDWGs3aTd0Zk5pTWphQVAzS3VaR3V3OXQ5dFJreG14Y1p4ZlFRMktI?=
 =?utf-8?B?SGtTT1RGMi9ucVZuejhZeTJveWY4bmYyU0g1UUw5MkV1WTRxWFZyUXlUY01R?=
 =?utf-8?B?SU9HUVlSRUxnaGJlYXZCd3dkUzZlOTk0UHJUMk5OWnkzdk1Yb0ZtMXJZNTZR?=
 =?utf-8?B?ZkJOVmlEMjNldWxwbCtQT3VVN2xSZGZ6NmZzYk5YY2JyUzI0YU02K1JiQmly?=
 =?utf-8?B?aldmb2FFZ3hjUmlWRDdrZUNXZ3E5SmtUMzg2d3FwQm5HVU80WXVISVljTGM1?=
 =?utf-8?B?SzdWTkFvRzJMYnZOQ29EYWhWQUJleFZNOUh2bGhaZUcvdHh2UDFmUThhemJY?=
 =?utf-8?B?a3Z4b2NkUW83STYzZ3QwRmg1SUs5MzUzUEkvN2RsSkVZMzZmNHFoOUZjVEI4?=
 =?utf-8?Q?sQOeODnpe24M1Tt?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 20d63327-9327-4409-e746-08db7c254213
X-MS-Exchange-CrossTenant-AuthSource: MW4PR10MB6535.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 00:26:06.8913
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CqaeEtnQNsY4OGV6rsCwJXAOkrDsC8zAZwR27rNHwc496D3hbOR1vXPFNzAgGQqzTjDnt7vsatvYq9f1VU6WAA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB6061
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-03_17,2023-06-30_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 mlxlogscore=999 phishscore=0
 malwarescore=0 spamscore=0 bulkscore=0 suspectscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000
 definitions=main-2307040002
X-Proofpoint-ORIG-GUID: rqVd3TyNeSUbkVWEZXzeLD4UH6wzL8zQ
X-Proofpoint-GUID: rqVd3TyNeSUbkVWEZXzeLD4UH6wzL8zQ
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/3/2023 8:46 AM, Michael S. Tsirkin wrote:
> On Mon, Jul 03, 2023 at 04:25:14PM +0200, Eugenio Pérez wrote:
>> Offer this backend feature as mlx5 is compatible with it. It allows it
>> to do live migration with CVQ, dynamically switching between passthrough
>> and shadow virtqueue.
>>
>> Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
> Same comment.
to which?

-Siwei

>
>> ---
>>   drivers/vdpa/mlx5/net/mlx5_vnet.c | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
>> index 9138ef2fb2c8..5f309a16b9dc 100644
>> --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
>> +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
>> @@ -7,6 +7,7 @@
>>   #include <uapi/linux/virtio_net.h>
>>   #include <uapi/linux/virtio_ids.h>
>>   #include <uapi/linux/vdpa.h>
>> +#include <uapi/linux/vhost_types.h>
>>   #include <linux/virtio_config.h>
>>   #include <linux/auxiliary_bus.h>
>>   #include <linux/mlx5/cq.h>
>> @@ -2499,6 +2500,11 @@ static void unregister_link_notifier(struct mlx5_vdpa_net *ndev)
>>   		flush_workqueue(ndev->mvdev.wq);
>>   }
>>   
>> +static u64 mlx5_vdpa_get_backend_features(const struct vdpa_device *vdpa)
>> +{
>> +	return BIT_ULL(VHOST_BACKEND_F_ENABLE_AFTER_DRIVER_OK);
>> +}
>> +
>>   static int mlx5_vdpa_set_driver_features(struct vdpa_device *vdev, u64 features)
>>   {
>>   	struct mlx5_vdpa_dev *mvdev = to_mvdev(vdev);
>> @@ -3140,6 +3146,7 @@ static const struct vdpa_config_ops mlx5_vdpa_ops = {
>>   	.get_vq_align = mlx5_vdpa_get_vq_align,
>>   	.get_vq_group = mlx5_vdpa_get_vq_group,
>>   	.get_device_features = mlx5_vdpa_get_device_features,
>> +	.get_backend_features = mlx5_vdpa_get_backend_features,
>>   	.set_driver_features = mlx5_vdpa_set_driver_features,
>>   	.get_driver_features = mlx5_vdpa_get_driver_features,
>>   	.set_config_cb = mlx5_vdpa_set_config_cb,
>> -- 
>> 2.39.3