Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1ca42aaa-3864-2143-b29f-31016eb7304f@amd.com>
Date:   Mon, 3 Jul 2023 20:09:19 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH] cpufreq: amd-pstate: Add sysfs file for base frequency
Content-Language: en-US
To:     Huang Rui <ray.huang@amd.com>
Cc:     "rafael@kernel.org" <rafael@kernel.org>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Karny, Wyes" <Wyes.Karny@amd.com>,
        "Yuan, Perry" <Perry.Yuan@amd.com>
References: <20230629135454.177421-1-mario.limonciello@amd.com>
 <ZKJzfbbMFRQO7xov@amd.com>
From:   Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <ZKJzfbbMFRQO7xov@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MWZnUjBJbTBmR3l6dzVsSkxQK0c2QXd3RjNEOUl4Ym4vY25VMUE3bXRrSWlJ?=
 =?utf-8?B?MEFIRmxCRkszMituVSt1WllxdnEwQnNvQmxIUHQvRmVPTVl3QjNOZWkwZ0tw?=
 =?utf-8?B?ZVFCSzVwRk5LYmxCUGkva0ZpYTRxZ3pJYUtXUk9qNVRiSWFocFVZY2VQdlo1?=
 =?utf-8?B?SWpWc3M3dU1rbTJFTEpyajdhT2FxbHZhakhmNDdMWDFWRndMMHcrUXk0bXgx?=
 =?utf-8?B?aG5uWEhTQ0xXNkFJYUxnSFN4UHRYQlZFSUpEVlJ2YzIzS0JtR3NGUVp2Y2lz?=
 =?utf-8?B?VDhiLzZ1K3dXSW9BVXIweEQwY2R3dVZLZmlFM2xYUjR1akxWWEJ3bktzY3di?=
 =?utf-8?B?ZnJ1QmJ6M3BQcWZPa3dVMFE5YzdtZ2JQQzVlR3FTZW40bzNoVjV5Wkp4SXo2?=
 =?utf-8?B?UmhvSWNLMUJyWWF0TDB2ekwzWnljUjFxTFNqQ0wwQ01WV2VLemxNZStkaGFw?=
 =?utf-8?B?RFJMa3hySTN5bzRNSFRHY0U4SFQ3N0hxbmVkMjc2RG9VbFRXUU96UUZITVBn?=
 =?utf-8?B?dTNscjBBcHZ1SFFJUU1nL1kvSmhPVXFLMW5QMzlYWHkzS0ppY1hha3pNM0gw?=
 =?utf-8?B?ZnRmcUYrNXFReTBHL0F0RFFoSGloUUhESjZGOUVqWTh0Y1NSZFA0VGJ1Z2Zn?=
 =?utf-8?B?c1BBVzZ2bkwrMGhXN0pnZkJBVlhpMnZKZk9sL0t3SjBlWFR5b01JSlRqMHcv?=
 =?utf-8?B?RTNHYytrcHFUVERtNG16NHJ5SkI4SHdUcTlpN1Fyb2dsL0VpenJ0NHRGRk1C?=
 =?utf-8?B?eHg2N2wyOTRiSmIwQUlpVDBod3dnblRJVmUyL21CdDRMeU5zcGNBamIrZ2VE?=
 =?utf-8?B?ZzZ5ZXp2YTNoemE4YUdWQ3RjMXV5WG1EbldDeGpSQ2VXeUpmVUpSRnpBY21H?=
 =?utf-8?B?dnV4cjh4K3g4V3FYUHZiOWpNRUtOTTY0NWJKVDI0NkJUcFNjSStNcjVsdGUx?=
 =?utf-8?B?TUMrNnJEc1VaTGp5RzBUYUdIRWE1N1JFRndOTzdkTWxPNTQ0RHRUR1QrYUIv?=
 =?utf-8?B?Y3N1amZBai9DMnovTldQRm9IY0FJNzA4MGl0MCs4bDBrTk96OWwyL2MwZEs4?=
 =?utf-8?B?Skl1dk9TSGw3QWF5QzAwdVd0elVWVTcyK0tJR0RXdUdNY1IzalI3WDI3b0ZS?=
 =?utf-8?B?WWoyazhWdnN1aGpjMmZ5L0VaMHpUa2hDL3l3TVMvUWdheERWeVZTTlBIdnFj?=
 =?utf-8?B?QVdZUllvUlJjSWFYNml3bzZ0ak9YSFhBV0ZjQ1pjWTg1WklRc3JQeHlrY3FC?=
 =?utf-8?B?d0I0d0k5VHVTK2hKbUlINDd1ZTRSclkwYm9uYnJmNllodEs2YXZ0VVFqREZD?=
 =?utf-8?B?WTdoNVppdks0MWdrdmdkYng4VFd1WFE3QURzRkJMT0NYdUJ4TllLUHgvTjJX?=
 =?utf-8?B?cmtuaWkyUlRKcHZIZjFtR21vNWJla25rUTBHV3VKNkRjSEI1cUtQcnJxS01B?=
 =?utf-8?B?QWhZYy9oZGF1Wks1Z3lHQTNxSlRDdDRrU1BKUFNjdVM5bDRsMVFTWUJGS1N4?=
 =?utf-8?B?dEordFVUcGh4Q0xXQnhXVmFuek4weUtTRTdkMDEzWnd0TmxnZnREbDB5VCsz?=
 =?utf-8?B?VUlyeGdOeURHcUJ2NjY5bkZtYlY2S0JPb2h1NVdOUEtxaHd5Y2VHMWliZUd6?=
 =?utf-8?B?STBXL0t0bGEvajNtM0VYNnVDZjJ5alZ3T0p6Mm9OOFpqZUZ6dU83Y1N6eUVa?=
 =?utf-8?B?eG5RTlhYVWkwVjhjS1BmL3YrYVFHbmQ5UU9wSzcrOTA3dCtLY05pMEliek41?=
 =?utf-8?B?cm5oeHRqTlB2UG0yeU1sb0dLZzdyOUZQUjBSYXNlZmZDVWt5WnVqSVNsdjBo?=
 =?utf-8?B?MmhVT1dNVTBVTTliRzVPOFRjSFJOcnF6OWhDZGwyK1VNWkN2d240RkRJTGxT?=
 =?utf-8?B?VGlxVVBJcElVVjBoMFBQaitOcnd1MnhFOE1tbkJuZTlnOWlJU3ZzdlFUUmla?=
 =?utf-8?B?NDNqSzJKT0hoRGRZUUE1eHRlMDVtUEtHVmhZWDZGTG4zV1JPK3pBVGVhK2hR?=
 =?utf-8?B?eGxWKzhhYUh4V25kQmZjU1BHQU8yNU1LVGk5RlNxTExPM1puTFpDRzE2VURQ?=
 =?utf-8?B?QmRQVU9xSFd3UDZVelROWU1FZkxWN1lyQVZ5bmZpeElmTlJGbG4zUVFoTG9X?=
 =?utf-8?B?dTVZd3ZBRnA2ZjRjOWloVFRrcERIRFZrakY0WmRmYno0TEtlRTZwc0Z0Z09V?=
 =?utf-8?B?Y2c9PQ==?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b5b07447-11b2-4e72-b074-08db7c2b4cde
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 01:09:21.9903
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Aj7BZOq/2a4liRi+rKmXCUgchEpaPWd00tLWnI7YwrXRS3t2p31IIAZrWbRo5dpoaBeHFDMKBGbbqa/Ym4/sxw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8599
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/3/23 02:06, Huang Rui wrote:
> On Thu, Jun 29, 2023 at 09:54:54PM +0800, Limonciello, Mario wrote:
>> Some applications may want to query the base frequency to tell when
>> a processor is operating in boost.
>>
>> Tested-by: Wyes Karny <wyes.karny@amd.com>
>> Reviewed-by: Wyes Karny <wyes.karny@amd.com>
>> Co-developed-by: Perry Yuan <perry.yuan@amd.com>
>> Signed-off-by: Perry Yuan <perry.yuan@amd.com>
>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
>> ---
>>   Documentation/admin-guide/pm/amd-pstate.rst |  4 ++++
>>   drivers/cpufreq/amd-pstate.c                | 15 +++++++++++++++
>>   2 files changed, 19 insertions(+)
>>
>> diff --git a/Documentation/admin-guide/pm/amd-pstate.rst b/Documentation/admin-guide/pm/amd-pstate.rst
>> index 1cf40f69278cd..e68267857e859 100644
>> --- a/Documentation/admin-guide/pm/amd-pstate.rst
>> +++ b/Documentation/admin-guide/pm/amd-pstate.rst
>> @@ -281,6 +281,10 @@ integer values defined between 0 to 255 when EPP feature is enabled by platform
>>   firmware, if EPP feature is disabled, driver will ignore the written value
>>   This attribute is read-write.
>>   
>> +``base_frequency``
>> +	Shows the base frequency of the CPU. Frequencies above this will be in the
>> +  ``boost`` range. This attribute is read-only.
>> +
>>   Other performance and frequency values can be read back from
>>   ``/sys/devices/system/cpu/cpuX/acpi_cppc/``, see :ref:`cppc_sysfs`.
>>   
>> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
>> index 81fba0dcbee99..0fec66b3f7241 100644
>> --- a/drivers/cpufreq/amd-pstate.c
>> +++ b/drivers/cpufreq/amd-pstate.c
>> @@ -1037,6 +1037,19 @@ static ssize_t store_status(struct kobject *a, struct kobj_attribute *b,
>>   	return ret < 0 ? ret : count;
>>   }
>>   
>> +static ssize_t show_base_frequency(struct cpufreq_policy *policy, char *buf)
>> +{
>> +	struct amd_cpudata *cpudata = policy->driver_data;
>> +	u32 nominal_freq;
>> +
>> +	nominal_freq = amd_get_nominal_freq(cpudata);
>> +	if (nominal_freq < 0)
>> +		return nominal_freq;
>> +
>> +	return sysfs_emit(buf, "%d\n", nominal_freq);
>> +}
> 
> User can get it from nominal_freq at drivers/acpi/cppc_acpi.c:
> 
> show_cppc_data(cppc_get_perf_caps, cppc_perf_caps, nominal_freq);

Thanks for sharing that, I wasn't aware.  This patch is unnecessary indeed.

> 
> Thanks,
> Ray
> 
>> +
>> +cpufreq_freq_attr_ro(base_frequency);
>>   cpufreq_freq_attr_ro(amd_pstate_max_freq);
>>   cpufreq_freq_attr_ro(amd_pstate_lowest_nonlinear_freq);
>>   
>> @@ -1049,6 +1062,7 @@ static struct freq_attr *amd_pstate_attr[] = {
>>   	&amd_pstate_max_freq,
>>   	&amd_pstate_lowest_nonlinear_freq,
>>   	&amd_pstate_highest_perf,
>> +	&base_frequency,
>>   	NULL,
>>   };
>>   
>> @@ -1058,6 +1072,7 @@ static struct freq_attr *amd_pstate_epp_attr[] = {
>>   	&amd_pstate_highest_perf,
>>   	&energy_performance_preference,
>>   	&energy_performance_available_preferences,
>> +	&base_frequency,
>>   	NULL,
>>   };
>>   
>> -- 
>> 2.34.1
>>