Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e32f52b1-a983-d569-4645-a6eee2ccd78b@oracle.com>
Date:   Mon, 3 Jul 2023 19:18:57 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH 3/4] mm/memory: convert do_shared_fault() to folios
Content-Language: en-US
To:     Matthew Wilcox <willy@infradead.org>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        akpm@linux-foundation.org
References: <20230703055850.227169-1-sidhartha.kumar@oracle.com>
 <20230703055850.227169-3-sidhartha.kumar@oracle.com>
 <ZKNaVJCDH7ac8SCu@casper.infradead.org>
From:   Sidhartha Kumar <sidhartha.kumar@oracle.com>
In-Reply-To: <ZKNaVJCDH7ac8SCu@casper.infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VEpNSW9mT0VoQWN4dVNrQjRRSWVETnNVS3RQQjFEU1hGU05XSTVJVUVzelVH?=
 =?utf-8?B?RC93UXpZY3JDRE9WMjl0SU16ZURRM0d5RmZEcTJmLzFGa3pPTXVjOWFxSUly?=
 =?utf-8?B?b0ZmMGlzT1MzcDdoYmZrUmV3Q0NUbUZPS1FuakVUY0VvS1R3NjN2QUhQSFF4?=
 =?utf-8?B?aVpHMzJpck5PbEFxQXRCRUNXVjE2QXhuanBZeVRPY280QTNZTzFLQ1Ewd1FJ?=
 =?utf-8?B?RGUrall2TTlvcUhBZThsbEg2VnN2ZTk0bW84L0VRRExXRHJObUlTTkN1Ykw2?=
 =?utf-8?B?TVBzNDNvbHRnbzFQVEc4dFhUdFRJRC82dG5LUHFyRmRYZmhNOFpYTUtXdk9M?=
 =?utf-8?B?cHpoMjNXeUJpS1dVMFhHanlkWWNDemVua0hXOTAvUWQ2Q3RoY1g3cVd2eWUw?=
 =?utf-8?B?RjhOOE1WYXBHb2Y2YkNJc0tiVitaTG02UlgxYnVHSHRoY1JwZms0Q2ZHNm5Y?=
 =?utf-8?B?UzEzT2lHdDVPRElZV2lDNzlwRGdRaEFxMXBOaUhVKzIzNU9mTkVZT3Bzd096?=
 =?utf-8?B?NUcwQ3JsaDgzczRRbU1oQWNYZGFKWFlod2Uyb2RMMXAyUGlmNENybitHK1Fo?=
 =?utf-8?B?a3kvSHI2emQ1a00wekdxYm1JeWFFcGEyM1E3Vnl4ODBVMWY5Skc4RGkwSjA5?=
 =?utf-8?B?UkRVaXZGOVJXSFlBSnNMZWppQTQyYyt2NkNDdnNRRXl6aUtnVG1lTVl0VldD?=
 =?utf-8?B?WktEczdOaHRpUjNHbVYyUDdhVW1lUzZMTXMrYlFnSVRzYzBZcVB1STAvak5Z?=
 =?utf-8?B?bnc0VC9qOUFWUk1uZmVEcjcrZlUrOWxsalZzWklycC9naWREcm5kellvbUEx?=
 =?utf-8?B?QmpJRnpUMTNJNGZ2dUlSS2xnVVpBTWgvZjNWL21xN3RuZk1qWHh4bHRxQ2w3?=
 =?utf-8?B?cWZLS1JCZEFIY0pqaDhyRzlpMkVXZzBMYnVRaU5ZaU54eC83MlEwNGhERWMy?=
 =?utf-8?B?NmFnUWJKK2l2a1gyUG1UT2RoMDlncG14REY3bXRLejhmbXZCWjJjRmtRVmRP?=
 =?utf-8?B?VExHQVU2TnhERm4ydkZtbjVYM3pNL0FVeHE2djYyK3JPWFo0Q043YlJGQ0p3?=
 =?utf-8?B?WXZNR2s4UnJKKy9IMlZBMVlyaWZYeEJkVTBFUW85S1M4VXVWQVhwUHFVcW4v?=
 =?utf-8?B?WlB0aFNMMlRDRElJcURtRkswTTFHMmMyZE05UVFhRlJtZ1ZqVzMyMHZ2aTZy?=
 =?utf-8?B?T1VpZEU2VE96VGpraEJZZ0JQcktnOXdla0cvckhlWkR6N2M3aGJzWWtPMG1H?=
 =?utf-8?B?N3RlY0hxMEs2RTdaR2V2TVJDenQ2VW9uSzBvd0t2NE1ENXlwckNGMElRdnBW?=
 =?utf-8?B?b09HRVBSMW9ONTdzNEV0ZDkycHkyQ0JoamNEcGR5SWFScWpDMzg4aTUwaXVP?=
 =?utf-8?B?TS9sd0I3QjhCekxKUElTUHBXQTZhTm5BQVpGYmlWSklRSGxDTTFyZUJjWVcz?=
 =?utf-8?B?NGo5SzFhS2preG9HU2x4d3JCQ1Y1SDhudFZSY2dwQWljN1FGK3ZkTm9HNnRG?=
 =?utf-8?B?L3pwUTBxNUZjMXJxRzZxbDFQSUJ5amtSRExBWFBKN01XaHIzMEFTcDc2a1hX?=
 =?utf-8?B?ckJvcmFSZDZRZHFUOHhDUGQ1U3c4OFVFSy9sSTJuR2FEbndRbU9nTmtabXlo?=
 =?utf-8?B?NjZ6VDYzUzJ0MDFCeU5pYmVWZDByaHlpalNzbFpPUS9USmRCVTdJeko4aEtN?=
 =?utf-8?B?L3VRVFgwZG1GMkNuS3RobW4xcFF1Q3I0QkF3UW1iUTdHS2UrZ1lYeEUzSE1o?=
 =?utf-8?B?WERvTFdsb0xWRzFjSHRNeXV2bDZDbHkzRjA3R3QvRlowTmp4VUxIY2RoRDlF?=
 =?utf-8?B?bG1lWWlUdTVsczBsTnQ2NXdXelYydGVFaEwvVysvcWtic1E3bkdtNVBCK0Ry?=
 =?utf-8?B?Ti9zeHVJMXRTM2U2dWpsWWtSOU5MaHZ4eVJUam9CWHY5dnJpVVhYZXc5cU1P?=
 =?utf-8?B?TG56ZmxhSmVocjZlWDRYRDhvYmtUVGxXMUJkWUxTUE9GYU9sYVVTaTBaMFBw?=
 =?utf-8?B?NzFCT1ZhRUxYZXd6ZjRKZ2dvKzVrb1pEUnRGM0dxZ1ZEamZNV1ZtUjNwSUtz?=
 =?utf-8?B?NkVBZlFkRGdmdDBTSFpUVC9oRnZBV0h0WTR6N2pka28vV0FLRTVieFZYSlFY?=
 =?utf-8?B?cmwwWm5XUWIrTTdsZzdxTnRMeldibVhoRkZBMTBucEs3SXMzYThFeitiV0V6?=
 =?utf-8?Q?FHnIeyAOTinEpNKFYaenKUY=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: G5nN4A+im4qPOmVFwg4eVtIltp67c3XHRdRfGWxB2LPx2w8rFKCyCrxZUmkw9HY6Zv5qXERYXxz4TllXvgD+3j4JwKxKKxq/m253iodqfpoe7WgrzmSd1u7ZRJDSSwyE6IY7E5etF0P5trZHcg9Fcf1FxhTOQyzlTU5sxsoMRrB41SRlMYrDWdfUPdM7eFXl/q2FD7j0UmRNyqXkBXdTTah6CJZnqrCI2o0T8fDj35ka1Wcg2Kr6StND5WWMZ4IWXZhn319rVVl47Ges6tlEVz5k0LGU+S4bVa+ZISTVgqIcFarsS1KnJxsl8c7TyWBbl2ey13H2rG1qepVNJhdbHApD8Wy0kp6ZjogPKhf4lKtPSC1JFWxBb8D3LYKre7HZd1vngqkfyYqiI2+gu4nxkyFkzs0Xn6ncu/JQozGNP0s2nmNI3snwCDT+AuRlHiNKbBTjr8E4a6oKFc16WtLdXW6Y7oYRGJIv9jqFXbi5P93QGOUN5ELbVJEH90eadZdDLGI+pwAfRdToF31SBe6EorNFpCQGoGMyhiXDsH7OmwQkAoPrJRiY2mAL6iCsJvG0EGr4XXnftI2MABtJFqIRldwxhDANCEj5gAW7qa7srwT+i6MozCHfgYJVLMGhQUYT4YoQrBKDhwys7Jd8EJn30W6+JgxkL1Ov51R/lDwvm98IMLtX2EA7wtCCUrrdKHYA4alwoaH547Yo+2OlPI3rONEGH7gsFCu76UE33KDnKU9zk7oJ119idRqqL4fPSm9w1rW8IIxZrwfGkIGDGCMe4W834mQwiAgzB1KbciycoT56Vli0QKnbTGk9t61ReXQ2nSDQMttj7YB4fO17cgpXpDcH5M+tyQ5Nzu/6o/9qqUhRh5i91DRF2e/vpX/ZWksr
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ec793856-9dcd-4832-9078-08db7c35076b
X-MS-Exchange-CrossTenant-AuthSource: CH0PR10MB5113.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 02:19:00.4919
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RMG+ASk+1AxD2cUoq4u+QmP0DQD9fxzFNokvDiaiCTTteTKIwNX3R4CgWY22M+KTShdwFLsEhP6JbDBfNk6RAw9hkj8diQUqmD8S2fNnqVc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR10MB6468
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-03_17,2023-06-30_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 bulkscore=0
 malwarescore=0 mlxlogscore=999 adultscore=0 spamscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000
 definitions=main-2307040018
X-Proofpoint-ORIG-GUID: LnUoQgG976eEEtt4S6BKg3LNZ0gIS3nx
X-Proofpoint-GUID: LnUoQgG976eEEtt4S6BKg3LNZ0gIS3nx
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/3/23 4:31 PM, Matthew Wilcox wrote:
> On Sun, Jul 02, 2023 at 10:58:49PM -0700, Sidhartha Kumar wrote:
>> Saves three implicit calls to compound_head().
>>
>> Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
>> ---
>>   mm/memory.c | 9 +++++----
>>   1 file changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/mm/memory.c b/mm/memory.c
>> index 93480e846ace6..33bf13431974c 100644
>> --- a/mm/memory.c
>> +++ b/mm/memory.c
>> @@ -4594,6 +4594,7 @@ static vm_fault_t do_shared_fault(struct vm_fault *vmf)
>>   {
>>   	struct vm_area_struct *vma = vmf->vma;
>>   	vm_fault_t ret, tmp;
>> +	struct folio *folio = page_folio(vmf->page);
> 
> You can't call page_folio() until after __do_fault().  Did you test this
> series?

I thought it would be straightforward enough without testing but I 
didn't realize the initialization in __do_fault(). I will test and 
incorporate the other suggestions for a v2.

Thanks
> 
>>   	ret = __do_fault(vmf);
>>   	if (unlikely(ret & (VM_FAULT_ERROR | VM_FAULT_NOPAGE | VM_FAULT_RETRY)))