Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4774639c-d4f1-0b7d-1ebc-578e957b9f69@amlogic.com>
Date:   Tue, 4 Jul 2023 10:23:16 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH 3/3] arm64: dts: add support for C3 power domain
 controller
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Kevin Hilman <khilman@baylibre.com>
References: <20230703093142.2028500-1-xianwei.zhao@amlogic.com>
 <20230703093142.2028500-4-xianwei.zhao@amlogic.com>
 <992f74b3-373c-14d2-12cc-85ada068d54b@linaro.org>
From:   Xianwei Zhao <xianwei.zhao@amlogic.com>
In-Reply-To: <992f74b3-373c-14d2-12cc-85ada068d54b@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QWszaFY2cEhVNXQzaTRERWROZUU5ODFDQUNoT0crb0t2Z2k1K3lvOGN1ODlK?=
 =?utf-8?B?YkNQN25mVDJIUVJoSEE5d0hOa2FqN0I0QjFqNUFwQU5qeGt4aXAxMS8rSFU5?=
 =?utf-8?B?SU9pQVpqeC83N1hHWWF5ZVFDMjJQaHQ3VmlTdGZBdFVRNitoRi8zK0dZK3Fx?=
 =?utf-8?B?NXhsWjNTZndScVg1OC9CVnVOTjY0TW1xbVFyUldmV1JBUXUyTFk5dmJxVmJH?=
 =?utf-8?B?ZUZIQWt2dGFjSnRFWGNZd2dYTU1vOEZMRU0vMnRlWTdvN1kvM3J3YWovTnlp?=
 =?utf-8?B?bGxCM2lUcWp1L3hKUXI0Q205MEZnQmRseFhvdVpwUk91UEZKSHc0Rm92ais0?=
 =?utf-8?B?V2NwNTErQVgvR0o2TGRCdm9jcTBQSHNENGw4aTRxTjc2aFdEbW5zRlpFUkl0?=
 =?utf-8?B?ZENpT0tmU3I4YWpuN2tMYk1IRTVselRPdXE1SDAvZW91cE9lR1JZSEdjZDhi?=
 =?utf-8?B?S2ducG5rR2NhVHNPTnFVUmFxYTBMNGkwbi9uYXVzM0twMjNCRWxiNksyQVV0?=
 =?utf-8?B?MGl3QXFncWtLNmJHUGNWVlBSMy82QThaaVFZQ09NL3hRN3VacjB5ZEp6QWYx?=
 =?utf-8?B?MjJPY1AwdGowTFdNbTF3a0Yrb2pvYk1GRHFKQmJzRUdKTjlVSkFrN3czZHBz?=
 =?utf-8?B?RkxwQ1ppMjUwY3pKY29nckZCWS93Q3o5S3B4ZElBaDg4bVlFcFpqVUQwaS9m?=
 =?utf-8?B?VEM0QnVrQlVoTnp6MUE2YVRuS21Uei90OG5vc202U015WC9sV05hWFNqZmtT?=
 =?utf-8?B?NDV4bDBzclpFZU9mV0tuUkJyQWNjaEgrUGIvZE1ZbXVvODdkRUtMb2VFODdM?=
 =?utf-8?B?Snd0NEswcWwreWxjS1FNdzhUa3R2OGRzK1RkaWc1dVlhdnV5NWVCSUt2amI5?=
 =?utf-8?B?THdQbk56SzRtenc4NzIycVVPbms0eFBGQm5lRHQxZGxSc0pEdFVzeFhabjlN?=
 =?utf-8?B?UHFEODd5NU5TSnVMQXdMaFFBblVDSER3d1htNk4yaVRBM3dHblFrNUZYYVly?=
 =?utf-8?B?aXM1Sm1CcUpXUVJnOWIwaUNXaktlQlFZUGl1R1daclIyd2dscy9uMTQ4dThr?=
 =?utf-8?B?L0hoSWhyak5LekhhUVNKMmpmeTJNVlQzcWhyQ0J2TWRsU3d0SkFXMTRLRlVp?=
 =?utf-8?B?aU9iMTQ1K1NrcTcrQnZQRElDUy8xMXJIQVVtUTZwQTl5RDU0aTVpdmtWMDRZ?=
 =?utf-8?B?TFhaQTNKRDZyQWRlMitnaGJvamN4MC9sL1ZKaGI0bFI0a0ttOEFtcWRRa0t3?=
 =?utf-8?B?RWpLN2hvQzg5bWwraytXMGhrTUQzdm9HNXM1Ny9ZTWJGQ2xyNnRvWFNWVm9M?=
 =?utf-8?B?Q0Zhc2N4Y3RtekpSVzhKM3JURjZrZXhtWGZrNTN0cUxOSGN5S1l1VkEwa2VP?=
 =?utf-8?B?Z1BLSVhkMUY5SFNUZ1FjRks1bE5CSVBMN0FSNnpPR0c1SUNpL3Joc3BsOWFB?=
 =?utf-8?B?VTBlV0w2dTdDempmZFpVNmUwYS9Jczg3d043UGRHc2RsdncvazRFaXhleXlT?=
 =?utf-8?B?MkhSaENmVDV2U3NmMHRkbVRROFNWVWtvWEJlWjcwdjMrVUNIVTNaM2hhMnNJ?=
 =?utf-8?B?OWsxNnBhN3BqbnFWYkVxaDUvYkNTNkJ3dzNRRncvODE0aW5Jd0tzS3pjTy9T?=
 =?utf-8?B?WnF3SzFRUlVZM0s2OTBaZzFMb2U3UUs5VC9HVHFTeVpDUk5sTFY1b1c4dndU?=
 =?utf-8?B?SVQvcFZ6MVJTRG12UnBSQ25pT29BSWdNaWJjN05XSmViclNQNEtuZmRsblNo?=
 =?utf-8?B?SWY0YTA1SzE2MURYS3d0N1JuQnNVK0ZCRWdockU0V1g5QVlkOFFZTUJVN0tv?=
 =?utf-8?B?amtMVlU1bTVxYzdvZDJzYXk2M1NNV0djWlZwWHBYNGsxZ0FWdjJtei9tNlZ1?=
 =?utf-8?B?VVlQZFBpejBBSXRHRnRPVGFMc2REOUUxTElNc3VtZC9iMGFqTFNNeUp0Tm9u?=
 =?utf-8?B?aTN3cHQyT3R4K3hMM3NGQU9UcXNWelpZUTZETnQ5OGNRRXh0UEZCV2xjanps?=
 =?utf-8?B?MzBIMXVJV3RYKy9KamF0U2tiU21kNklNdGk1L2d0aHVuZnRYdlA2bkZ0dmx6?=
 =?utf-8?B?Sll3UWFWVXZteVVHSEsvd1J2UGJjTzFkU2ZmbWpHZTVTVVNDNCtXcDdxb1A0?=
 =?utf-8?B?S2VpQ3E2enZRUElVblZNTmQ1WVpyNmVCZUwwOFNYbyt0d3M0Q0gwZEZlZHds?=
 =?utf-8?B?aGc9PQ==?=
X-OriginatorOrg: amlogic.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cd572a9a-b1e6-43f7-92b9-08db7c35a2f4
X-MS-Exchange-CrossTenant-AuthSource: TYZPR03MB6896.apcprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 02:23:21.3557
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0df2add9-25ca-4b3a-acb4-c99ddf0b1114
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EA4zJdJbeqhZegLh8av8+Ca679GFAedzmJ9ZOaYLpHfAw3UHxpHZjiFnPBR36/bjoRK+WLGSP/2QHMShO0nrAA5/2+ZWbpReW7ABQ1aiVc0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY0PR03MB6242
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Krzysztof,
    Thanks for your reply.

On 2023/7/3 21:12, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
> 
> On 03/07/2023 11:31, =Xianwei Zhao wrote:
>> From: Xianwei Zhao <xianwei.zhao@amlogic.com>
>>
>> Enable power domain controller for Amlogic C3 SoC
>>
>> Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
>> ---
>>   arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi b/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi
>> index 60ad4f3eef9d..826c51b1aff6 100644
>> --- a/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi
>> @@ -47,6 +47,16 @@ xtal: xtal-clk {
>>                #clock-cells = <0>;
>>        };
>>
>> +     sm: secure-monitor {
>> +             compatible = "amlogic,meson-gxbb-sm";
>> +
>> +             pwrc: power-controller {
>> +                     compatible = "amlogic,c3-pwrc";
>> +                     #power-domain-cells = <1>;
>> +                     status = "okay";
> 
> Why do you need it? okay is by default.Will move "status" in next version.
> 
> Best regards,
> Krzysztof
>