Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ac6802f6-01a2-6b39-38c7-2fe3cea75dde@intel.com>
Date:   Tue, 4 Jul 2023 10:22:52 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.12.0
Subject: Re: [PATCH v2 3/5] mm: Default implementation of
 arch_wants_pte_order()
Content-Language: en-US
To:     Ryan Roberts <ryan.roberts@arm.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Matthew Wilcox <willy@infradead.org>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        David Hildenbrand <david@redhat.com>,
        Yu Zhao <yuzhao@google.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        Anshuman Khandual <anshuman.khandual@arm.com>,
        Yang Shi <shy828301@gmail.com>
CC:     <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>
References: <20230703135330.1865927-1-ryan.roberts@arm.com>
 <20230703135330.1865927-4-ryan.roberts@arm.com>
From:   "Yin, Fengwei" <fengwei.yin@intel.com>
In-Reply-To: <20230703135330.1865927-4-ryan.roberts@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dzhBclp6NGNJZUJYeEZnZTlsZ3FMZ1dzSWxYMy9kR3JNbWx2bjNlODFhcWZB?=
 =?utf-8?B?SlZCenFqU2dUcG5FVDBNMFQ2dVdrQWF5ZEdCUURBS0dOemMxOUFLclFHbzZW?=
 =?utf-8?B?ZHJsMDlIQVAzeS95Z2FhQ0tkakJkVG5qVWlVSVRKNmxSRGRLMVViZERJcE02?=
 =?utf-8?B?aHdTdm9JK3RvWG8wNFphT2Z2S283TDVEaEFJREtSWDNmRUpBR2k5clh3UEVr?=
 =?utf-8?B?VzJNQklqQVVkYjNtd2NGWW8rOHl0cHVDbDRhVC9jTGxZYmdxbnQzV3FMSnh1?=
 =?utf-8?B?VStZdVVoNWVYZmZtdVBLTUZGTnErZzMvVGtnMzd1cUV3Tlh2S0ZvZXdVa1FU?=
 =?utf-8?B?cHJ0S1lRNUdWK1pKdFVTR0FYcFgyTnhpQzc2TnBJRlRxV2dvU2hiNDBIb0Q0?=
 =?utf-8?B?Z3FZbmtVWXRMa3d5OGZ5UUlGdEorOGJDb21YM0JKRUk0SG9aQ2pqT0NkcFIy?=
 =?utf-8?B?c1NFeFNQQkxDZzRIT0t0NC9BVlVIakV0VWJKNnNxdmoxcTNsUU5EM0RUUDFM?=
 =?utf-8?B?bk9OS20yVUszOTBxU2ZCc0E2ZE0yaWF1U1FUUXRjY3ZCdy9kcVlTcDRsdUJh?=
 =?utf-8?B?Y091NWUwKzNkclppMG5oN08vVHVlYzRkVHZDWWRlSkFEclYwMjRibFhaemRj?=
 =?utf-8?B?aUlqdDNPV2JHemwxL3l6RE1UdnJ5T1lMREZnTExiL1VXWDhmeFB3bDYySUxW?=
 =?utf-8?B?d3NRWm50eXRiOHl6M25DcEdPM2RiZzN1OGgyY05ubkpwaDJyb0lscDJ3TVpE?=
 =?utf-8?B?SFY3RnN1OS95bEk4MEpYcDlmejhZdGRnS2NnMElrbnlCL3k5QUNRQnVEN2Nu?=
 =?utf-8?B?UjZlWjNKeWFJQllHZjZhWWJwWVduM2oyL3lQcjl2SnZOVVZMZXRDbGZnbjAr?=
 =?utf-8?B?N2ljdkJQamNoSlZzei90VEVPWTV3UE9MaENZZTRpMFhsTDc1TGtBRm0xYnd4?=
 =?utf-8?B?N3dKOTBhdTR4Y1lRVUZaVExOWldudEQ2dkRZenU0cXd2a040OEcyR2lxTWZ0?=
 =?utf-8?B?VG8vUVlSZzhLNW5wM0d3dEJWSkV1VFdIUEF1VmhIb0xoSmpBbjJhbFE0SXJQ?=
 =?utf-8?B?QU55aElvRGJjSnpyclBlNUd5NzllREs2QVpLb2F4TUVqV1BkVFhJMVpBZVFC?=
 =?utf-8?B?YzlMRjhkbG1kQVNDYnVOSy96dmM5KzhxRDZMK0FlZUVMTS85MGt1ckdEMTVi?=
 =?utf-8?B?Sy80Z29BRGgrOEFkd2FCRjNwRXVBL1lxTCtOL2Uxb1ZTZS9tOHIzQmRva3Zq?=
 =?utf-8?B?M1N5Uml1Qko4NlVraWJveXFHRk9qOUprZVpIWUsra09JZWhQc2xzNlRZZHRZ?=
 =?utf-8?B?bUg0bHdFdGx1MzB6MlMrMTQrTVU4S2REallUNE9NYmJuNTZ2Mi9naWo5ME54?=
 =?utf-8?B?WlJzaVdJZlFESmNVc1dOMnRnYk5aaVFDYzR4SG8ybGJ3S0s2amVqMm5YaUxv?=
 =?utf-8?B?ZkpJcWdSVDg4cVhVSEZITzZ6T2RHVHZGN3pHRVZ0U3dxemtpSE9sMllRZ2xW?=
 =?utf-8?B?VmtKbVJZM1NsMnNSdERudC9KVm16d3ZFVVZQTFVQNlNUOEtBMW0wNjhMNVAy?=
 =?utf-8?B?QnU1ZGNYSkF1N2o0MlhhZzJ5Sm9kMnAvUFFOc213ZG9Yakh0S1QrclVLc1dr?=
 =?utf-8?B?TXpYcytwc0VVREluWVZNKzQzUGNmY1p1Y2JXOFcwY294dy9PeGY2RXdqRzhG?=
 =?utf-8?B?MHdSL3RpdDVlUVFhb1BzZzNSR2UyWE1BTVVTdUFLU2Y1ZEd0Tm5Rbm5YR05h?=
 =?utf-8?B?VUdQVUhBYmpRZW9uTGdGeVE5elZvbUUvMHJGblFaNWEzZjVLT1I1V1JRSjJD?=
 =?utf-8?B?dFdKNXNXMktUTTdmTTRLRDY4S3Q2TkVHbytBYUsrOVR2ZlMrZXplMUNnb253?=
 =?utf-8?B?S2dySytDQjJiWEdvV25Oa2xXeStnLzNEdm1oWFB3RmwySmRnd2pscGJSOENH?=
 =?utf-8?B?M01lUVFwRzlMaWVMMGtIOGxDRlJaT0JzbCtyTk1VNEhteXBZOUtybzNpTlJl?=
 =?utf-8?B?RGxZZTE2TWdGR0VEdGdPTzl2Qy9ibjBCYU5hN0t4SGR5cENmQm5rK2Y4V0dB?=
 =?utf-8?B?bFB3QytRK1lJOGI3aTJDYVc1bkgzV0cwd3lMRWl3dTFOT1lYVlhwVVZRS1Y1?=
 =?utf-8?Q?0NW8hK5mlaSont3WsBbUwOfNu?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4f55b989-e8a7-4b56-1e46-08db7c359a2d
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 02:23:06.7235
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IuAL8Y3eQansLWsszmHMvOml/4ZsH+wvDV4w/pttsDqSomGx7FyTLvZKc8nVzmnZoVG19yyzDcpGQ1NHBb6pow==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR11MB5931
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/3/2023 9:53 PM, Ryan Roberts wrote:
> arch_wants_pte_order() can be overridden by the arch to return the
> preferred folio order for pte-mapped memory. This is useful as some
> architectures (e.g. arm64) can coalesce TLB entries when the physical
> memory is suitably contiguous.
> 
> The first user for this hint will be FLEXIBLE_THP, which aims to
> allocate large folios for anonymous memory to reduce page faults and
> other per-page operation costs.
> 
> Here we add the default implementation of the function, used when the
> architecture does not define it, which returns the order corresponding
> to 64K.
> 
> Signed-off-by: Ryan Roberts <ryan.roberts@arm.com>
> ---
>  include/linux/pgtable.h | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h
> index a661a17173fa..f7e38598f20b 100644
> --- a/include/linux/pgtable.h
> +++ b/include/linux/pgtable.h
> @@ -13,6 +13,7 @@
>  #include <linux/errno.h>
>  #include <asm-generic/pgtable_uffd.h>
>  #include <linux/page_table_check.h>
> +#include <linux/sizes.h>
>  
>  #if 5 - defined(__PAGETABLE_P4D_FOLDED) - defined(__PAGETABLE_PUD_FOLDED) - \
>  	defined(__PAGETABLE_PMD_FOLDED) != CONFIG_PGTABLE_LEVELS
> @@ -336,6 +337,18 @@ static inline bool arch_has_hw_pte_young(void)
>  }
>  #endif
>  
> +#ifndef arch_wants_pte_order
> +/*
> + * Returns preferred folio order for pte-mapped memory. Must be in range [0,
> + * PMD_SHIFT-PAGE_SHIFT) and must not be order-1 since THP requires large folios
> + * to be at least order-2.
> + */
> +static inline int arch_wants_pte_order(struct vm_area_struct *vma)
> +{
> +	return ilog2(SZ_64K >> PAGE_SHIFT);
Default value which is not related with any silicon may be: PAGE_ALLOC_COSTLY_ORDER?

Also, current pcp list support cache page with order 0...PAGE_ALLOC_COSTLY_ORDER, 9.
If the pcp could cover the page, the pressure to zone lock will be reduced by pcp.


Regards
Yin, Fengwei

> +}
> +#endif
> +
>  #ifndef __HAVE_ARCH_PTEP_GET_AND_CLEAR
>  static inline pte_t ptep_get_and_clear(struct mm_struct *mm,
>  				       unsigned long address,