Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Minjie Du <duminjie@vivo.com>
To:     Markus.Elfring@web.de, richard@nod.at,
        anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net,
        sfr@canb.auug.org.au, linux-um@lists.infradead.org,
        linux-kernel@vger.kernel.org, bpf@vger.kernel.org
Cc:     opensource.kernel@vivo.com, Minjie Du <duminjie@vivo.com>
Subject: [PATCH v3] um: vector: Replace undo_user_init in old code with out_free_netdev
Date:   Tue,  4 Jul 2023 12:29:42 +0800
Message-Id: <20230704042942.3984-1-duminjie@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?cHqO9fX9+walb23uwPG/dOwqnyZVgyrzXJjAEMtDJNlah2w0g4GJ4o/MMVzU?=
 =?us-ascii?Q?5GEoEh2/ANf2ahNo+VbMFHbsxjLNzWKi6DP2piJNbqDOtWSQf2AOIQVbFjsY?=
 =?us-ascii?Q?NhFbjhoBDPkMuiU7Ub1RX81xxM+4n9Hm42SMeBChzHZiuZGWKXTcBUwv7/Rp?=
 =?us-ascii?Q?yaIEzpKaXLtVRShdyph3u7xYCsLUlyYJ9qkKScw1tN5I+tUxe21WOMnkY77+?=
 =?us-ascii?Q?93C7GPd+ZG3EAWhE3wPnuySANXk34JJht8JcrTt6vpiMsUg5ZX+ymuTVlErd?=
 =?us-ascii?Q?0TmmU1kcyVeq5RBISFLkiKMpJSSZdabIxnzOL6RhnOOX5eQgihYLoXrkhBhV?=
 =?us-ascii?Q?0ITn04rbO1TFmVlig9kJ/axLeA6VbTfWBdTfnPidpe/2sgmRbhRNR/0JaI8V?=
 =?us-ascii?Q?U9Wzql1e4vGwtK5drNO1Zu5u0oG0UxCD/vrqol4wnWaQEWkPNMRw8lFVf5iX?=
 =?us-ascii?Q?OClwyuCcqVuM91IlJjcmRRPK36xO77S9Nz7gA8DbPOlChScjUIUfqD9y1y3N?=
 =?us-ascii?Q?1aQrTGM394h8kF2qCw5Af5c3aqVn2ZZS/E5+Np/ktE94kwQ00NC0tb+1wTBc?=
 =?us-ascii?Q?dCuDnCpRytQso/gqYSMrvzkNb0cACDjQniak7FrQ9nE+sO3rzb78jzS3I78Y?=
 =?us-ascii?Q?3++ETSGBQrOnzejx/Sety6aVuoSQdVnT4sf/NrTRwmyog0S3uUrpr8HUKkW3?=
 =?us-ascii?Q?1NDRNT9iBgZkmVSfFx0+PYjyQA+ae2ya5pSgjvKbYhLKzREeaUj3/OFAqKNQ?=
 =?us-ascii?Q?KJkAnFNRZbI1YdfPbg8wWa5h5VFAPu+fwDULGmYBeoFypAsqZ6Vr8JHqUtvC?=
 =?us-ascii?Q?TwA21zkNZaxskRZryHnac/EC+oJAkPCq6y7L9kahPSTAsOrWG4OpH6INcuJa?=
 =?us-ascii?Q?Y2YnST5c+HnUhjXJHlcmCwZ6y3PfG7mJstNcJRgTn5DGLD1OeLeYQj2Rk4v5?=
 =?us-ascii?Q?p8VgRROfPQNlrHssXorROTfmNeIJci3L8YIQTQ4Hkjwqz5q0NbCTYiUbz5PD?=
 =?us-ascii?Q?HeIoUvkADnTHgBY592ZChP5LPevwy8tzqif0pfMMeuYm+5J58ccII4WYYLWx?=
 =?us-ascii?Q?9bheBv2St5+rMHg/TZZBH04VxFnw+SCYaOElrGXGK4epe3j01B3Z9YwKuYI2?=
 =?us-ascii?Q?ottQOrXGUF0OBP+kU+FAeWN4VOLJkdRkvBeS5Gapk7zCEMcb2xyRpnZJnWld?=
 =?us-ascii?Q?IjUKBgUYVphMu70jt3Uk/iF8RNP+lCvJs0qn+0AULyq3ThxNDyt1JslL+79+?=
 =?us-ascii?Q?rQPdKn5NS3GgFLF7+mnO4fvE0I8ddLHAxm7IL0gaEeV2SHvALdPOPN1Lv5Oy?=
 =?us-ascii?Q?Xa/6ZW8QUEa9vpEYWCOoKI2M5VIi00qPGNwtD69l9JVtTE5wE0ynS1SsolfH?=
 =?us-ascii?Q?ObCPSbzF+l+oa3PArDlwDd+nm3IJb/uKlGANsD/2ZaKoRwqWkXLB+A1j0jHB?=
 =?us-ascii?Q?FMMoXw8LO53IwaSFCdPDlXVIWiS2+M+VpdzLyuMVSh9+YsJTWTgPeTTjav0I?=
 =?us-ascii?Q?E9dmrTitY6e72nh+5OsKRLXqNWhb/U9Db3IJ4t1Ye7wf/jxOkhfjK1kGL9OH?=
 =?us-ascii?Q?mvDq1H8k51kPs31zJVnns9F9F3cdgL9f3Z5NW2Za?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 471a884e-e11a-4809-8dab-08db7c474f56
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB5288.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 04:29:52.0771
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6gU/t4RpnJnRF71m4wXxN0Jehp+Y/NGcaydvljlNP1d5aeGRGjABamB5j4mqKnyTh1XXNXp9xc50+spmgeZ3vQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR06MB6729
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Thanks for your response and suggestions,
I made some mistakes. This is a resubmitted patch.
I got some errors with my local repository,
so I lost the commit SHA-1 ID.
Fixes: ("drivers: use free_netdev before return in vector_eth_configure()")
Please check this link to see previous replies.
Link: https://lore.kernel.org/all/8854675f-99e7-314e-c986-8dc954ee4a27@web.de/

This patch make out_free_netdev replace undo_user_init,
fix etherdev leak in error return path.


Signed-off-by: Minjie Du <duminjie@vivo.com>
---
 arch/um/drivers/vector_kern.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/um/drivers/vector_kern.c b/arch/um/drivers/vector_kern.c
index 131b7cb29..7ae6ab8df 100644
--- a/arch/um/drivers/vector_kern.c
+++ b/arch/um/drivers/vector_kern.c
@@ -1646,7 +1646,7 @@ static void vector_eth_configure(
 	err = register_netdevice(dev);
 	rtnl_unlock();
 	if (err)
-		goto out_undo_user_init;
+		goto out_free_netdev;
 
 	spin_lock(&vector_devices_lock);
 	list_add(&device->list, &vector_devices);
@@ -1654,8 +1654,6 @@ static void vector_eth_configure(
 
 	return;
 
-out_undo_user_init:
-	return;
 out_free_netdev:
 	free_netdev(dev);
 out_free_device:
-- 
2.39.0