Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp27201052rwd; Mon, 3 Jul 2023 22:58:03 -0700 (PDT) X-Google-Smtp-Source: APBJJlHLSjNiikUcy7gBUc2x0zme8W4SIXeeXNSnHCSFVuCsuYWgTO9S3w2+rzJYZ9Sl8N4y4jEt X-Received: by 2002:a17:90a:dc0c:b0:262:d4cf:9f71 with SMTP id i12-20020a17090adc0c00b00262d4cf9f71mr8985563pjv.39.1688450282900; Mon, 03 Jul 2023 22:58:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688450282; cv=none; d=google.com; s=arc-20160816; b=ONIkId2h8QQikkqgKGq+6TWT7ZAPjSD1RnFvob0HR/eQHHfFLXcBsXuLFLjGlTGXCv j2bvCKjanAMLSw42zdRB7DqWmPCTEmxGhYWQx7Q3YOfCtM9Jp55zQFjKZoPao6Tek6Bn I0z4gKT8GHcMU9uc8gylOu+TH2WXuxD8fE7cDMeDcpvy+bcN5ZMZyFfZu5BaIy8TiI7d fUDj9WJPmSlSsTVb9Okfca6Yv2vkirZhW9s9F7pMS0cAVXvsfA1xXc6yFMOzJkoKZO8E EMa0XKB/jdC420TxuoI4kQk+IoIU9lRn7s2LeUGqIu81sM7+PoNsBOjIj78p6jaTxp+G ek1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:cc:to:from :subject:message-id; bh=Cf/Z5zytS2R0564eJtQytMFhNAGWImUmoF3Z2qMUYIw=; fh=4JdQedpC5iIlyrvbufOkwGMpO57m6PJJZXYbyeYj8cc=; b=DkEC/C2s43si+Uf1Z17qYpBWzzCNTFf+iHca5hNDEaMcQ5Yu/wksH1eR8/Z0BgbQLg QRlfQAPGdYSQlLEIy6IsRovMsdi5IKHMB6J7gfi3RRuvwztkGDleOiB9qhoi+VK+509K IUG3LAmk71mHnwuXndI85rEl5FbpsEtquYRJoOT7ugLCWTjcOd8Wj02BfgqPcu/RmlN3 6GSI4nfdZg8GaTaG3fFQx6rXwrirI7llEeM2hnIwiZo27bkKgmixcrHZoP7agXGL0CvW iNqZDISQmzzYyuUrOw/5khsbBJRaFUX48PksFzlVmf/xNChBkpwKF1FqRXvpKslIuhK5 KElQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kk8-20020a17090b4a0800b00263d559dbf1si2805963pjb.55.2023.07.03.22.57.48; Mon, 03 Jul 2023 22:58:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230218AbjGDFpj convert rfc822-to-8bit (ORCPT + 99 others); Tue, 4 Jul 2023 01:45:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229732AbjGDFph (ORCPT ); Tue, 4 Jul 2023 01:45:37 -0400 Received: from outpost1.zedat.fu-berlin.de (outpost1.zedat.fu-berlin.de [130.133.4.66]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D971BAB; Mon, 3 Jul 2023 22:45:36 -0700 (PDT) Received: from inpost2.zedat.fu-berlin.de ([130.133.4.69]) by outpost.zedat.fu-berlin.de (Exim 4.95) with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1qGYqx-000NmI-2S; Tue, 04 Jul 2023 07:45:31 +0200 Received: from p57bd997f.dip0.t-ipconnect.de ([87.189.153.127] helo=suse-laptop.fritz.box) by inpost2.zedat.fu-berlin.de (Exim 4.95) with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1qGYqw-000fD4-RD; Tue, 04 Jul 2023 07:45:31 +0200 Message-ID: <485e9274ebf29da4075b40c2888f95a6cdc6d4ed.camel@physik.fu-berlin.de> Subject: Re: [PATCH v2 3/3] sh: dma: Correct the number of DMA channels in SH7709 From: John Paul Adrian Glaubitz To: Geert Uytterhoeven Cc: Artur Rojek , Yoshinori Sato , Rich Felker , Rafael Ignacio Zurita , linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 04 Jul 2023 07:45:30 +0200 In-Reply-To: References: <20230527164452.64797-1-contact@artur-rojek.eu> <20230527164452.64797-4-contact@artur-rojek.eu> <8205bc2cb9f983914ff6920deed3f54893713ba0.camel@physik.fu-berlin.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.48.3 MIME-Version: 1.0 X-Original-Sender: glaubitz@physik.fu-berlin.de X-Originating-IP: 87.189.153.127 X-ZEDAT-Hint: PO X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert! On Sat, 2023-06-17 at 13:09 +0200, Geert Uytterhoeven wrote: > Hi Adrian, > > On Sat, Jun 17, 2023 at 9:32 AM John Paul Adrian Glaubitz > wrote: > > On Thu, 2023-06-08 at 12:03 +0200, John Paul Adrian Glaubitz wrote: > > > > > > That is actually safer, as the user can override NR_ONCHIP_DMA_CHANNELS > > > > > > when configuring his kernel, thus breaking DMA due to an incorrect > > > > > > value of SH_DMAC_NR_MD_CH. > > > > > > > > > > > > Unfortunately we cannot protect against that when using a single DMAC, > > > > > > as SH_DMAC_NR_MD_CH can be either 4, 6, or 8. > > > > > > > > > > > > Perhaps this configuration should be moved from Kconfig to , > > > > > > to protect against a user overriding this value? > > > > > > > > > > Isn't SH_DMAC_NR_MD_CH already hardwired to the SoC being used? > > > > > > > > It depends on CONFIG_NR_ONCHIP_DMA_CHANNELS, while it > > > > should be fixed based on the SoC. > > > > > > I agree. However, I would be fine with merging this patch set first and fixing > > > this particular issue in a follow-up series. > > > > So, my suggestion is to take this series as-is for 6.5, then get the other issues > > you mentioned fixed for 6.6. I think it's already a gain when these issues are > > fixed and the kernel boots on the HP Journada 680 again. > > Sure, I don't want to block the acceptance of this series at all. > Thanks! Apologies for the late reply. Would you mind adding your Reviewed-by to this patch before I review and apply the series? Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913