Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp27269701rwd; Tue, 4 Jul 2023 00:09:13 -0700 (PDT) X-Google-Smtp-Source: APBJJlGsraohvHNMz5mVyehatEORjJ8M234dRmB/SOhHCR4FQhh1lCxnAoOAm8LCCW3JnWRGCyZU X-Received: by 2002:a17:902:b70c:b0:1b2:a63:9587 with SMTP id d12-20020a170902b70c00b001b20a639587mr8604500pls.36.1688454553482; Tue, 04 Jul 2023 00:09:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688454553; cv=none; d=google.com; s=arc-20160816; b=eciBddaqunpV7YwN93n3l18MWYFoSuq3iGfhGrtXrJ9GokH4FChHY0fSkQNi2+tOxi MhjgzPu7NCyFiwZ+SJYktnqte2Vt2rrnR9EiKiq2zI+MDZwwznzzkk/8kEztgzAIm7WO cTPqEYsjdDkpppevJvGZDJis4LP+T+RAtdwXid88gfLY1ZqlATCOwmTeamIGq8BKImx8 6+j6Qn9plud75Om+QwCU2IX6sHus/OgkJYJSkRVBecn3OL4zV7MOt2uyW61uFn+cBaH6 7rti38+NvzVyBz08lcjM+1kTENYJJXlY4TSFu9iS2nhP6f/Ep9yZyMLw+Sxk8zeSt64n cshg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=g3yiVYKtVrIktx4ZXP2LxSktjdyjNOhoOg2Mns2klPY=; fh=nUtlR5fnlykQgx5kjUv1QG01g+2MZPl9i3BCRLUMUuU=; b=TPlOfRyVFIHGrQUH1/wUo9fWl+zLQ2FnWVNvZsMy9qr6BeISb5PySnjHwk9vftX38e VhLcuo7rP543B788QsmbE88gxSCxNWRDMEoDFV7I1qud94ds5p1/CkPCsCTlzAfhW7xZ B/yiyd0isjU1J8Yg8TJKWpqSiK6xcCcu0awtCghpa8zeGZ1irAtLEtq6YnU+DN68nWjB VZCt13qbFcGk+eWcWS2E3x3mKYeJ27rkg/aJIHAsNYf0H2qkroIFte6YOaDYv3yCCboq 1oOote/bYHJkqOxzb5A5f/txl728uSUfaUc0kAKIql1QQ/L2hsv9Uc3Md8htnDiVTfeC or6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=M6HUebP4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id li11-20020a170903294b00b001b886cab00fsi5526738plb.247.2023.07.04.00.08.58; Tue, 04 Jul 2023 00:09:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=M6HUebP4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230507AbjGDGaf (ORCPT + 99 others); Tue, 4 Jul 2023 02:30:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230232AbjGDGad (ORCPT ); Tue, 4 Jul 2023 02:30:33 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 111891AA for ; Mon, 3 Jul 2023 23:30:31 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-51dd0205b2cso9224349a12.1 for ; Mon, 03 Jul 2023 23:30:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688452229; x=1691044229; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=g3yiVYKtVrIktx4ZXP2LxSktjdyjNOhoOg2Mns2klPY=; b=M6HUebP4sZYJ8sIy3Ulw8RejaiM+OUUBFDv0FnO16yEv5/tUV91WR4q1dWdzG/Bq/Y NlaQbI39uIzwqCfchN+Ff9c8SaNUWxjoL9ilI5LukBQBpVm8QJrEPn2FBPQe4cqbom0g fqknBmeYBapuhiWOH/4Yo6zBFNU0g1+9+bDRxpLdhCgFTCadvn0eVbLiwxh+Ep4TDZUt akG00H9lvXGVNRZ9trbrSY4qxK4jw6Utl/o9lCcromjvtwcaV7lG9WqZkfYkQhDS5YfG iy8vzgEF/QrxTFJ1mJGqyykCmjMxWPykEf/LuEqNLRD/68I8gr0gBMHRiugUdXjQ4roR 19ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688452229; x=1691044229; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=g3yiVYKtVrIktx4ZXP2LxSktjdyjNOhoOg2Mns2klPY=; b=dTPdOWLXq5psbdglk6wvp7R/dpcApaYjmFbUoJDiOoDUSUarYw01fSP4+N5+k7+uvS LmfQrobhpvL1IxQ05PMxPEdBVK1PuDRL50eWkpgHCV9QN2KogJmFCJFyhBkc/CJuhwGo Z6meGRmtbEnyKsZr6n+CVjhTvh/GL4jymnK0yTu34chbEVMvmPEFFQDr3RWaCAxHBS8A WTebffk210fJ7gRgYTVMEyL8vphNSmw4BporZ1Fncda58Z/DgN18gSm0Y1vFVYIFYrRY oufcayjWacmxZDi8099GXtUvWILGuT0hZ7/Zt0k0KOaYrYLmlIjHk4GymNGSf5F3eIqf 80FA== X-Gm-Message-State: ABy/qLa6WuCuzJx/qdgSJLUIYKxKJDpviEk+oTiioCnm7X+ZkWVlpJTm IdyqnzPXq5PutUb+9DDqk5+aFg== X-Received: by 2002:a17:906:39da:b0:973:84b0:b077 with SMTP id i26-20020a17090639da00b0097384b0b077mr12490256eje.33.1688452229530; Mon, 03 Jul 2023 23:30:29 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id a15-20020a170906468f00b00992b510089asm6496258ejr.84.2023.07.03.23.30.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Jul 2023 23:30:29 -0700 (PDT) Message-ID: Date: Tue, 4 Jul 2023 08:30:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v6 2/7] dt-bindings: soc: starfive: Add StarFive syscon module Content-Language: en-US To: Xingyu Wu , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Philipp Zabel , Conor Dooley , Emil Renner Berthing Cc: Paul Walmsley , Palmer Dabbelt , Albert Ou , Hal Feng , William Qiu , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org References: <20230704020239.288500-1-xingyu.wu@starfivetech.com> <20230704020239.288500-3-xingyu.wu@starfivetech.com> From: Krzysztof Kozlowski In-Reply-To: <20230704020239.288500-3-xingyu.wu@starfivetech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/07/2023 04:02, Xingyu Wu wrote: > From: William Qiu > > Add documentation to describe StarFive System Controller Registers. > > Co-developed-by: Xingyu Wu > Signed-off-by: Xingyu Wu > Signed-off-by: William Qiu I don't think there is a point in reviewing bindings which were never tested. I hope you agree with me. The patch just introduces errors. :( Best regards, Krzysztof