Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp27303182rwd; Tue, 4 Jul 2023 00:43:56 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6JkoAy1Okro63V/eavKATltMHYP7wi7MhueXvnWjOBPAKBc3+LM9elxYZwio1JdI319kJD X-Received: by 2002:aca:6707:0:b0:39e:c615:949f with SMTP id z7-20020aca6707000000b0039ec615949fmr14364225oix.24.1688456636194; Tue, 04 Jul 2023 00:43:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688456636; cv=none; d=google.com; s=arc-20160816; b=znRvXqngI1wZq/pcwTb+MdjNWl/Glf46q7PCGZvHYKbXQT1lcE51NJ0rIaXirYodtu 5zqSob8c+FxuPX95Q9KmmhaUXaPeNzcemwde7EEKOFTtX38MUKKQ65UDaZXY+LQmRLED katL1BK1f/rxxIY8UajoqzWA33viJ2Y17UIphslICvrjMHXaV/9/1rb7IDfsVgMwI6SR 2Jhli0RMG2QHJNzjf3HnkOOqceVdEJuz6yYQjGsPF2dSXxwPWBqQp1E7sVSDNWFGMzk+ AhrGWosdGS/AHNePPxYtrpuEx2p0YisRV/lhWnq2ql0FLQYlrZ0mvU0HDg58PNw56Mdg e3cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=VL/rjDYuUIG13BdsJvqgWfmIJd/PORYxbytF3/yFSiw=; fh=2b2bYY+f+ckhbYeGRHkWnbxqF2OLXA5lGYp2ne8Wpbk=; b=xgePkKvoLo/7NIWgbT5iTFZtGziiYNCUkOmmg9GfZtvxwG2TeoB+2iUtTiKFm7o+B5 faersmuqN91LrY9Ns/XjEoNX3ifQHfR8Gn76BNObQ6uG4mcGO/n8/4t+pXMXBlNoF3ka QPKesSrwJamhAJgJtBJr3UOiLH2+l6OCDDWvOn7+8bX4vbjPJeuGeMslwUSQfXxhRF61 dElQmseKxk8lkD7cfNfEaxVYYOrRK6AppsiCm0oXEUWiHNEByQPtJZ+WehOjs1rGD0P1 AlCOLblyUfpVJPbYAfw9MszNlzVPiOQM0SXHTfOe2Z6j514PcfnRTz3Io1L2zpJDwimX XV9g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i8-20020a17090a974800b00262ff3a4545si15822055pjw.169.2023.07.04.00.43.43; Tue, 04 Jul 2023 00:43:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230458AbjGDHHw (ORCPT + 99 others); Tue, 4 Jul 2023 03:07:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230197AbjGDHHu (ORCPT ); Tue, 4 Jul 2023 03:07:50 -0400 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AFB1C130; Tue, 4 Jul 2023 00:07:46 -0700 (PDT) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 570B78159; Tue, 4 Jul 2023 15:07:45 +0800 (CST) Received: from EXMBX061.cuchost.com (172.16.6.61) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 4 Jul 2023 15:07:44 +0800 Received: from [192.168.125.128] (113.72.144.31) by EXMBX061.cuchost.com (172.16.6.61) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 4 Jul 2023 15:07:43 +0800 Message-ID: <61120362-6b19-3683-db18-8d703ae278eb@starfivetech.com> Date: Tue, 4 Jul 2023 15:04:38 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v6 2/7] dt-bindings: soc: starfive: Add StarFive syscon module Content-Language: en-US To: Krzysztof Kozlowski CC: , , "Michael Turquette" , Stephen Boyd , "Rob Herring" , Philipp Zabel , "Conor Dooley" , Emil Renner Berthing , Paul Walmsley , Palmer Dabbelt , Albert Ou , Hal Feng , William Qiu , , References: <20230704020239.288500-1-xingyu.wu@starfivetech.com> <20230704020239.288500-3-xingyu.wu@starfivetech.com> From: Xingyu Wu In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [113.72.144.31] X-ClientProxiedBy: EXCAS062.cuchost.com (172.16.6.22) To EXMBX061.cuchost.com (172.16.6.61) X-YovoleRuleAgent: yovoleflag X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,NICE_REPLY_A, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/7/4 14:30, Krzysztof Kozlowski wrote: > On 04/07/2023 04:02, Xingyu Wu wrote: >> From: William Qiu >> >> Add documentation to describe StarFive System Controller Registers. >> >> Co-developed-by: Xingyu Wu >> Signed-off-by: Xingyu Wu >> Signed-off-by: William Qiu > > I don't think there is a point in reviewing bindings which were never > tested. I hope you agree with me. > > The patch just introduces errors. :( > Sorry, it was my fault. I tested it but found the example uncompleted. And I forgot to test it after completing it. Sorry. Best regards, Xingyu Wu