Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wang Ming <machel@vivo.com>
To:     Namjae Jeon <linkinjeon@kernel.org>,
        Steve French <sfrench@samba.org>,
        Sergey Senozhatsky <senozhatsky@chromium.org>,
        Tom Talpey <tom@talpey.com>, linux-cifs@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     opensource.kernel@vivo.com, Wang Ming <machel@vivo.com>
Subject: [PATCH v1] fs:smb:Fix unsigned expression compared with zero
Date:   Tue,  4 Jul 2023 15:40:47 +0800
Message-Id: <20230704074057.1162-1-machel@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fXvQa1A9O9iBkD0DO76lytUwAlD6+LmSLkDSjjTV6x50IQLzyi5LKJiyt/KU?=
 =?us-ascii?Q?aobrXPgi3NPOcPF9rsNWwF3afW+B4vVs9Zyh4oUX3m0yJ1zCQ3NT62bvAuZY?=
 =?us-ascii?Q?fl17K6rS9Ef6Jhg7r5euDHhR7V0exQLwgXTC/jKevYNOlzQgUfsbv0gvGzN9?=
 =?us-ascii?Q?4frNSiT1sRkztnL39/cFmye6jIqPKqYTC3HAH08pCuf+n9hb+l9D+n9+I6F0?=
 =?us-ascii?Q?C5PbmP/zyMwDiArSjJBIBR5PP7HOTJ6RgLgZD14QdtN36A3slX+uq0maIUm6?=
 =?us-ascii?Q?MyK5sGlIQC0A3Ouyot2bM7o0KM946p4jcMhw8R6JA1lYqbYtzDAoNXv79GsA?=
 =?us-ascii?Q?+RoolkfKcopWLp6xkqbP/cS9awI6piQpSTuiBm++iOYGf8VVGtaoGELWz4qo?=
 =?us-ascii?Q?1BCZE3sq2qEmXnnOr8awfxFewROliSjnTn/XnfgHF4SODUGJNqoX8C7dUP9A?=
 =?us-ascii?Q?z3Ofa6sTaUNI23SLOjN2D6OxrbY1bK9J4T48aD6SC9UIV5RV2A7hlh22gvwg?=
 =?us-ascii?Q?rKvOG+5wnHEDpSZ5BkUOu3WfJ+fEsaQxWHT8gDZLQav4Uqrxa/IRGoLsKpia?=
 =?us-ascii?Q?dpUfHzISjd0CbboTlSk7bEGFw/7PKpbXGGhBGX1yA7K+3DwG8iukh+7sNzuL?=
 =?us-ascii?Q?gERtOUKyiNjrBbpBBjWRwxjPju3+awYeYpVldGaI33OMyCJr2CCOYBFml+Yc?=
 =?us-ascii?Q?zx5hcfQ7TRYmLYoUXis31VWFUFm/pkWZEEvnojPD/zqlnwYm8VRtEbA2eMUb?=
 =?us-ascii?Q?CHUPF3AOfiVW4LF65uUFSNhaWIJFlKinH5bXbs+0O0Fn0JuVaY6pd2hZNqrf?=
 =?us-ascii?Q?ApwNfBBp/CYARe+R5qGMUzHw8GgLXYrOc7bKwkMgHQt5WhLpsdqN1vQLDJP5?=
 =?us-ascii?Q?ks0nz34H39eZUYREsIG41UQo7Mha7Uwu4hph9ZNf7HflPbbkMt+aHtTmHCgR?=
 =?us-ascii?Q?Wv2dl6HHdta41CPx5Ido+tmcCkcFFtk9YR7FDntDxZrZD1OYEHKuoqVoY51y?=
 =?us-ascii?Q?Y/NVIIWHd2yUHEjC/AwDZcFJp0zux9bcV/1djHbeLQhiEkkmXWMtQLqTQMd8?=
 =?us-ascii?Q?VycmGCUy/sL8fJEjjdvG6TaWrX9Q+ujqeFfiX2R4JazRJwmnNOPfD9p2s0/J?=
 =?us-ascii?Q?vokV5ODkT3Itw6VL+QamwZh2s7s0LRelpqvH3RZoICi+DmDUzMGH3fOl9liw?=
 =?us-ascii?Q?2VQMgdI6xlj91l60JfVf+iYyORu9cSU3IokhRnWHQ0xPkGIBoWFvTvtX0ebN?=
 =?us-ascii?Q?Fc7lYk+Ifg7OH2owKRK5mvQbmpSHbixGEM85ab7A7zfVDoddICK9w1mQihI8?=
 =?us-ascii?Q?joz5yQNuHwbrsYThHI1wTmLgYPhVw28EOxg3VXxD4FvXKDxz3WcfA0UlX3Cd?=
 =?us-ascii?Q?Gc4KikrbYo5UEknatp7Pf4UeJSH0r60bUdQjSJc+88MyXzwX9EcIsisBIZKU?=
 =?us-ascii?Q?YW2D3Vzc+lL18H6KOgT9D9oNBxhL0gNhV+ywaw3gOtw+AunpWMUWEGtJ5k63?=
 =?us-ascii?Q?h4q5vKcPqEaQUnH4PXXNHvTMrmSNwRhoE06bAuDMDA7+KdKgDizKIm+9+GEs?=
 =?us-ascii?Q?W35bI3fZ6iPmISruikGMRl6v/NrcX1CTinZFXCNb?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4cdb4c53-b972-4834-85bf-08db7c621f12
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3743.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 07:41:47.8405
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Qy7b4MTUgGLvXFTBs64WJtW+HHS2i8ehIhD7uk+h4uk4zZWMeJpYNwNlYnwDDbsGTuOQAUQuO2E09xfiyamteQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PSAPR06MB4198
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The return value of the ksmbd_vfs_getcasexattr() is signed.
However, the return value is being assigned to an unsigned
variable and subsequently recasted, causing warnings. Use
a signed type.

Signed-off-by: Wang Ming <machel@vivo.com>
---
 fs/smb/server/vfs.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/fs/smb/server/vfs.c b/fs/smb/server/vfs.c
index e35914457..e605ee96b 100644
--- a/fs/smb/server/vfs.c
+++ b/fs/smb/server/vfs.c
@@ -412,7 +412,8 @@ static int ksmbd_vfs_stream_write(struct ksmbd_file *fp, char *buf, loff_t *pos,
 {
 	char *stream_buf = NULL, *wbuf;
 	struct mnt_idmap *idmap = file_mnt_idmap(fp->filp);
-	size_t size, v_len;
+	size_t size;
+	ssize_t v_len;
 	int err = 0;
 
 	ksmbd_debug(VFS, "write stream data pos : %llu, count : %zd\n",
@@ -429,9 +430,9 @@ static int ksmbd_vfs_stream_write(struct ksmbd_file *fp, char *buf, loff_t *pos,
 				       fp->stream.name,
 				       fp->stream.size,
 				       &stream_buf);
-	if ((int)v_len < 0) {
+	if (v_len < 0) {
 		pr_err("not found stream in xattr : %zd\n", v_len);
-		err = (int)v_len;
+		err = v_len;
 		goto out;
 	}
 
-- 
2.25.1