Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wang Ming <machel@vivo.com>
To:     Dinh Nguyen <dinguyen@kernel.org>, linux-kernel@vger.kernel.org
Cc:     opensource.kernel@vivo.com, Wang Ming <machel@vivo.com>
Subject: [PATCH v1] firmware:Fix an NULL vs IS_ERR() bug in probe
Date:   Tue,  4 Jul 2023 16:26:56 +0800
Message-Id: <20230704082706.1721-1-machel@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ynoA7fgtsFGE/o25ODugEnZL6GyaVGE4lObVcZfUA2nUFSg3Y78xcpwnPH7C?=
 =?us-ascii?Q?BuITOAXN3xgOsnKv+YgbgYJ9QBl/WpbQ0IRn30zCjuSFErHz+Jb5KJIEXOB2?=
 =?us-ascii?Q?cM0yeEJJHFVmJv5JmPMjIN5pKRmsmFtF7Fi4LQrr/zcFL/HpUkdp90TcFgGa?=
 =?us-ascii?Q?EYmgs7GiUq3VCP+5rTmfiAiE0q+P3YbzLcv7TVnsAfdomCthJIjz9TqhkX76?=
 =?us-ascii?Q?T/3ygTUbL192/X58h5nLbbKUKbDlqzsM+0f0bQTJRulz+3xborUI3X6PlJ4h?=
 =?us-ascii?Q?DuT3UFrc168M5sPj7JWcH+U91WDK8N0/wf3xLBJbOEveHEhna3XbjqJwgyof?=
 =?us-ascii?Q?3JA6a2443/PGIx0mQpwsyn3DC91S1gDWy1VJ8IHlVbX0YGjziV+Cc7rHD1F8?=
 =?us-ascii?Q?fLxu1oBvg4wfMv+VAQwnM5LUHeAb0Ey1b+rAYyovEy7KyPHcCNiXC3tyctjg?=
 =?us-ascii?Q?gTmJj8RTGmJ4gCPnP6tYH/rid8ngKHJyMejqnARBH+15p6gQqvQTuitkvL8r?=
 =?us-ascii?Q?HyPAxR5ffUbWY489N1MOdnoa0c61Ji5BSnafopHaebh7NX08mAf7ZViPen1v?=
 =?us-ascii?Q?PmQLnLjkl4PARCwTJtMAWt69rZ4vkhPKvfuiX8N747qiEqa7c8P8vD4U83z9?=
 =?us-ascii?Q?kEqdV4zrAhVc0DnlSV6i2W2nYiQf+bS6H8anw9BntF71pMzEGh6u8DJJO+9v?=
 =?us-ascii?Q?h74T1huHD6uuT95i6S84UEmZtHcD3c3UyDFtRbXVJWksCKPAHf+m/GJ+ROYV?=
 =?us-ascii?Q?a+69glNTLgtNB9jJdZkrQwhHZf/Ujpm/tRxndvC+otWxj0cENKNwlkog+9GR?=
 =?us-ascii?Q?aNe9Rx0kxrZcfANHYBzZ1QW21FuqKx8xPnVzp/13bFMielmXYUlGq5QRcnz0?=
 =?us-ascii?Q?zpcv7zGrZmuzA7tcyApzGq+6HNmjCVWSZe0zCIAsg47L3BzUrFKKx2mZOXJL?=
 =?us-ascii?Q?jLiJ6TYpZpKjjg+nnyhH9tXbpYxGECoHiMQsBVLePDK18dyT6szbY1HMKUln?=
 =?us-ascii?Q?XjbXMSMW6NDtSigVVIr6hyenasQUbHD9yYv5LBil5qriPw1er2y/8Qds7VJr?=
 =?us-ascii?Q?+UOx1Q8p8DdMQ/uHxNNTSj6mPUcEWBYz84pAUFFXZeqpm1k8FzUArCZbS67r?=
 =?us-ascii?Q?G2U07aGC4PYNTisBgJw87OMVCJFAQqYIWf+Os81e5iKVpY/u6tUgce2Myryu?=
 =?us-ascii?Q?H3kbaGZAukxc4foCGxm2UEq5wbFKKo+7EPmRmqJlTOqoFrTzK92iQiodT5kd?=
 =?us-ascii?Q?imD4eDC+faheczLNLbiGuV9Qpy8V9Z+Z7y4va2ovnuG28ljnhTT4jibCGhIm?=
 =?us-ascii?Q?rgCKPKG7oUojh6u83H7FIL5RmSYYexsxBlKJsbgk4NUAFTbYyyHfLRdvTq8g?=
 =?us-ascii?Q?imtfdmjlL7P1kZlzyS9a2ZpjO3AgRp6QD4DD9H1Eo0KmeTyo9pGAU8cOa5FE?=
 =?us-ascii?Q?liTo17ZM3EMunewtjqOh2BDjJifCEU2fZe5LqrQ5ZTNHoX8UmYglHoATGjlE?=
 =?us-ascii?Q?aQ4y6o0MVoVTcTD+qvHwOiiSlsBYFGCbkcDIMsHuieuwGNhcljrIfTOKunis?=
 =?us-ascii?Q?atJaaZQEll4iyWYzPF5Wz4JdeCvjcXZEjHvHPn31?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c1cbca43-5bcd-4f41-c337-08db7c68802f
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3743.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 08:27:27.7942
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: A0WVw/cgL02YoM6rxRNEGPDRzhPrI0FfiTGIWw7JAhkGbaQmoXeQn7xheTtrt10zs8xdQxtrf5AWo2+geMq1mA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB4107
X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The devm_memremap() function returns error pointers.
It never returns NULL. Fix the check.

Signed-off-by: Wang Ming <machel@vivo.com>
---
 drivers/firmware/stratix10-svc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/stratix10-svc.c b/drivers/firmware/stratix10-svc.c
index 2d6741261..cab11af28 100644
--- a/drivers/firmware/stratix10-svc.c
+++ b/drivers/firmware/stratix10-svc.c
@@ -756,7 +756,7 @@ svc_create_memory_pool(struct platform_device *pdev,
 	paddr = begin;
 	size = end - begin;
 	va = devm_memremap(dev, paddr, size, MEMREMAP_WC);
-	if (!va) {
+	if (IS_ERR(va)) {
 		dev_err(dev, "fail to remap shared memory\n");
 		return ERR_PTR(-EINVAL);
 	}
-- 
2.25.1