Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <20805fef-d6aa-91d8-999e-04b1d6b7a37a@vivo.com>
Date:   Tue, 4 Jul 2023 17:06:12 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [PATCH v3 1/5] genirq/devres: Add
 devm_request_threaded_irq_emsg()
To:     Krzysztof Kozlowski <krzk@kernel.org>,
        =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= <u.kleine-koenig@pengutronix.de>,
        miquel.raynal@bootlin.com
Cc:     miquel.raynal@bootlin.com, rafael@kernel.org,
        daniel.lezcano@linaro.org, amitk@kernel.org, rui.zhang@intel.com,
        mmayer@broadcom.com, bcm-kernel-feedback-list@broadcom.com,
        florian.fainelli@broadcom.com, tglx@linutronix.de,
        matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com,
        bchihi@baylibre.com, wenst@chromium.org, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org
References: <20230703090455.62101-1-frank.li@vivo.com>
 <20230703090455.62101-2-frank.li@vivo.com>
 <f4873823-fd7e-c6dd-fbc0-eac4a9be52b1@kernel.org>
 <20230703174347.4m6hcmify4jwsozv@pengutronix.de>
 <11052797-b006-11bb-e4eb-987ddd568b24@kernel.org>
From:   Yangtao Li <frank.li@vivo.com>
In-Reply-To: <11052797-b006-11bb-e4eb-987ddd568b24@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UWZHbDJaeERSUHZ6NVh0RkpOdThBOXZndmtBRXZpRS9uRWQwelEzOHBJMWdo?=
 =?utf-8?B?d2FqVnZxdG9jRHhMdFQ0alJ3YU1WUHJSYk0vc29DUm1JYmZGOXE1ZzJXT0Fy?=
 =?utf-8?B?M2pUeEwxY2RBYXFuYkZCZ2pWaFZaWXBjOTBnL0NqMk1oR2lBME9nTFptNkIw?=
 =?utf-8?B?MVVwdm9LVlM5RVVITnhoTE9vaW9pTzlXRWdYLy9wUTczQVFPWTdRUFN4cVpn?=
 =?utf-8?B?Mm5maVVPS0FCYjhnWnlUQVhEWHdobXF5c2txV25vZTBtNDJyQnBqaDNKK2lM?=
 =?utf-8?B?ckw4U3JSZTFseE1wSlk0ZEcxazEwOU1HTlEyVmxnOXptMVZCM0p6T1pGeWlo?=
 =?utf-8?B?TEcwcFN4MUhZTVVReDN3cjRMRzZPVFJQNm9XaithT3FZSkJwNUozTHNpUzRx?=
 =?utf-8?B?QnJQU0pNOE5Mcm9QVkRVbjlKek9UbWtHRHkvclNic0hveEl0d29hcTE0RDJ4?=
 =?utf-8?B?NkpJZ3pnRHI2SVNrc0k3L1lXZ25oODZzakQyZitMNkRuVEJ6UFZKdm5wVTF4?=
 =?utf-8?B?V0ZWSDk2UWdlUFozeGRQRVZZelRBQVNSb2VhT2xoWXkxUXBwT1h3b3BWaFV4?=
 =?utf-8?B?YmRVTGg2cHlzRXUvNDlMRHBzMFZCeFhrSDRLV2h6SGVTUFJSTVIvYm5mZ1hX?=
 =?utf-8?B?QTVralBTak92VER6ZFU2aFJmdnBBWHdpMjVYcEFoWHVLeWsrRTJPNDFYTnoy?=
 =?utf-8?B?V3ZveWM1b3Q3SDdjWmx3OS9iNXJFamppMjczSnlIbDlnZTcyZ0ptVllJQUd0?=
 =?utf-8?B?T0cvWVZrQjNjTmkrcWFoQzhEalJEdWNqbEdBa3Uyb01yN3dZYUkwTUU3SnVW?=
 =?utf-8?B?NkIyaWdmeUVJbjB0NWdGRDdIK1h5b1JXZ0tIbmVNMy9lR2dlaHVLOVkxS21h?=
 =?utf-8?B?L2QwZTFnRDZlWFlISGpiZi8rdk9qSXBoSFlmclRMZTQ4YzZlSkdHWjFLUGZj?=
 =?utf-8?B?aGlkQ1ZLOEtUc29KcVRhT3R1MDVsQlhKUjRYWGR3R2JvQlh4Qy82TVNsbGVL?=
 =?utf-8?B?ZEZOQVhaZFp3d3RteVE3amJUZGJlT0orajhMMTl2RGVmUVE3a2FWOFpYOUE2?=
 =?utf-8?B?RC8rdDJyQmFNdmpHWEtwR0RiNDhORllHNGtRU3ljWkVCYUthcUVrTEJZdEdM?=
 =?utf-8?B?ME1hZ3p0WnJqTUdPY0JBdkg4SituRDN3QVdNbkllTFZVMy9GdXo3VXlydlpk?=
 =?utf-8?B?NC96Zk9LOHdtMS9wOXk3WGRrR0c2bnU4U0hFcmx2QTBZdmRra1JTVGhIS0Fw?=
 =?utf-8?B?NUh6NWFjNmd5bEYzTGM4c2lEcFY2WklFbTE3bkd5ZUJsa3NrNVVUTmhOUWxR?=
 =?utf-8?B?bTBOQzZlcnV5TDZpcGU0Q1ZUbHVNenQzZUt4NElaaUtmTWZyVVZoc0hnaFZF?=
 =?utf-8?B?Zm15c3E1Ukh5Mmw2MzR4NTVFR0xRS25pa3pmRWZudGlsU3pGOFJtZ2Nrb3Zz?=
 =?utf-8?B?SXpLN3I3OTZzN0dqK0Y0UmtZRDJLQUJDM0pXZ296MmJkNlg0eElBRlI4bmpk?=
 =?utf-8?B?c3ZFS28zdzlkbC9adXJNc0owQTExNzNBZnRhZm9RTWQ5M2I5eE0zb1lDK0pZ?=
 =?utf-8?B?eS91SFNkYmdjTVp6bkRtdkpoQVBUNmpRUHYvdyswdjhPT21vNkViTFlqYUJp?=
 =?utf-8?B?UlNUZXlvM0p3UFRlK3JWNGdGZUtoUnlOYmtuSExaeW5DQXBicmI0a3l6UW9V?=
 =?utf-8?B?STEyZXZIY3c4N09yOUg2Z2pCeFV6L1M0VXNCd05aalJma2N0MGFqdnMrZHNs?=
 =?utf-8?B?elNrRFBQa3ZZcy8zSHE5Sm1RZlpJeDVaVkVDdTNmWVg5bTJhcmtKTThVNW1E?=
 =?utf-8?B?cngyNVd3azYraVVDMzZQOHBubFU4YkttQnI3ekIrNTJOOERoUnBBVHJ2Sm5W?=
 =?utf-8?B?VGwrZ2VHOTN6QnNkUVZtZTFoWnkwZEJsdG5iTzJHaEZzOStNck92cEt6dFhE?=
 =?utf-8?B?aGRLR2JpR0RsQzBrMUhmZ2RBVk14QXJ2ZE5uY1hmT1ZoMzJrYjFyWjBENjNM?=
 =?utf-8?B?eDVvdlZKUUdrK05IcmtwejN2ZE5SQVhjVmRhNHBxTGx2ODhZRG5yUUxvNHFZ?=
 =?utf-8?B?VS9obWs0UDR0YXZxbFFnZGtMMVAwR1pNeGp6M21JWGRyU1BoN3RES00vSmtC?=
 =?utf-8?Q?kYRMdJZD8W5VrWBVg423scfnI?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2ec8b286-88bf-4ec9-687f-08db7c6ded52
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 09:06:18.0974
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yRP6Z0l3V+LtL/rgIUS4xA3wbnruAmCH/wHQY2sTkEsqNJy9IqxMtPqvECN0NEOxWToGlzoxwr0VbMqUIFF1dg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR06MB5062
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2023/7/4 16:48, Krzysztof Kozlowski wrote:

> [你通常不会收到来自 krzk@kernel.org 的电子邮件。请访问 https://aka.ms/LearnAboutSenderIdentification，以了解这一点为什么很重要]
>
> On 03/07/2023 19:43, Uwe Kleine-König wrote:
>> Hello Krzysztof,
>>
>> On Mon, Jul 03, 2023 at 02:31:59PM +0200, Krzysztof Kozlowski wrote:
>>> On 03/07/2023 11:04, Yangtao Li wrote:
>>>> There are more than 700 calls to the devm_request_threaded_irq method.
>>>> Most drivers only request one interrupt resource, and these error
>>>> messages are basically the same. If error messages are printed
>>>> everywhere, more than 1000 lines of code can be saved by removing the
>>>> msg in the driver.
>>>
>>> ...
>>>
>>>> +int devm_request_threaded_irq_emsg(struct device *dev, unsigned int irq,
>>>> +                              irq_handler_t handler, irq_handler_t thread_fn,
>>>> +                              unsigned long irqflags, const char *devname,
>>>> +                              void *dev_id, const char *emsg)
>>>> +{
>>>> +   int rc;
>>>> +
>>>> +   rc = devm_request_threaded_irq(dev, irq, handler, NULL, irqflags,
>>>> +                                  devname, dev_id);
>>>> +   if (rc && rc != -EPROBE_DEFER) {
>>>> +           dev_err(dev, "Failed to request %sinterrupt %u %s %s: %pe\n",
>>>> +                   thread_fn ? "threaded " : "", irq, devname ? : dev_name(dev),
>>>> +                   emsg ? : "", ERR_PTR(rc));
>>> It is open-coding dev_err_probe(). Just use dev_err_probe instead.
>> dev_err_probe is supposed to be only called in probe functions, while
>> devm_request_threaded_irq might be called in other contexts (e.g. when a
>> device is opened). That's why I asked to not use dev_err_probe() in v2
> True, but then all the callers of this function will forget to set
> deferred probe reason.


So let's use dev_err_probe?


BTW, any suggestions for names here, keep using 
devm_request_threaded_irq_emsg or change to a new name?

I am afraid that after more drivers are changed in the follow-up series, 
the name will need to be changed again.


Thx,

Yangtao


>
> Best regards,
> Krzysztof
>