Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Minjie Du <duminjie@vivo.com>
To:     Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-media@vger.kernel.org (open list:GO7007 MPEG CODEC),
        linux-kernel@vger.kernel.org (open list)
Cc:     opensource.kernel@vivo.com, Minjie Du <duminjie@vivo.com>
Subject: [PATCH v1] drivers: usb: remove duplicate logical judgments in if
Date:   Tue,  4 Jul 2023 18:40:17 +0800
Message-Id: <20230704104017.9535-1-duminjie@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QPcmbQVbMuZ9lt23GpNYkJO3MZigONJ7CA0HpUXJPhI6evYRoDpTCtLLDEmM?=
 =?us-ascii?Q?lkYzsb5f3RAi/8S3qpkSUJEHS0xl6ofJXSkSEi8Etbs3EVdwPWEfRwEUR0Hq?=
 =?us-ascii?Q?tNmlTLpBTktE8+VsNUpDltPe2k0FrqGsgdawLS7JY1oNDD1hnfWnV15WeZC9?=
 =?us-ascii?Q?Zh/+lsXoHiMUEaAMp8+wnHKz1RcIo4yxOy5NGEQHBEvoKcygj4qckdNIZn4n?=
 =?us-ascii?Q?F+xFxyczow7/01F20l+PqM14fPYY8qOcTQWeEmjeJmuOxJOTYF4YaLJn+tyC?=
 =?us-ascii?Q?ljzEKCsqpYfQYEmphhgrP+fz2YTrcieXiVjQRuzpme5J9kWOyanZIhN9HlHt?=
 =?us-ascii?Q?AGEQBU1LJ5zqPyKwWJqj33/3IBjLKxtixtnahgc5lHM4kZk8/Gq3APb5dcI3?=
 =?us-ascii?Q?bLHEiSOHxPobSrefugX4vpQt12Jivp1u1/jFEFsv/V631LBbvuzExwwkcZ21?=
 =?us-ascii?Q?0qyTF2LQUH5L5xabS4o6MaJEJRJ3gDH+4b7gn5JQQW9YPUgianIozkPtAKXs?=
 =?us-ascii?Q?4NapP+OD0OqeuWVmkcz30nWMM422zjvE3wB0/aX8mHG0eGP5K+x4rhb/0bOg?=
 =?us-ascii?Q?aZwsigrIlbVh8/DEQqF3K/sJYdwL2i3mhcUawUyxKxFRQQTTACAGabxAQr/V?=
 =?us-ascii?Q?g7xc2++7bw0zzhzVWvDeqi7e9hKXoIVSCqB3Hcl4I3NY1rTkDOuc7ByAhI+v?=
 =?us-ascii?Q?ckSVlOG7S851pmdoWWYOmwth1ZlEqWFt3D90XgGQ6n/rEZhQC5C7+NSu44ZK?=
 =?us-ascii?Q?2SdFQ3ahJILGXRMzGF5s4j/7tr+T6W9OkPeqTSwiyOtPfjQrAHp0FsLTg3fL?=
 =?us-ascii?Q?BgO/8eGTTzG65vYaKJpi6Uu614zBRlRuIiWJX4NV8cddHGiTWmoh2hq67n+Z?=
 =?us-ascii?Q?gdrRSd+BnPzUqvzJQoAbxdOYRN24FTFYThtmJfvX5yT9elVCFLAMJ7wyT/M8?=
 =?us-ascii?Q?aswq7r4COP4isEgYMRKg6n5s69+81M5Wh7ZC5ZqMPeRhSz0X7tgY6y4q+pzW?=
 =?us-ascii?Q?twJIjE7WXlC61RkKaWR+XDssr085C/S49gomkDimVyioZl6XEOu9rP0oGQxt?=
 =?us-ascii?Q?u2D+O5GjNWCjFjLZ0BbTfXX9sE6FWXc94CIZaP+8yrT2x/8FpSG58CxTfPZb?=
 =?us-ascii?Q?Z1zd/vy60w9nCdquypCUuyImcDq3TZ6n3VZzIe0F0y1WPFdlF8lTfHYizg1h?=
 =?us-ascii?Q?o3/x7QCML2pAzTa6IdzZSRZAJMeIGbuoCymrGD7F1IeA38G1gziTt86QxTCK?=
 =?us-ascii?Q?RuPnK0qFOPcvLC+7yWWLfps+4UUQwvtl8UylSIFC1Oh/dymSrLBJa4KlTP7K?=
 =?us-ascii?Q?vxsjFdLUoko+E8pS7VRLvAfRNLgfFTXB6R1vkVY9jEymh9d6x3VnmpP3LKbZ?=
 =?us-ascii?Q?dAye02xjKa9DSJSU9m+q+HaVjmn4aBXtcbyU009iluDeK61pJnWkgGGXjJXW?=
 =?us-ascii?Q?ROMF4e6C6IEyRDP2H81GIZCW2KwPlCOO3jW3QA5qOPgjbriKoKirCftiys8X?=
 =?us-ascii?Q?qNTyk90YdeL/MFbxpefyKt7pHNw1/PWEKacfi9ISURLgOPtvAvuTFkrb+Qvl?=
 =?us-ascii?Q?v0ne+fRHxVltq3FVWdfSdXt5AnNasjok0X+RD9iN?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c6fe0428-c205-4a6c-c959-08db7c7b1647
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB5288.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 10:40:30.1585
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EMFALRk/j5z1uT2vLNDyP0OFqxp1OY3qCum2p0jjf8pQunC8PYvB61Lf5s7rNZtDJKBhPhZyRrObRkbSAwE7HQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB3956
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix: delate duplicate judgments
Does the judgment content of this if
mean requesting confirmation twice?
I'm not sure, Could you help check it out?
Thank you!

Signed-off-by: Minjie Du <duminjie@vivo.com>
---
 drivers/media/usb/go7007/go7007-usb.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/media/usb/go7007/go7007-usb.c b/drivers/media/usb/go7007/go7007-usb.c
index eeb85981e..c85e48e16 100644
--- a/drivers/media/usb/go7007/go7007-usb.c
+++ b/drivers/media/usb/go7007/go7007-usb.c
@@ -653,8 +653,7 @@ static int go7007_usb_interface_reset(struct go7007 *go)
 	if (usb->board->flags & GO7007_USB_EZUSB) {
 		/* Reset buffer in EZ-USB */
 		pr_debug("resetting EZ-USB buffers\n");
-		if (go7007_usb_vendor_request(go, 0x10, 0, 0, NULL, 0, 0) < 0 ||
-		    go7007_usb_vendor_request(go, 0x10, 0, 0, NULL, 0, 0) < 0)
+		if (go7007_usb_vendor_request(go, 0x10, 0, 0, NULL, 0, 0) < 0)
 			return -1;
 
 		/* Reset encoder again */
-- 
2.39.0