Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230703143820.152479-1-matteorizzo@google.com> <abd3f78b-5027-f859-27c8-296108ec8e92@google.com>
In-Reply-To: <abd3f78b-5027-f859-27c8-296108ec8e92@google.com>
From:   Matteo Rizzo <matteorizzo@google.com>
Date:   Tue, 4 Jul 2023 13:26:12 +0200
Message-ID: <CAHKB1wJE+1B_t-NDTPEfw+vGSAe=HFScXEu0riA1-3o8s1GEfA@mail.gmail.com>
Subject: Re: [PATCH] mm/slub: refactor freelist to use custom type
To:     David Rientjes <rientjes@google.com>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org, cl@linux.com,
        penberg@kernel.org, iamjoonsoo.kim@lge.com,
        akpm@linux-foundation.org, vbabka@suse.cz,
        roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, jannh@google.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, 3 Jul 2023 at 22:10, David Rientjes <rientjes@google.com> wrote:
> Seems strange this would only appear for configs without CONFIG_SLUB_TINY.
>
> Since lots of files include linux/slab.h I think this may start to be used
> in non-slab code.  Not sure why it needs to be added to the header file?
>

Thanks for the comments! I think that makes sense. I will move the typedef
to slub.c and move it out of the ifdef (since that also broke the build with
SLUB_TINY).

--
Matteo