Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 4 Jul 2023 12:54:55 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Fabio Estevam <festevam@gmail.com>
Cc:     Richard Zhu <hongxing.zhu@nxp.com>,
        Lucas Stach <l.stach@pengutronix.de>,
        Lorenzo Pieralisi <lpieralisi@kernel.org>,
        Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>,
        Rob Herring <robh@kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        NXP Linux Team <linux-imx@nxp.com>,
        linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: dwc: Provide deinit callback for i.MX
Message-ID: <9e7d3961-4189-4141-a342-d15a34fefc9d@sirena.org.uk>
References: <20230703-pci-imx-regulator-cleanup-v1-1-b6c050ae2bad@kernel.org>
 <CAOMZO5AghPUsVqMRdByR9hOatwHmgx90mq1HyZYFGkw1WaAY_Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="RJaCUe86uaOocYwV"
Content-Disposition: inline
In-Reply-To: <CAOMZO5AghPUsVqMRdByR9hOatwHmgx90mq1HyZYFGkw1WaAY_Q@mail.gmail.com>
Precedence: bulk


--RJaCUe86uaOocYwV
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jul 04, 2023 at 08:50:15AM -0300, Fabio Estevam wrote:

> I recall seeing this regulator warning before:
> f81f095e8771 ("PCI: imx6: Allow to probe when dw_pcie_wait_for_link() fai=
ls")

> I think the real issue is why does the probe fail when the link is not up?

Well, they're both issues - if someone unloads or unbinds the driver we
can still trigger this, even if the probe succeeded.

> It should not fail to probe. At least, this was the original intention
> with Rob's commit:

> 886a9c134755 ("PCI: dwc: Move link handling into common code")

> +       return 0;
>=20
>  err_remove_edma:
>         dw_pcie_edma_remove(pci);

I have no idea about doing this, all the PCI on the board that I care
about seems to work fine (and worked fine even with the failure, I'm not
sure this is being generated by a link that's in use).

--RJaCUe86uaOocYwV
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmSkCI8ACgkQJNaLcl1U
h9AdOAf+JjQDVzex+YNa8DZECCgYOVwY1gJ6m+ExNYxZ53AmiNfvp4VmQrp1Qtx4
0swTzBob6WbTd2merzyOSLqa/AEe2vUAnsfFtVdQZybd2MSXiSQMXuZTgFXgUQ5q
xIJqnUlQUMtXphxgMyPNZsF+qCXJHDWCc7ibgKBeYie186LlDrO39rTsnwz5M8P4
GKH3hH3AU3CtmFI+H72C/TnAeCz8gbxwIxLrCneVT258OcyrnIXVg9u4K+x/1kMD
kfoVXzoeFrGWYZLWH7+BbDqjmbct0xuhPed1QUfOiEnflgk6yOv6KFQ9wqAP1a9E
8X5XelpIwi4BQdfBTaQqqQvYVJ88yw==
=bPQV
-----END PGP SIGNATURE-----

--RJaCUe86uaOocYwV--