Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp27587105rwd; Tue, 4 Jul 2023 05:13:38 -0700 (PDT) X-Google-Smtp-Source: APBJJlG7Be8KOUmQsMy8Ky3zSRExUVUOcDaQyC6hInt14EDtXLTVpeKoyFRELo7BIJ1ryGu1ZQtV X-Received: by 2002:a05:6a20:72a7:b0:10a:c09c:bd with SMTP id o39-20020a056a2072a700b0010ac09c00bdmr13463754pzk.55.1688472818171; Tue, 04 Jul 2023 05:13:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688472818; cv=none; d=google.com; s=arc-20160816; b=R7GKeJaxeO/3uKXIQFgUPwtsdh+l8uIuut/fQP6S0wi3kwbPcsbxOHCX3O1xyKMbeY EZkvlIuPAEJtbtqI7Y0Dx6Xnjs4YIHmGddKXJUI3EOSGjwP0c4n0GWuOIZk00BkGhRY+ HK9T/IftI6eJ/9zgz2ZW+jzzNT0KlT4kDxwYcH/VjV1eiKI5t0f6ZOJxGwwXgK1OHYvB 5lH4PsGpmvejUdno0LnhnaCcyBBMcUP6ZcBQOrBJSEN8LbCrNr15Efz4kM8SYL20EoPt LS9REHUFUDH4M3B0C2NzECCmYUO/riuR1wCZmf30lqJpMedvhr04lQD9gnP4cnrb5tHm ai7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=tAiyEsWCWyq2z78cMUwk6PNMXTnMW8+o+CyEZeXTGIU=; fh=9MczmVpGOlK2cKeBQ5koM1jwW9+jgAvWf3iW+5FlF10=; b=D9XeooeFD7VRo1NTd9CIJlyIjbhc5jmwXXXgwgz74gQg/56Ri4bzBbtKDsj9y0b/dU rTduJi+RlU+FCT7T3Nd7FX9Z0Fd5Oi1JdfjAAUicHYSPHMgKnz34YSbdEhhi+Q/RkYG/ 66XVMa4A8x/0gyjo5PHXwoHEGzD8aBm+k7wecJmPyJdKNJcnDPqUHAawt3MBLWYsSYnT 2c2xdLHveTbaUcFXfzonr7CMpAOGoEgubk3Mp0BlxkT9VdsQBoASG9QiKN86yLBiUFdh lf/XyUqUue69JW3EAPcnNpmxFOJaJ/BJjce/Sj5xmyBGSzgLtaM3j5LaqkEBUs3LP+YC qnWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bytedance.com header.s=google header.b=i8YlNS8T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=bytedance.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cz8-20020aa79308000000b0065addb172d1si19941403pfb.380.2023.07.04.05.13.25; Tue, 04 Jul 2023 05:13:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bytedance.com header.s=google header.b=i8YlNS8T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=bytedance.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230519AbjGDLuY (ORCPT + 99 others); Tue, 4 Jul 2023 07:50:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229840AbjGDLuX (ORCPT ); Tue, 4 Jul 2023 07:50:23 -0400 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0325135 for ; Tue, 4 Jul 2023 04:49:57 -0700 (PDT) Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-3fb4146e8ceso66927935e9.0 for ; Tue, 04 Jul 2023 04:49:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1688471396; x=1691063396; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=tAiyEsWCWyq2z78cMUwk6PNMXTnMW8+o+CyEZeXTGIU=; b=i8YlNS8TuNFPRBmKNbTcjHjWmx1z1P+n4az1iMaWnaI6OM0PhnyBYanuGfZiZIZfMC bfaszxk52zrYyUNYk2n6WzRhTLtx05UseaVVqtMT7ohajYVrvJN2XAKQiGkzRKFw4x38 /b6XufE3lh4MMXzSBt35McFuVAn86A/akbaCIDKO540u5XJ5JXo/C2gXS/O5Y6+2nZue p95wOB/CKUYpQ0YV3U1yBkSELXnB1nWSbxSPfe1FJAMJEmUYoZsD9KO1Gg+2+6FBLlLq M998Q4V1goU5/s/6opq2KGKAYGtlFmn3g5F3+lBbrV4YGVdf2ouRn+3ksJYr6Ff39L0a MFTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688471396; x=1691063396; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tAiyEsWCWyq2z78cMUwk6PNMXTnMW8+o+CyEZeXTGIU=; b=Saz2eNj+pFCL6gHALLm34CZYDhnv0hxw4uas3mH2Jvzt7Os+EXCttS6Z23SRncMpZZ M2GAaxbSmiqOsWzHLpuMssgWSt+HdSNp3t8BwIyc2eS6OGdXLoqdLn1Ypee0gUuqKe+n 9LjgTUiBvykoi/wwO6gFjW/isqa84lqhUHEO72pOWtUvA/1ht90bpHb4NZZeLcFa8fDy AwqWnNvBT2DoIWf42UnjrQ07h9ORUYubZBCfXJnh+QEmH+pjO6YfiKeTDaCMzVw0LYTJ 0iZSeFdS+Bh55uTwEpy07yQgMJ5NpyaimLAZIQu8MWC/G2wE0e077M7P2J8gqDkcZf55 XIgQ== X-Gm-Message-State: ABy/qLYXRKT+St1/utNvxaIngV49RnlS1WLWrJKQL5Xp9vIMvr7GISZJ SukM3OpyQDwb7Z2d/QCLI0FZEIgTH0UIV3ukrt6Wb0/Ju3iJMpNp3IPlAEVJ X-Received: by 2002:a05:6000:12d2:b0:30f:c7e4:d207 with SMTP id l18-20020a05600012d200b0030fc7e4d207mr10129430wrx.61.1688471396138; Tue, 04 Jul 2023 04:49:56 -0700 (PDT) MIME-Version: 1.0 References: <20230704101942.2819426-1-liushixin2@huawei.com> In-Reply-To: <20230704101942.2819426-1-liushixin2@huawei.com> From: Muchun Song Date: Tue, 4 Jul 2023 19:49:18 +0800 Message-ID: Subject: Re: [External] [PATCH] bootmem: remove the vmemmap pages from kmemleak in free_bootmem_page To: Liu Shixin Cc: Matthew Wilcox , Mike Kravetz , Oscar Salvador , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, muchun.song@linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 4, 2023 at 5:23=E2=80=AFPM Liu Shixin w= rote: > > commit dd0ff4d12dd2 ("bootmem: remove the vmemmap pages from kmemleak in > put_page_bootmem") fix an overlaps existing problem of kmemleak. But the > problem still existed when HAVE_BOOTMEM_INFO_NODE is disabled, because in > this case, free_bootmem_page() will call free_reserved_page() directly. > > Fix the problem by adding kmemleak_free_part() in free_bootmem_page() > when HAVE_BOOTMEM_INFO_NODE is disabled. > > Fixes: f41f2ed43ca5 ("mm: hugetlb: free the vmemmap pages associated with= each HugeTLB page") > Signed-off-by: Liu Shixin Acked-by: Muchun Song Thanks.