Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c6d4daa1-d58a-2a29-3121-e1405c3ccc15@linaro.org>
Date:   Tue, 4 Jul 2023 14:12:47 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
From:   Neil Armstrong <neil.armstrong@linaro.org>
Reply-To: neil.armstrong@linaro.org
Subject: Re: [PATCH 2/7] reset: meson-audio-arb: Convert to
 devm_platform_ioremap_resource()
Content-Language: en-US
To:     Yangtao Li <frank.li@vivo.com>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Kevin Hilman <khilman@baylibre.com>,
        Jerome Brunet <jbrunet@baylibre.com>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc:     linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20230704120211.38122-1-frank.li@vivo.com>
 <20230704120211.38122-2-frank.li@vivo.com>
Organization: Linaro Developer Services
In-Reply-To: <20230704120211.38122-2-frank.li@vivo.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 04/07/2023 14:02, Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code.
> 
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
> ---
>   drivers/reset/reset-meson-audio-arb.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/reset/reset-meson-audio-arb.c b/drivers/reset/reset-meson-audio-arb.c
> index 6a3f6a6a3bbf..355e041214bd 100644
> --- a/drivers/reset/reset-meson-audio-arb.c
> +++ b/drivers/reset/reset-meson-audio-arb.c
> @@ -138,7 +138,6 @@ static int meson_audio_arb_probe(struct platform_device *pdev)
>   	struct device *dev = &pdev->dev;
>   	const struct meson_audio_arb_match_data *data;
>   	struct meson_audio_arb_data *arb;
> -	struct resource *res;
>   	int ret;
>   
>   	data = of_device_get_match_data(dev);
> @@ -154,8 +153,7 @@ static int meson_audio_arb_probe(struct platform_device *pdev)
>   	if (IS_ERR(arb->clk))
>   		return dev_err_probe(dev, PTR_ERR(arb->clk), "failed to get clock\n");
>   
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	arb->regs = devm_ioremap_resource(dev, res);
> +	arb->regs = devm_platform_ioremap_resource(pdev, 0);
>   	if (IS_ERR(arb->regs))
>   		return PTR_ERR(arb->regs);
>   

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>