Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp27599950rwd; Tue, 4 Jul 2023 05:23:05 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ72//dBph8zS67TeUJu0QQ0HjbJPZI5xK9xHpcdaM8zO/fSX91cZXrUWixwBMUHk3QujUJv X-Received: by 2002:a05:6a20:c529:b0:12d:1ae8:a62d with SMTP id gm41-20020a056a20c52900b0012d1ae8a62dmr11491352pzb.19.1688473385164; Tue, 04 Jul 2023 05:23:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688473385; cv=none; d=google.com; s=arc-20160816; b=hYHW9tm6rqkkGNu08v+PIKO3zh9XBNmuIRwtrzQvQlcs9o7DvlBPCxBNEq/qbxF66M l1OWpw4Tg7UyTk8bEsNmnWkJa4yVkVFecd5xbSU03Iya+rPwUnDPdwB04Jv0iuG4oHp5 IVRCEV7azr5BGnL2Z4xjkVfM4wOj7W/lrFz+EvXP0Rsz/iwE+hp7u2Agvra7SRW5gAa0 xBEBkpK2CBCu5tvDmqsZwlzHD23wJ6IO2EHqBhwv2EbaU8ZG9PbfxUvXbYLRsQMqPnbQ TVWQJOHGRnomN7e9XiaNMOi/AzxrpWjk6d6vOuCkKQuJJ2oI3G95Hm7qBV2MYpjk6Iw6 CQVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=aq47B29bXJzrFBRuSE2mt59wfTh8kGj23uIbGTF0YY4=; fh=NAuXkc5JSLEXANS/WGzRBo8+pvt2IHDPVUsBNLp4AZI=; b=FKXRoBhe8bMtUaciTsRa+LG8CvR0Cj9mkOz8HHRH1dr2ypiame01KEzhl9HldguV0r gG6RnrAy66Yg+CDDXmO6+yOEHTOe1AtA689Bhm3k0aI60MfwkA+VWIDbE+LRNqSnlxCo nQ7r4vXto6xZKzark2e1F/yO7MgG95gf8ZtW0f02qgIlv2j4vc2pMFiDBJYoO5tVoJW0 qQepuAHxkRQAksf5Y8zHDASmpTE8qqaw01pzqX+08VIXC91RTOZV+03p2TQc65xApNEm 5E3QGOht3QtuQtYvx8KaXD4lNJrPY5X79hfHCkgvcPADMGUuRqkMpVJEIyMZwKOOWtH2 l07A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=W4slGW66; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q16-20020a170902bd9000b001b674055d72si19628899pls.621.2023.07.04.05.22.52; Tue, 04 Jul 2023 05:23:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=W4slGW66; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231574AbjGDMNl (ORCPT + 99 others); Tue, 4 Jul 2023 08:13:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231522AbjGDMNg (ORCPT ); Tue, 4 Jul 2023 08:13:36 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD7FF10FC; Tue, 4 Jul 2023 05:13:03 -0700 (PDT) Received: from [IPV6:2001:b07:2ed:14ed:c5f8:7372:f042:90a2] (unknown [IPv6:2001:b07:2ed:14ed:c5f8:7372:f042:90a2]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 4642C6606F8B; Tue, 4 Jul 2023 13:12:57 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1688472778; bh=CjCDfoY6i3YerAvedNb5hATHIfJzgR2uOpS4TTgZOTM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=W4slGW667UPKIThapHffTziQPpnmELSow9332LOXhlPN2RqMl2B2vqziApzo8iDrm RaxqAks6khxIix/7LNIh6Pdn/iclPuh+68S+4Rblv5XUbbtodl9wVAs9cGKWLtJJsF hBCwBWQgWNTI4SIY2eJV5otAgaLJimQXpPrcHvyZbKv+lujS/F4aTHJjijhG/dvYGh i+ngfHnjih5nDLeXQgayIIqQDor9QOHGsPiW6QPq641gCCWyGCIC7pwxpaz3PcxT+t 3wPUh5Vrhe3K9h2yEa7hZZjlCBfgA3MpL9zBJRJDH2b2B+dyis3mugvp54W7rTNTgE 9rrWo970Uw4xw== Message-ID: <421d7e5e-e28c-12ef-90ce-c976efd5b37e@collabora.com> Date: Tue, 4 Jul 2023 14:12:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v5,07/11] media: mediatek: vcodec: separate struct 'mtk_vcodec_ctx' Content-Language: en-US To: Yunfei Dong , =?UTF-8?Q?N=c3=adcolas_F_=2e_R_=2e_A_=2e_Prado?= , Nicolas Dufresne , Hans Verkuil , Benjamin Gaignard , Nathan Hebert Cc: Chen-Yu Tsai , Hsin-Yi Wang , Fritz Koenig , Daniel Vetter , Steve Cho , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20230704111327.7140-1-yunfei.dong@mediatek.com> <20230704111327.7140-8-yunfei.dong@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20230704111327.7140-8-yunfei.dong@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 04/07/23 13:13, Yunfei Dong ha scritto: > Adding different context struct for encoder and decoder and removing > struct 'mtk_vcodec_ctx'. > > Signed-off-by: Yunfei Dong > Reviewed-by: Nicolas Dufresne > --- > .../mediatek/vcodec/mtk_vcodec_com_drv.h | 76 +++++ Only one remark. "com" may mean "communication" or "common", but if you rename this to `mtk_vcodec_cmn_drv.h`, then "cmn" can only mean "common", which would increase the chances to immediately understand what the header is about. Unless, of course, anyone else has strong opinions against. Besides.... Reviewed-by: AngeloGioacchino Del Regno